net/iavf: move debug dump desc flag to config file
Checks
Commit Message
DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable
it user needs to edit the Makefile. It is felt that this method is not
good. Hence removing this flag from IAVF makefile and adding a flag
CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base.
Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
---
config/common_base | 1 +
drivers/net/iavf/Makefile | 3 ---
drivers/net/iavf/iavf_rxtx.h | 2 +-
3 files changed, 2 insertions(+), 4 deletions(-)
Comments
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lavanya
> Govindarajan
> Sent: Monday, June 10, 2019 9:08 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> Parthasarathy, JananeeX M <jananeex.m.parthasarathy@intel.com>;
> Govindarajan, LavanyaX <lavanyax.govindarajan@intel.com>
> Subject: [dpdk-dev] [PATCH] net/iavf: move debug dump desc flag to config
> file
>
> DEBUG_DUMP_DESC flag is commented out in IAVF Makefile and to enable it
> user needs to edit the Makefile. It is felt that this method is not good. Hence
> removing this flag from IAVF makefile and adding a flag
> CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC to config/common_base.
>
> Signed-off-by: Lavanya Govindarajan <lavanyax.govindarajan@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -327,6 +327,7 @@ CONFIG_RTE_LIBRTE_IAVF_INC_VECTOR=y
CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX=n
CONFIG_RTE_LIBRTE_IAVF_DEBUG_TX_FREE=n
CONFIG_RTE_LIBRTE_IAVF_DEBUG_RX=n
+CONFIG_RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC=n
CONFIG_RTE_LIBRTE_IAVF_16BYTE_RX_DESC=n
#
# Compile burst-oriented IPN3KE PMD driver
@@ -13,9 +13,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
LDLIBS += -lrte_bus_pci
-# used to dump HW descriptor for debugging
-# CFLAGS += -DDEBUG_DUMP_DESC
-
EXPORT_MAP := rte_pmd_iavf_version.map
LIBABIVER := 1
@@ -255,7 +255,7 @@ void iavf_dump_tx_descriptor(const struct iavf_tx_queue *txq,
tx_desc->cmd_type_offset_bsz);
}
-#ifdef DEBUG_DUMP_DESC
+#ifdef RTE_LIBRTE_IAVF_DEBUG_DUMP_DESC
#define IAVF_DUMP_RX_DESC(rxq, desc, rx_id) \
iavf_dump_rx_descriptor(rxq, desc, rx_id)
#define IAVF_DUMP_TX_DESC(txq, desc, tx_id) \