From patchwork Sat Jun 8 00:19:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 54557 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 807691BCAE; Sat, 8 Jun 2019 02:20:25 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 3AE141BC90 for ; Sat, 8 Jun 2019 02:20:17 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id x15so2065642pfq.0 for ; Fri, 07 Jun 2019 17:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MyR0bTf4Mt+he7JIm/J3aX664JMTwBCJZQUUdrjjaXE=; b=qD44xcJWdg0VBS+LLyUehorG052dRyCX2NHEeM4cxj6DZHSqKYZ25Qt8hvGwMJAsPO o9p93+vIIlbwCSSTnK/r4oSO9D3RiT9CUvCQwLhRutiVgNiLUDJqy2q3HPF4Lsl1FZDE v6kX178ENqkN5vkgS1ZSPnpTydpEXCMQ/pKT6bJPncEZXDGLejJrLCN0sNS+qjPwH9SA e9YPeoL3B6yVgRSIQ4Y6cBfTWUrjsLcYI2p4Cq6N7cbFSz0RjjmPQ7j+3JBDrxxqhBVQ lCJ4g9BXF5ZcBEfE32iFuNIb2z/eYl8gbCxDj+sqcX7s3Nz+E7BMX3Ncmt/ikb6o4kgo LetQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MyR0bTf4Mt+he7JIm/J3aX664JMTwBCJZQUUdrjjaXE=; b=uYp3LUdW+RfCV0fvg7Vabv0VSljsXtA4CZzOLuxWtoJHKMb9kKcFVoqid6FePebwx0 JTjU/2nguBDFcD3XC3iI58jZs6wdCLFeOq2MyUxaqj7b+2T8gLFHqqix6gFYci9AEhix TbVf2zfIhXyDRVYWM9/u2GRWUrc03+xaRso24ZFoKCElAzDog5VjlIO8Mb03zIlWq8c6 OZSEojwi/0q//Nv1rzIQ2zeo/jcfn385Cdcvs5zLEsfMv+U+Pc3irL0SgWctqBaGIte0 /Kmov8FqstOxOaXSNO9rG3pl0sqpYRRIX4Nn5Yyo88/sa4TRt2dD2arU9k22iQl54cQd hCXw== X-Gm-Message-State: APjAAAWt4j+4jQKXlXRnH9TUs5+xaw/i1oalnCI0amHDsg0Or+n7PEpa NmnzOB7eqg7Ds3ULj7H5NF9o50kdZZU= X-Google-Smtp-Source: APXvYqzaZ9+owUCJI5fW3JTtD4oX9DCJRSkCA73C5gUGeSV3IWbq9ELBrfYnGIg8I5ebeHCTumU+Dw== X-Received: by 2002:a17:90a:62cb:: with SMTP id k11mr8257620pjs.26.1559953216422; Fri, 07 Jun 2019 17:20:16 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n184sm4012463pfn.21.2019.06.07.17.20.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 17:20:15 -0700 (PDT) From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Fri, 7 Jun 2019 17:19:59 -0700 Message-Id: <20190608002003.19942-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190608002003.19942-1-stephen@networkplumber.org> References: <20190608002003.19942-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 5/9] kni: drop unused group_id and device_id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Kni devices no longer are restricted to PCI and device_id in kni_dev is no longer used. The group_id is set but never used. The fields do need to stay in the ABI (dev_info) but kernel can ignore them. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_dev.h | 4 ---- kernel/linux/kni/kni_misc.c | 1 - 2 files changed, 5 deletions(-) diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h index ca3b07678b96..e39af97feaa7 100644 --- a/kernel/linux/kni/kni_dev.h +++ b/kernel/linux/kni/kni_dev.h @@ -40,7 +40,6 @@ struct kni_dev { struct list_head list; int status; - uint16_t group_id; /* Group ID of a group of KNI devices */ uint32_t core_id; /* Core ID to bind */ char name[RTE_KNI_NAMESIZE]; /* Network device name */ struct task_struct *pthread; @@ -49,9 +48,6 @@ struct kni_dev { wait_queue_head_t wq; struct mutex sync_lock; - /* PCI device id */ - uint16_t device_id; - /* kni device */ struct net_device *net_dev; diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index af18c67c422f..6a206d883c0d 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -346,7 +346,6 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, kni = netdev_priv(net_dev); kni->net_dev = net_dev; - kni->group_id = dev_info.group_id; kni->core_id = dev_info.core_id; strncpy(kni->name, dev_info.name, RTE_KNI_NAMESIZE);