From patchwork Sat Jun 8 00:19:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 54554 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4EE31BC99; Sat, 8 Jun 2019 02:20:18 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 235591BC84 for ; Sat, 8 Jun 2019 02:20:14 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id bi6so1008303plb.12 for ; Fri, 07 Jun 2019 17:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VLK4KVn81E10EBS5qXls3g7KXlhM31ZSO449iJbEFmE=; b=uIljI+cttZOf9SwS0j4EiRElfqlCIcJj0n3G7q6VdlzTVxUAddxhH0/rmcHmmmwawT DNV9suRNFxM2muYnaTx5+NvowMhpjr6znp9KL0gAnZkYkDDtfocwgSDOlyYITBSJpRg6 3GAnH6brV8+oIgu8GgHqWc8NuzfCvS1ghCrSqo8Suy890cDE0yOu3Fw1MTUd9jPwhPp/ oEWch2HbsMrgSvB6xouljPGXgXbSU1vjYz8g2u5NY7wXwESVKPfg2k4eTWf1l/3N7c8f fJ0wmpZ76uTKOoYSEjaQBcrf4L3inEOnbjET3zWh+/V528aUWl2TBgpDJ8rsB9Djt7wy FNCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VLK4KVn81E10EBS5qXls3g7KXlhM31ZSO449iJbEFmE=; b=bj3w0P3JSMXGvbdnQZq3CsQxHCm1vzPXX1KzY8MqHByrxIvBDZ2xZAYJJHV/BabHAq jKMSAM6gBjaVrBo21ATr1/zbFVqy1mcBhvh3n8U/mJPcUC1b3hXC2I8x3W6TIdMPTTeR fkwdYGfn6zS+pTlMsrlptyBm/6UhRkps6AOa7yWUTQxrwmaCWGNc1N/XGq76x1jEhxSo a+MDzCuSCQH7Ao0zyiCD06xPlPzvFoaLwtkjPP6qs+4J8NPgIecmR/di7BLvyfxhGfqC Y5rcgAc5ZmwOVzswrHvgChcBAZ7zZNVmNW0+tUPIjYGZKkb+BIEwjG2GqSsQs4wyzoja R9hg== X-Gm-Message-State: APjAAAWP03wxHTIkN7KZpMHWuAz9FOYeXOSZYkBj6nMx5WSvL8cBkHi1 5cOmm2P+oaZk4/SrQv1ZcuFhpQ== X-Google-Smtp-Source: APXvYqynM/zVRQwkIiBMi4rma0idAMSJT4BY7/QcZUamqnCs9ud4o/Izo8NNv/5iE2HI3EWIYwZxbg== X-Received: by 2002:a17:902:934b:: with SMTP id g11mr46123420plp.245.1559953213361; Fri, 07 Jun 2019 17:20:13 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n184sm4012463pfn.21.2019.06.07.17.20.12 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 17:20:12 -0700 (PDT) From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Fri, 7 Jun 2019 17:19:56 -0700 Message-Id: <20190608002003.19942-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190608002003.19942-1-stephen@networkplumber.org> References: <20190608002003.19942-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 2/9] kni: use netdev_alloc_skb X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" netdev_alloc_skb is optimized to any alignment or setup of skb->dev that is required. The kernel has chosen to not pad packets on x86 (for many years), because it is faster. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index c86337d099ab..2f2c30cc13ff 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -340,16 +340,13 @@ kni_net_rx_normal(struct kni_dev *kni) data_kva = kva2data_kva(kva); kni->va[i] = pa2va(kni->pa[i], kva); - skb = dev_alloc_skb(len + 2); + skb = netdev_alloc_skb(dev, len + 2); if (!skb) { /* Update statistics */ kni->stats.rx_dropped++; continue; } - /* Align IP on 16B boundary */ - skb_reserve(skb, 2); - if (kva->nb_segs == 1) { memcpy(skb_put(skb, len), data_kva, len); } else { @@ -368,7 +365,6 @@ kni_net_rx_normal(struct kni_dev *kni) } } - skb->dev = dev; skb->protocol = eth_type_trans(skb, dev); skb->ip_summed = CHECKSUM_UNNECESSARY; @@ -512,26 +508,20 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni) data_kva = kva2data_kva(kva); kni->va[i] = pa2va(kni->pa[i], kva); - skb = dev_alloc_skb(len + 2); + skb = netdev_alloc_skb(dev, len + 2); if (skb) { - /* Align IP on 16B boundary */ - skb_reserve(skb, 2); memcpy(skb_put(skb, len), data_kva, len); - skb->dev = dev; skb->ip_summed = CHECKSUM_UNNECESSARY; dev_kfree_skb(skb); } /* Simulate real usage, allocate/copy skb twice */ - skb = dev_alloc_skb(len + 2); + skb = netdev_alloc_skb(dev, len + 2); if (skb == NULL) { kni->stats.rx_dropped++; continue; } - /* Align IP on 16B boundary */ - skb_reserve(skb, 2); - if (kva->nb_segs == 1) { memcpy(skb_put(skb, len), data_kva, len); } else { @@ -550,7 +540,6 @@ kni_net_rx_lo_fifo_skb(struct kni_dev *kni) } } - skb->dev = dev; skb->ip_summed = CHECKSUM_UNNECESSARY; kni->stats.rx_bytes += len;