From patchwork Sat Jun 8 00:19:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 54553 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30A7F1BC91; Sat, 8 Jun 2019 02:20:16 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 0864B1BC20 for ; Sat, 8 Jun 2019 02:20:13 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id f25so1954677pgv.10 for ; Fri, 07 Jun 2019 17:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=nPJGiB1Cy/NhNzdjD3KSHv/xVGMYS2e8Ncjrs6zTvIwgV/oiUpG3UKK1dmv1gZ3WNf ncPFDkX6b+ZPZq0DadKlNt4vFOT7ZvBZMJpnbl8qtR6FILNbm1KpF8AeNR867TlpC87M MFoP0pWnxWMww/dvQIeUGryzQGM2MuFbfmVExMByHgQe+secNQUY5rFA3xxdEpPvzwBl chSrZG3xOy8o+OfrfDBLRZfCbqGNLU1GU97LqDQ6tcOif2h9QOtkedhQmeP/8854GUna 6hbHeqej/SD44jtmzArqCYNteM+4R2KspvX/vcmzKYy6oiObxUWM6EUP0sw51/maMt8f a4mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=FJjrazGcUO6+RvFkQ7fR00xQNs4LPn/zzqDalBpP7seDQJgKCfhYbHG1b+dLk5mHHk SwEf1L7XTu/7g7Um2x8uUtjWVBSTWCvKU2w7jriY3DdInHU+tRhwIYmMJeZXdkhvhI5n gsT5hoysLzkuqFMkLU0urq4nymXRBnQqc0mD69HvRTK3LgeRpYzskUJQEY3wkkHAT00H jBAJZCp6r9CvI9OwhYwcNpcp6ZCUFhs1DBe/7SQ3C2ISPrGD7kWjgd/QAO4b1nod8m1E U2qhEWpmIT3sjD0BIKDA6FXnkqQfVH6Zog4ondy5IIqOm1L4NvPimL9PxS5uClT/hTmN pgXA== X-Gm-Message-State: APjAAAVtqwK9wcZw5bbpTxAPmzCBG6ss7zJElh7gDwQjIXG6HeJich8p 40uu5XjNbLJFm/nxW7ca5h0bNQ== X-Google-Smtp-Source: APXvYqw/hgz0HEwtGthLPjdDt/Jq5VvqmuC0clAwPGkJ1lvr2p6dLc8+szloZ85KuExYsbXRzBKVhw== X-Received: by 2002:a17:90a:9905:: with SMTP id b5mr2567732pjp.70.1559953212244; Fri, 07 Jun 2019 17:20:12 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n184sm4012463pfn.21.2019.06.07.17.20.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 07 Jun 2019 17:20:11 -0700 (PDT) From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Fri, 7 Jun 2019 17:19:55 -0700 Message-Id: <20190608002003.19942-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190608002003.19942-1-stephen@networkplumber.org> References: <20190608002003.19942-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/9] kni: don't need stubs for rx_mode or ioctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index ad8365877cda..c86337d099ab 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev) netif_wake_queue(dev); } -/* - * Ioctl commands - */ -static int -kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) -{ - pr_debug("kni_net_ioctl group:%d cmd:%d\n", - ((struct kni_dev *)netdev_priv(dev))->group_id, cmd); - - return -EOPNOTSUPP; -} - -static void -kni_net_set_rx_mode(struct net_device *dev) -{ -} - static int kni_net_change_mtu(struct net_device *dev, int new_mtu) { @@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = { .ndo_change_rx_flags = kni_net_set_promiscusity, .ndo_start_xmit = kni_net_tx, .ndo_change_mtu = kni_net_change_mtu, - .ndo_do_ioctl = kni_net_ioctl, - .ndo_set_rx_mode = kni_net_set_rx_mode, .ndo_get_stats = kni_net_stats, .ndo_tx_timeout = kni_net_tx_timeout, .ndo_set_mac_address = kni_net_set_mac,