diff mbox series

[v2,3/3] baseband/fpga_lte_fec: meson support

Message ID 1559769660-363320-4-git-send-email-nicolas.chautru@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series baseband/fpga_lte_fec: adding driver for FEC on FPGA |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Chautru, Nicolas June 5, 2019, 9:21 p.m. UTC 
  Adding support for meson build environment
for the new BBDEV PMD driver.

Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
 drivers/baseband/fpga_lte_fec/meson.build | 7 +++++++
 drivers/baseband/meson.build              | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 drivers/baseband/fpga_lte_fec/meson.build

Comments

Bruce Richardson June 6, 2019, 8:25 a.m. UTC | #1 
On Wed, Jun 05, 2019 at 02:21:00PM -0700, Nicolas Chautru wrote:
> Adding support for meson build environment
> for the new BBDEV PMD driver.
> 
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
>  drivers/baseband/fpga_lte_fec/meson.build | 7 +++++++
>  drivers/baseband/meson.build              | 2 +-
>  2 files changed, 8 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/baseband/fpga_lte_fec/meson.build
> 
The meson changes should go in the same patch as the makefile ones.
Ferruh Yigit June 6, 2019, 10:16 a.m. UTC | #2 
On 6/6/2019 9:25 AM, Bruce Richardson wrote:
> On Wed, Jun 05, 2019 at 02:21:00PM -0700, Nicolas Chautru wrote:
>> Adding support for meson build environment
>> for the new BBDEV PMD driver.
>>
>> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
>> ---
>>  drivers/baseband/fpga_lte_fec/meson.build | 7 +++++++
>>  drivers/baseband/meson.build              | 2 +-
>>  2 files changed, 8 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/baseband/fpga_lte_fec/meson.build
>>
> The meson changes should go in the same patch as the makefile ones.
> 

+1, also better to have doc in same patch, so all can merged into single patch.
Chautru, Nicolas June 6, 2019, 4:39 p.m. UTC | #3 
>-----Original Message-----
>From: Yigit, Ferruh 
>Sent: Thursday, June 6, 2019 3:16 AM
>
>On 6/6/2019 9:25 AM, Bruce Richardson wrote:
>> On Wed, Jun 05, 2019 at 02:21:00PM -0700, Nicolas Chautru wrote:
>>> Adding support for meson build environment for the new BBDEV PMD 
>>> driver.
>>>
>>> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
>>> ---
>>>  drivers/baseband/fpga_lte_fec/meson.build | 7 +++++++
>>>  drivers/baseband/meson.build              | 2 +-
>>>  2 files changed, 8 insertions(+), 1 deletion(-)  create mode 100644 
>>> drivers/baseband/fpga_lte_fec/meson.build
>>>
>> The meson changes should go in the same patch as the makefile ones.
>> 
>
>+1, also better to have doc in same patch, so all can merged into single patch.
>

No problem. Pushing in parallel as a new version.
diff mbox series

Patch

diff --git a/drivers/baseband/fpga_lte_fec/meson.build b/drivers/baseband/fpga_lte_fec/meson.build
new file mode 100644
index 0000000..bf44e6b
--- /dev/null
+++ b/drivers/baseband/fpga_lte_fec/meson.build
@@ -0,0 +1,7 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2019 Intel Corporation
+
+deps += ['bbdev', 'bus_vdev', 'ring', 'pci', 'bus_pci']
+name = 'bbdev_fpga_lte_fec'
+allow_experimental_apis = true
+sources = files('fpga_lte_fec.c')
diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
index 52489df..a17d549 100644
--- a/drivers/baseband/meson.build
+++ b/drivers/baseband/meson.build
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
 
-drivers = ['null']
+drivers = ['null', 'fpga_lte_fec']
 
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
 driver_name_fmt = 'rte_pmd_@0@'