diff mbox series

[v2,1/1] app/test-compress-perf: fix reliance on integer endianness

Message ID 20190604124101.28116-2-arturx.trybula@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series app/test-compress-perf: fix reliance on integer endianness |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Artur Trybula June 4, 2019, 12:41 p.m. UTC 
  This patch fixes Coverity Issue 328524:
Reliance on integer endianness (INCOMPATIBLE_CAST) in function
*parse_window_sz*.

Coverity issue: 328524
Fixes: e0b6287c035d ("app/compress-perf: add parser")

Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
 app/test-compress-perf/comp_perf_options_parse.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Shally Verma June 26, 2019, 5:06 p.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Artur Trybula
> Sent: Tuesday, June 4, 2019 6:11 PM
> To: dev@dpdk.org; fiona.trahe@intel.com; adamx.dybkowski@intel.com;
> arturx.trybula@intel.com
> Subject: [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: fix reliance on
> integer endianness
> 
> This patch fixes Coverity Issue 328524:
> Reliance on integer endianness (INCOMPATIBLE_CAST) in function
> *parse_window_sz*.
> 
> Coverity issue: 328524
> Fixes: e0b6287c035d ("app/compress-perf: add parser")
> 
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
Acked-by: Shally Verma <shallyv@marvell.com>

Shally
Akhil Goyal July 1, 2019, 11:37 a.m. UTC | #2 
> >
> > This patch fixes Coverity Issue 328524:
> > Reliance on integer endianness (INCOMPATIBLE_CAST) in function
> > *parse_window_sz*.
> >
> > Coverity issue: 328524
> > Fixes: e0b6287c035d ("app/compress-perf: add parser")
> >
> > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > ---
> Acked-by: Shally Verma <shallyv@marvell.com>
> 
Applied to dpdk-next-crypto

Thanks.
diff mbox series

Patch

diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c
index 2fb6fb48a..a7a8c1f9e 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -364,12 +364,14 @@  parse_max_num_sgl_segs(struct comp_test_data *test_data, const char *arg)
 static int
 parse_window_sz(struct comp_test_data *test_data, const char *arg)
 {
-	int ret = parse_uint16_t((uint16_t *)&test_data->window_sz, arg);
+	uint16_t tmp;
+	int ret = parse_uint16_t(&tmp, arg);
 
 	if (ret) {
 		RTE_LOG(ERR, USER1, "Failed to parse window size\n");
 		return -1;
 	}
+	test_data->window_sz = (int)tmp;
 
 	return 0;
 }