From patchwork Tue Jun 4 09:21:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kanas X-Patchwork-Id: 54347 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E2E21BBEB; Tue, 4 Jun 2019 11:22:58 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 92B341BBEB for ; Tue, 4 Jun 2019 11:22:56 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x549KC56008427; Tue, 4 Jun 2019 02:22:55 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=pCbEOellU+uLApun9Q9aDRZ3WEV8HkPgSsW/ijif+6E=; b=Obr2TxrLPqDn4XpppYBJW8xNMRhCCdIZuApw9xgpBsCtunpcj7WEc/k+kkw87J2CPHke cPBc9p3Rm61z/5ufR9CN/NABjekMYQb9NmVBdknT8qUsc1bqdRljbgipbXMKEmQqxpTN mVn8i6xX48pWov7IUDrx19GcGwhDo4BZJzAzsumzla47+y9p2xgC70/tj7HhQAHqsHt0 EUA2lmV+hJVcCCFBSisccpRku6CaKQoDQUmxQhV1kd+pCXgfE9tr844gPdKL4D9VGsiW C/PE+UhzsVYHu5kLAou1NZljGth1St8zeLLt2TZaOwIyLyGHuDT2O8gyl9wkay4qoUg0 0w== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2swgy393fp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 04 Jun 2019 02:22:55 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 4 Jun 2019 02:22:55 -0700 Received: from maili.marvell.com (10.93.176.43) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Tue, 4 Jun 2019 02:22:54 -0700 Received: from kk-box-0.marvell.com (unknown [10.95.130.16]) by maili.marvell.com (Postfix) with ESMTP id 41DAA3F703F; Tue, 4 Jun 2019 02:22:53 -0700 (PDT) From: To: , Thomas Monjalon , Jasvinder Singh , Cristian Dumitrescu CC: Krzysztof Kanas , Date: Tue, 4 Jun 2019 11:21:27 +0200 Message-ID: <20190604092127.25000-2-kkanas@marvell.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190604092127.25000-1-kkanas@marvell.com> References: <20190604092127.25000-1-kkanas@marvell.com> MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-04_07:, , signatures=0 Subject: [dpdk-dev] [PATCH] mk: fix printing target name when build completes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Krzysztof Kanas The configuration for native-linux-* targets is done using symbolic links, e.g config/defconfig_x86_64-native-linux-gcc which points to config/defconfig_x86_64-native-linuxapp-gcc. When configuring mk will output correct target based on RTE_CONFIG_TEMPLATE. When building mk will use RTE_TARGET variable which is crated out of CONFIG_RTE_EXEC_ENV, and will be different from configuration Fix by setting CONFIG_RTE_EXEC_ENV to record correct value, also adjust makefile tests for CONFIG_RTE_EXEC_ENV. Bugzilla ID: 288 Fixes: b283164694b6 ("mk: print target when reporting build complete") Cc: bruce.richardson@intel.com Cc: jasvinder.singh@intel.com Signed-off-by: Krzysztof Kanas --- config/defconfig_x86_64-native-linuxapp-gcc | 1 + drivers/net/softnic/Makefile | 2 +- mk/rte.sdkbuild.mk | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config/defconfig_x86_64-native-linuxapp-gcc b/config/defconfig_x86_64-native-linuxapp-gcc index db67066a57e3..b1f584427f1d 100644 --- a/config/defconfig_x86_64-native-linuxapp-gcc +++ b/config/defconfig_x86_64-native-linuxapp-gcc @@ -4,6 +4,7 @@ #include "common_linux" CONFIG_RTE_MACHINE="native" +CONFIG_RTE_EXEC_ENV="linux" CONFIG_RTE_ARCH="x86_64" CONFIG_RTE_ARCH_X86_64=y diff --git a/drivers/net/softnic/Makefile b/drivers/net/softnic/Makefile index 64885dd86aeb..29a6af7bb75e 100644 --- a/drivers/net/softnic/Makefile +++ b/drivers/net/softnic/Makefile @@ -45,7 +45,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += conn.c # SYMLINK-y-include += rte_eth_softnic.h -ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") +ifneq ($(patsubst "linux%","linux",$(CONFIG_RTE_EXEC_ENV)),"linux") $(info Softnic PMD can only operate in a linux environment, \ please change the definition of the RTE_TARGET environment variable) all: diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk index b512de1ecdf3..8bb0f52bb343 100644 --- a/mk/rte.sdkbuild.mk +++ b/mk/rte.sdkbuild.mk @@ -27,7 +27,7 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-)) .PHONY: build build: $(ROOTDIRS-y) - @echo "Build complete [$(RTE_TARGET)]" + @echo "Build complete [$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))]" .PHONY: clean clean: $(CLEANDIRS)