diff mbox series

[05/12] eal/pci: Add function pci_ignore_device

Message ID	20190530174819.1160221-6-benjamin.walker@intel.com (mailing list archive)
State	Superseded, archived
Headers	From: Ben Walker <benjamin.walker@intel.com> To: dev@dpdk.org Cc: Ben Walker <benjamin.walker@intel.com> Date: Thu, 30 May 2019 10:48:12 -0700 Message-Id: <20190530174819.1160221-6-benjamin.walker@intel.com> In-Reply-To: <20190530174819.1160221-1-benjamin.walker@intel.com> References: <20190530174819.1160221-1-benjamin.walker@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 05/12] eal/pci: Add function pci_ignore_device Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	[01/12] eal: Make rte_eal_using_phys_addrs work sooner \| [01/12] eal: Make rte_eal_using_phys_addrs work sooner [02/12] eal/pci: Inline several functions into rte_pci_get_iommu_class [03/12] eal/pci: Rework loops in rte_pci_get_iommu_class [04/12] eal/pci: Collapse two loops in rte_pci_get_iommu_class [05/12] eal/pci: Add function pci_ignore_device [06/12] eal/pci: Correctly test whitelist/blacklist in rte_pci_get_iommu_class [07/12] eal/pci: Reverse if check in rte_pci_get_iommu_class [08/12] eal/pci: Collapse loops in rte_pci_get_iommu_class [09/12] eal/pci: Simplify rte_pci_get_iommu class by using a switch [10/12] eal/pci: Finding a device bound to UIO does not force PA [11/12] eal/pci: rte_pci_get_iommu_class handles no drivers [12/12] eal: If bus can't decide PA or VA, try to access PA

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	Compilation issues

Commit Message

Walker, Benjamin May 30, 2019, 5:48 p.m. UTC

  This performs a check for whether the device should be ignored
due to whitelist or blacklist. This check eventually needs
to apply to all of the other checks in rte_pci_get_iommu_class.

Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Change-Id: I8e63e4c2e4199f34561ea1d911e13d6d74a47322
---
 drivers/bus/pci/linux/pci.c | 44 +++++++++++++++++++++----------------
 1 file changed, 25 insertions(+), 19 deletions(-)

diff mbox series

Patch

diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index b7a66d717..f269b6a64 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -560,6 +560,29 @@  pci_one_device_iommu_support_va(__rte_unused struct rte_pci_device *dev)
 }
 #endif
 
+static bool
+pci_ignore_device(struct rte_pci_device *dev)
+{
+	struct rte_devargs *devargs;
+
+	devargs = dev->device.devargs;
+
+	switch (rte_pci_bus.bus.conf.scan_mode) {
+	case RTE_BUS_SCAN_WHITELIST:
+		if (devargs && devargs->policy == RTE_DEV_WHITELISTED)
+			return false;
+		break;
+	case RTE_BUS_SCAN_UNDEFINED:
+	case RTE_BUS_SCAN_BLACKLIST:
+		if (devargs == NULL ||
+		    devargs->policy != RTE_DEV_BLACKLISTED)
+			return false;
+		break;
+	}
+
+	return true;
+}
+
 /*
  * Get iommu class of PCI devices on the bus.
  */
@@ -571,10 +594,9 @@  rte_pci_get_iommu_class(void)
 	bool has_iova_va = false;
 	bool is_bound_uio = false;
 	bool iommu_no_va = false;
-	bool need_check;
 	struct rte_pci_device *dev = NULL;
 	struct rte_pci_driver *drv = NULL;
-	struct rte_devargs *devargs;
+
 
 	FOREACH_DEVICE_ON_PCIBUS(dev) {
 		if (dev->kdrv == RTE_KDRV_UNKNOWN ||
@@ -612,23 +634,7 @@  rte_pci_get_iommu_class(void)
 	}
 
 	FOREACH_DEVICE_ON_PCIBUS(dev) {
-		devargs = dev->device.devargs;
-
-		need_check = false;
-		switch (rte_pci_bus.bus.conf.scan_mode) {
-		case RTE_BUS_SCAN_WHITELIST:
-			if (devargs && devargs->policy == RTE_DEV_WHITELISTED)
-				need_check = true;
-			break;
-		case RTE_BUS_SCAN_UNDEFINED:
-		case RTE_BUS_SCAN_BLACKLIST:
-			if (devargs == NULL ||
-			    devargs->policy != RTE_DEV_BLACKLISTED)
-				need_check = true;
-			break;
-		}
-
-		if (!need_check)
+		if (pci_ignore_device(dev))
 			continue;
 
 		if (dev->kdrv == RTE_KDRV_IGB_UIO ||