diff mbox series

[05/25] net/virtio: use new memory locking API

Message ID	5a7a9dec12c87201e47b98917d32cc5e89b0a3b2.1559147228.git.anatoly.burakov@intel.com (mailing list archive)
State	Superseded, archived
Headers	From: Anatoly Burakov <anatoly.burakov@intel.com> To: dev@dpdk.org Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>, stephen@networkplumber.org, thomas@monjalon.net, david.marchand@redhat.com Date: Wed, 29 May 2019 17:30:51 +0100 Message-Id: <5a7a9dec12c87201e47b98917d32cc5e89b0a3b2.1559147228.git.anatoly.burakov@intel.com> In-Reply-To: <cover.1559147228.git.anatoly.burakov@intel.com> References: <cover.1559147228.git.anatoly.burakov@intel.com> In-Reply-To: <cover.1559147228.git.anatoly.burakov@intel.com> References: <cover.1559147228.git.anatoly.burakov@intel.com> Subject: [dpdk-dev] [PATCH 05/25] net/virtio: use new memory locking API Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Make shared memory config non-public \| [00/25] Make shared memory config non-public [01/25] eal: add API to lock/unlock memory hotplug [02/25] bus/fslmc: use new memory locking API [03/25] net/mlx4: use new memory locking API [04/25] net/mlx5: use new memory locking API [05/25] net/virtio: use new memory locking API [06/25] mem: use new memory locking API [07/25] malloc: use new memory locking API [08/25] vfio: use new memory locking API [09/25] eal: add EAL tailq list lock/unlock API [10/25] acl: use new tailq locking API [11/25] distributor: use new tailq locking API [12/25] efd: use new tailq locking API [13/25] eventdev: use new tailq locking API [14/25] hash: use new tailq locking API [15/25] lpm: use new tailq locking API [16/25] member: use new tailq locking API [17/25] mempool: use new tailq locking API [18/25] reorder: use new tailq locking API [19/25] ring: use new tailq locking API [20/25] stack: use new tailq locking API [21/25] eal: add new API to lock/unlock mempool list [22/25] mempool: use new mempool list locking API [23/25] eal: remove unused macros [24/25] net/ena: fix direct access to shared memory config [25/25] eal: hide shared memory config

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	fail	Compilation issues

Commit Message

Anatoly Burakov May 29, 2019, 4:30 p.m. UTC

  Replace usages of direct access to shared memory config with
calls to the new API.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Tiwei Bie May 30, 2019, 6:39 a.m. UTC | #1

[PATCH 05/25] net/virtio: use new memory locking API

A minor nit: net/virtio -> net/virtio-user

For the rest,
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

On Wed, May 29, 2019 at 05:30:51PM +0100, Anatoly Burakov wrote:
> Replace usages of direct access to shared memory config with
> calls to the new API.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
[...]

diff mbox series

Patch

diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
index e743695e4..41ff19267 100644
--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
@@ -125,7 +125,6 @@  is_vhost_user_by_type(const char *path)
 int
 virtio_user_start_device(struct virtio_user_dev *dev)
 {
-	struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
 	uint64_t features;
 	int ret;
 
@@ -142,7 +141,7 @@  virtio_user_start_device(struct virtio_user_dev *dev)
 	 * replaced when we get proper supports from the
 	 * memory subsystem in the future.
 	 */
-	rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
+	rte_eal_mcfg_mem_read_lock();
 	pthread_mutex_lock(&dev->mutex);
 
 	if (is_vhost_user_by_type(dev->path) && dev->vhostfd < 0)
@@ -180,12 +179,12 @@  virtio_user_start_device(struct virtio_user_dev *dev)
 
 	dev->started = true;
 	pthread_mutex_unlock(&dev->mutex);
-	rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
+	rte_eal_mcfg_mem_read_unlock();
 
 	return 0;
 error:
 	pthread_mutex_unlock(&dev->mutex);
-	rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
+	rte_eal_mcfg_mem_read_unlock();
 	/* TODO: free resource here or caller to check */
 	return -1;
 }