diff mbox series

[01/25] eal: add API to lock/unlock memory hotplug

Message ID	6473125811ac8ed499079652b7f3c32907155fc9.1559147228.git.anatoly.burakov@intel.com (mailing list archive)
State	Superseded, archived
Headers	From: Anatoly Burakov <anatoly.burakov@intel.com> To: dev@dpdk.org Cc: stephen@networkplumber.org, thomas@monjalon.net, david.marchand@redhat.com Date: Wed, 29 May 2019 17:30:47 +0100 Message-Id: <6473125811ac8ed499079652b7f3c32907155fc9.1559147228.git.anatoly.burakov@intel.com> In-Reply-To: <cover.1559147228.git.anatoly.burakov@intel.com> References: <cover.1559147228.git.anatoly.burakov@intel.com> In-Reply-To: <cover.1559147228.git.anatoly.burakov@intel.com> References: <cover.1559147228.git.anatoly.burakov@intel.com> Subject: [dpdk-dev] [PATCH 01/25] eal: add API to lock/unlock memory hotplug Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Make shared memory config non-public \| [00/25] Make shared memory config non-public [01/25] eal: add API to lock/unlock memory hotplug [02/25] bus/fslmc: use new memory locking API [03/25] net/mlx4: use new memory locking API [04/25] net/mlx5: use new memory locking API [05/25] net/virtio: use new memory locking API [06/25] mem: use new memory locking API [07/25] malloc: use new memory locking API [08/25] vfio: use new memory locking API [09/25] eal: add EAL tailq list lock/unlock API [10/25] acl: use new tailq locking API [11/25] distributor: use new tailq locking API [12/25] efd: use new tailq locking API [13/25] eventdev: use new tailq locking API [14/25] hash: use new tailq locking API [15/25] lpm: use new tailq locking API [16/25] member: use new tailq locking API [17/25] mempool: use new tailq locking API [18/25] reorder: use new tailq locking API [19/25] ring: use new tailq locking API [20/25] stack: use new tailq locking API [21/25] eal: add new API to lock/unlock mempool list [22/25] mempool: use new mempool list locking API [23/25] eal: remove unused macros [24/25] net/ena: fix direct access to shared memory config [25/25] eal: hide shared memory config

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues
ci/mellanox-Performance-Testing	success	Performance Testing PASS
ci/intel-Performance-Testing	success	Performance Testing PASS
ci/Intel-compilation	fail	Compilation issues

Commit Message

Burakov, Anatoly May 29, 2019, 4:30 p.m. UTC

  Currently, the memory hotplug is locked automatically by all
memory-related _walk() functions, but sometimes locking the
memory subsystem outside of them is needed. There is no
public API to do that, so it creates a dependency on shared
memory config to be public. Fix this by introducing a new
API to lock/unlock the memory hotplug subsystem.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 lib/librte_eal/common/eal_common_memory.c     | 28 +++++++++++++++++++
 .../common/include/rte_eal_memconfig.h        | 24 ++++++++++++++++
 lib/librte_eal/rte_eal_version.map            | 10 +++++++
 3 files changed, 62 insertions(+)

Comments

Stephen Hemminger May 29, 2019, 4:41 p.m. UTC | #1

On Wed, 29 May 2019 17:30:47 +0100
Anatoly Burakov <anatoly.burakov@intel.com> wrote:

> +rte_eal_mcfg_mem_read_lock(void)
> +{
> +	struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
> +	rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
> +}
> +

We should also make eal configuration private but that is another battle.

diff mbox series

Patch

diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
index 5ae8d0124..3baa2f23a 100644
--- a/lib/librte_eal/common/eal_common_memory.c
+++ b/lib/librte_eal/common/eal_common_memory.c
@@ -682,6 +682,34 @@  rte_memseg_list_walk(rte_memseg_list_walk_t func, void *arg)
 	return ret;
 }
 
+void
+rte_eal_mcfg_mem_read_lock(void)
+{
+	struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
+	rte_rwlock_read_lock(&mcfg->memory_hotplug_lock);
+}
+
+void
+rte_eal_mcfg_mem_read_unlock(void)
+{
+	struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
+	rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
+}
+
+void
+rte_eal_mcfg_mem_write_lock(void)
+{
+	struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
+	rte_rwlock_write_lock(&mcfg->memory_hotplug_lock);
+}
+
+void
+rte_eal_mcfg_mem_write_unlock(void)
+{
+	struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;
+	rte_rwlock_write_unlock(&mcfg->memory_hotplug_lock);
+}
+
 int __rte_experimental
 rte_memseg_get_fd_thread_unsafe(const struct rte_memseg *ms)
 {
diff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h b/lib/librte_eal/common/include/rte_eal_memconfig.h
index 84aabe36c..ef7d4f81a 100644
--- a/lib/librte_eal/common/include/rte_eal_memconfig.h
+++ b/lib/librte_eal/common/include/rte_eal_memconfig.h
@@ -100,6 +100,30 @@  rte_eal_mcfg_wait_complete(struct rte_mem_config* mcfg)
 		rte_pause();
 }
 
+/**
+ * Lock the internal EAL shared memory configuration for shared access.
+ */
+void
+rte_eal_mcfg_mem_read_lock(void);
+
+/**
+ * Unlock the internal EAL shared memory configuration for shared access.
+ */
+void
+rte_eal_mcfg_mem_read_unlock(void);
+
+/**
+ * Lock the internal EAL shared memory configuration for exclusive access.
+ */
+void
+rte_eal_mcfg_mem_write_lock(void);
+
+/**
+ * Unlock the internal EAL shared memory configuration for exclusive access.
+ */
+void
+rte_eal_mcfg_mem_write_unlock(void);
+
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index 245493461..690176fbf 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -287,6 +287,16 @@  DPDK_19.05 {
 
 } DPDK_18.11;
 
+DPDK_19.08 {
+	global:
+
+	rte_eal_mcfg_mem_read_lock;
+	rte_eal_mcfg_mem_read_unlock;
+	rte_eal_mcfg_mem_write_lock;
+	rte_eal_mcfg_mem_write_unlock;
+
+} DPDK_19.05;
+
 EXPERIMENTAL {
 	global: