diff mbox series

devtools: pass custom options to checkpatch

Message ID 20190523074549.29376-1-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series devtools: pass custom options to checkpatch |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Olivier Matz May 23, 2019, 7:45 a.m. UTC 
  Add the ability to pass custom options to checkpatch script. An example
of use is to change the output format so it can run in emacs compilation
mode:

  DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
    DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
    /path/to/dpdk.org/devtools/checkpatches.sh

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 devtools/checkpatches.sh | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon May 23, 2019, 11:50 a.m. UTC | #1 
23/05/2019 09:45, Olivier Matz:
> Add the ability to pass custom options to checkpatch script. An example
> of use is to change the output format so it can run in emacs compilation
> mode:
> 
>   DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
>     DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
>     /path/to/dpdk.org/devtools/checkpatches.sh
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Except the usage example being with emacs,
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Bruce Richardson May 23, 2019, 1:18 p.m. UTC | #2 
On Thu, May 23, 2019 at 01:50:41PM +0200, Thomas Monjalon wrote:
> 23/05/2019 09:45, Olivier Matz:
> > Add the ability to pass custom options to checkpatch script. An example
> > of use is to change the output format so it can run in emacs compilation
> > mode:
> > 
> >   DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
> >     DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
> >     /path/to/dpdk.org/devtools/checkpatches.sh
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Except the usage example being with emacs,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Yes, it should be for Windows Notepad instead. :-)
Ferruh Yigit May 24, 2019, 1:45 p.m. UTC | #3 
On 5/23/2019 8:45 AM, Olivier Matz wrote:
> Add the ability to pass custom options to checkpatch script. An example
> of use is to change the output format so it can run in emacs compilation
> mode:
> 
>   DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
>     DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
>     /path/to/dpdk.org/devtools/checkpatches.sh
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit May 24, 2019, 2:04 p.m. UTC | #4 
On 5/23/2019 8:45 AM, Olivier Matz wrote:
> Add the ability to pass custom options to checkpatch script. An example
> of use is to change the output format so it can run in emacs compilation
> mode:
> 
>   DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
>     DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
>     /path/to/dpdk.org/devtools/checkpatches.sh
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon July 4, 2019, 8:44 p.m. UTC | #5 
24/05/2019 15:45, Ferruh Yigit:
> On 5/23/2019 8:45 AM, Olivier Matz wrote:
> > Add the ability to pass custom options to checkpatch script. An example
> > of use is to change the output format so it can run in emacs compilation
> > mode:
> > 
> >   DPDK_CHECKPATCH_PATH=/path/to/linux/scripts/checkpatch.pl \
> >     DPDK_CHECKPATCH_OPTIONS='--emacs --showfile --no-color' \
> >     /path/to/dpdk.org/devtools/checkpatches.sh
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 6a01b39c8..bd0a93178 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -6,6 +6,7 @@ 
 # - DPDK_CHECKPATCH_PATH
 # - DPDK_CHECKPATCH_CODESPELL
 # - DPDK_CHECKPATCH_LINE_LENGTH
+# - DPDK_CHECKPATCH_OPTIONS
 . $(dirname $(readlink -e $0))/load-devel-config
 
 VALIDATE_NEW_API=$(dirname $(readlink -e $0))/check-symbol-change.sh
@@ -33,6 +34,7 @@  PREFER_KERNEL_TYPES,BIT_MACRO,CONST_STRUCT,\
 SPLIT_STRING,LONG_LINE_STRING,\
 LINE_SPACING,PARENTHESIS_ALIGNMENT,NETWORKING_BLOCK_COMMENT_STYLE,\
 NEW_TYPEDEFS,COMPARISON_TO_NULL"
+options="$options $DPDK_CHECKPATCH_OPTIONS"
 
 clean_tmp_files() {
 	if echo $tmpinput | grep -q '^checkpatches\.' ; then