examples/vhost_crypto: fix unchecked return value

Message ID 20190515162548.71498-1-roy.fan.zhang@intel.com
State Accepted, archived
Delegated to: Maxime Coquelin
Headers show
Series
  • examples/vhost_crypto: fix unchecked return value
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Zhang, Roy Fan May 15, 2019, 4:25 p.m.
This patch tries to fix the coverity issue of unchecked
return value. Since the function that causes the problem
is unused, it is removed completely.

Coverity issue: 336816
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: stable@dpdk.org

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 examples/vhost_crypto/main.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Jens Freimann May 16, 2019, 8:07 a.m. | #1
On Wed, May 15, 2019 at 05:25:48PM +0100, Fan Zhang wrote:
>This patch tries to fix the coverity issue of unchecked
>return value. Since the function that causes the problem
>is unused, it is removed completely.
>
>Coverity issue: 336816
>Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
>Cc: stable@dpdk.org
>
>Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
>---
> examples/vhost_crypto/main.c | 6 ------
> 1 file changed, 6 deletions(-)
>

It really is unused.

Reviewed-by: Jens Freimann <jfreimann@redhat.com>
Zhang, Roy Fan June 17, 2019, 9:09 a.m. | #2
Hi Jens,

You are right. Sorry the code wasn't cleaned up properly in the first place.
Do you want me to send a v2 with new title?

Regards,
Fan

> -----Original Message-----
> From: Jens Freimann [mailto:jfreimann@redhat.com]
> Sent: Thursday, May 16, 2019 9:07 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked
> return value
> 
> On Wed, May 15, 2019 at 05:25:48PM +0100, Fan Zhang wrote:
> >This patch tries to fix the coverity issue of unchecked return value.
> >Since the function that causes the problem is unused, it is removed
> >completely.
> >
> >Coverity issue: 336816
> >Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> >---
> > examples/vhost_crypto/main.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> 
> It really is unused.
> 
> Reviewed-by: Jens Freimann <jfreimann@redhat.com>
>
Kovacevic, Marko June 17, 2019, 9:26 a.m. | #3
> Subject: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return
> value
> 
> This patch tries to fix the coverity issue of unchecked return value. Since the
> function that causes the problem is unused, it is removed completely.
> 
> Coverity issue: 336816
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/vhost_crypto/main.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index ac7118e7e..cfb9dfda2 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -354,12 +354,6 @@ static const struct vhost_device_ops
> virtio_crypto_device_ops = {
>  	.destroy_device = destroy_device,
>  };
> 
> -__attribute__((unused))
> -static void clrscr(void)
> -{
> -	system("@cls||clear");
> -}
> -
>  static int
>  vhost_crypto_worker(void *arg)
>  {

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
Jens Freimann June 19, 2019, 11:56 a.m. | #4
On Mon, Jun 17, 2019 at 09:09:59AM +0000, Zhang, Roy Fan wrote:
>Hi Jens,
>
>You are right. Sorry the code wasn't cleaned up properly in the first place.
>Do you want me to send a v2 with new title?

No it's fine for me :)

regards,
Jens
Maxime Coquelin June 20, 2019, 9:43 a.m. | #5
On 5/15/19 6:25 PM, Fan Zhang wrote:
> This patch tries to fix the coverity issue of unchecked
> return value. Since the function that causes the problem
> is unused, it is removed completely.
> 
> Coverity issue: 336816
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   examples/vhost_crypto/main.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index ac7118e7e..cfb9dfda2 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -354,12 +354,6 @@ static const struct vhost_device_ops virtio_crypto_device_ops = {
>   	.destroy_device = destroy_device,
>   };
>   
> -__attribute__((unused))
> -static void clrscr(void)
> -{
> -	system("@cls||clear");
> -}
> -
>   static int
>   vhost_crypto_worker(void *arg)
>   {
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I'll change the title to:
examples/vhost_crypto: remove unused function
Maxime Coquelin June 20, 2019, 9:59 a.m. | #6
On 5/15/19 6:25 PM, Fan Zhang wrote:
> This patch tries to fix the coverity issue of unchecked
> return value. Since the function that causes the problem
> is unused, it is removed completely.
> 
> Coverity issue: 336816
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   examples/vhost_crypto/main.c | 6 ------
>   1 file changed, 6 deletions(-)
> 

Applied to dpdk-next-virtio/master.

Thanks,
Maxime
Zhang, Roy Fan June 24, 2019, 12:25 p.m. | #7
Thanks Maxime.

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Thursday, June 20, 2019 10:44 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [PATCH] examples/vhost_crypto: fix unchecked return value
> 
> 
> 
> On 5/15/19 6:25 PM, Fan Zhang wrote:
> > This patch tries to fix the coverity issue of unchecked return value.
> > Since the function that causes the problem is unused, it is removed
> > completely.
> >
> > Coverity issue: 336816
> > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> >   examples/vhost_crypto/main.c | 6 ------
> >   1 file changed, 6 deletions(-)
> >
> > diff --git a/examples/vhost_crypto/main.c
> > b/examples/vhost_crypto/main.c index ac7118e7e..cfb9dfda2 100644
> > --- a/examples/vhost_crypto/main.c
> > +++ b/examples/vhost_crypto/main.c
> > @@ -354,12 +354,6 @@ static const struct vhost_device_ops
> virtio_crypto_device_ops = {
> >   	.destroy_device = destroy_device,
> >   };
> >
> > -__attribute__((unused))
> > -static void clrscr(void)
> > -{
> > -	system("@cls||clear");
> > -}
> > -
> >   static int
> >   vhost_crypto_worker(void *arg)
> >   {
> >
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> I'll change the title to:
> examples/vhost_crypto: remove unused function

Patch

diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
index ac7118e7e..cfb9dfda2 100644
--- a/examples/vhost_crypto/main.c
+++ b/examples/vhost_crypto/main.c
@@ -354,12 +354,6 @@  static const struct vhost_device_ops virtio_crypto_device_ops = {
 	.destroy_device = destroy_device,
 };
 
-__attribute__((unused))
-static void clrscr(void)
-{
-	system("@cls||clear");
-}
-
 static int
 vhost_crypto_worker(void *arg)
 {