From patchwork Mon Apr 29 08:20:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 53140 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 576E61B3D7; Mon, 29 Apr 2019 10:20:48 +0200 (CEST) Received: from NAM04-BN3-obe.outbound.protection.outlook.com (mail-eopbgr680045.outbound.protection.outlook.com [40.107.68.45]) by dpdk.org (Postfix) with ESMTP id 4C6431B277 for ; Mon, 29 Apr 2019 10:20:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxoh6buLrFM6JkLVmWccFqvs1mAl54fmeZvafTZobVs=; b=JZ3i9AUryAj8Nm+iHMjRYv3Qh2JVfpEhSYmIxiKT3OrwyOSSX4WYmLuQe9eTSRqzRLGYa42IbiXO2us1XL8wK6YqoDRG+TVZ18mp9XQx7Wlt4GTYRTOYBVjkqcMM8hulzMM7cL45iJo0mVGbqpXIhMO0BPgtL1MVlVnaYC04UK8= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB2841.namprd11.prod.outlook.com (20.176.100.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1835.13; Mon, 29 Apr 2019 08:20:27 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::f035:2c20:5a61:7653]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::f035:2c20:5a61:7653%3]) with mapi id 15.20.1835.010; Mon, 29 Apr 2019 08:20:27 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 10/11] net/atlantic: typo on args check Thread-Index: AQHU/mRmh/cyHVtct0iGGc7VFhx/Kw== Date: Mon, 29 Apr 2019 08:20:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0016.EURP190.PROD.OUTLOOK.COM (2603:10a6:3:bc::26) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b0c70c6d-70a0-4cd4-5359-08d6cc7b88c2 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020); SRVR:DM6PR11MB2841; x-ms-traffictypediagnostic: DM6PR11MB2841: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:843; x-forefront-prvs: 0022134A87 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(396003)(136003)(39840400004)(346002)(199004)(189003)(44832011)(99286004)(186003)(118296001)(478600001)(71200400001)(53936002)(6506007)(71190400001)(446003)(5660300002)(2351001)(14454004)(14444005)(486006)(66556008)(73956011)(66946007)(64756008)(66476007)(66446008)(386003)(52116002)(316002)(11346002)(2616005)(7736002)(476003)(4744005)(72206003)(54906003)(305945005)(107886003)(81166006)(1730700003)(2501003)(36756003)(76176011)(81156014)(6486002)(3846002)(66066001)(102836004)(6916009)(97736004)(8936002)(86362001)(6116002)(6436002)(26005)(256004)(8676002)(50226002)(2906002)(25786009)(5640700003)(6512007)(68736007)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2841; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YKDKoHkfMKu1QDR6CBTekWIJ2Qh/LFvLpObBM7tTAxz13LVbwZ7CdEPTagy/qhndZKTeXI6LmqlYW8j4um3sow54I67UK09uSfQzxYXj6F1T3NSVMpNnUIF0SOHr5PeCjpYdjJQr3tvqGycaKuYRvUEj85zcE2OVNbtsH2KafTWxgAZqK1bYZTyUO2FuPI2HKHkGM6O7E+VRxi68kz7kZAdxPLmHHS/xXOwMFBkVRyYhty766Hr5Su1DpA4ti5lSL2IN7EXmxzQe1lNNf1Mb8JotmeBPq0SRnygYNWEvauVV4rtA8xWPJVdkwSIMPAAc6rkMk89saG+OOUH/AVrg0jOvuz0cizjKfvH2pVNLIxXT+T4Jy+7yTI7/MmV3pdJViCC5S8nRIYMrhltBLj8zR88k69Us+Mg/HeoALtBMMTE= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0c70c6d-70a0-4cd4-5359-08d6cc7b88c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2019 08:20:27.1387 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2841 Subject: [dpdk-dev] [PATCH 10/11] net/atlantic: typo on args check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found by coverity scan, two pointer args should be not zero checked Coverity issue: 337929 Fixes: 2f40244b39ba ("net/atlantic: implement MACsec firmware interface") Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c index 0d24aa99bda0..5927d90f1813 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c @@ -671,7 +671,7 @@ static int aq_fw2x_send_macsec_request(struct aq_hw_s *self, int err = 0; u32 mpi_opts = 0; - if (!response || !response) + if (!req || !response) return 0; if ((self->caps_lo & BIT(CAPS_LO_MACSEC)) == 0)