diff mbox series

doc: add deprecation notice for sched changes

Message ID 20190424123717.123541-1-jasvinder.singh@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series doc: add deprecation notice for sched changes |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Jasvinder Singh April 24, 2019, 12:37 p.m. UTC 
  Add deprecation note for making changes in data structures, APIs
and macros in order to have more traffic classes, flexible
mapping of pipe queues to traffic classes, subport level
configuration of pipes and queues, etc. These changes are aligned
to improvements suggested in the RFC-
https://mails.dpdk.org/archives/dev/2018-November/120035.html

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Mohammad Abdul Awal April 29, 2019, 10:31 a.m. UTC | #1 
On 24/04/2019 13:37, Jasvinder Singh wrote:
> Add deprecation note for making changes in data structures, APIs
> and macros in order to have more traffic classes, flexible
> mapping of pipe queues to traffic classes, subport level
> configuration of pipes and queues, etc. These changes are aligned
> to improvements suggested in the RFC-
> https://mails.dpdk.org/archives/dev/2018-November/120035.html
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index b47c8c254..051ab5c2a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -79,6 +79,12 @@ Deprecation Notices
>   
>     The field would be added in v19.08.
>   
> +* sched: To allow more traffic classes, flexible mapping of pipe queues to
> +  traffic classes, and subport level configuration of pipes and queues
> +  changes will be made to macros, data structures and API functions defined
> +  in "rte_sched.h". These changes are aligned to improvements suggested in the
> +  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> +
>   * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
>     structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
>     ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.

Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Pattan, Reshma April 30, 2019, 3:18 p.m. UTC | #2 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh
> Sent: Wednesday, April 24, 2019 1:37 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
> 
> Add deprecation note for making changes in data structures, APIs and macros in
> order to have more traffic classes, flexible mapping of pipe queues to traffic
> classes, subport level configuration of pipes and queues, etc. These changes are
> aligned to improvements suggested in the RFC-
> https://mails.dpdk.org/archives/dev/2018-November/120035.html
> 
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Acked-by : Reshma Pattan <reshma.pattan@intel.com>
Thomas Monjalon May 13, 2019, 1:56 p.m. UTC | #3 
29/04/2019 12:31, Mohammad Abdul Awal:
> On 24/04/2019 13:37, Jasvinder Singh wrote:
> > Add deprecation note for making changes in data structures, APIs
> > and macros in order to have more traffic classes, flexible
> > mapping of pipe queues to traffic classes, subport level
> > configuration of pipes and queues, etc. These changes are aligned
> > to improvements suggested in the RFC-
> > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> >
> > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > ---
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* sched: To allow more traffic classes, flexible mapping of pipe queues to
> > +  traffic classes, and subport level configuration of pipes and queues
> > +  changes will be made to macros, data structures and API functions defined
> > +  in "rte_sched.h". These changes are aligned to improvements suggested in the
> > +  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.

> 
> Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Acked-by : Reshma Pattan <reshma.pattan@intel.com>

There are only 2 acks for this change.
Any other opinion? yes or no?
Jasvinder Singh May 13, 2019, 1:59 p.m. UTC | #4 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Monday, May 13, 2019 2:56 PM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul <mohammad.abdul.awal@intel.com>; Singh,
> Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> jerin.jacob@caviumnetworks.com; hemant.agrawal@nxp.com;
> stephen@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH] doc: add deprecation notice for sched changes
> 
> 29/04/2019 12:31, Mohammad Abdul Awal:
> > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > Add deprecation note for making changes in data structures, APIs and
> > > macros in order to have more traffic classes, flexible mapping of
> > > pipe queues to traffic classes, subport level configuration of pipes
> > > and queues, etc. These changes are aligned to improvements suggested
> > > in the RFC-
> > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > >
> > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > ---
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > +queues to
> > > +  traffic classes, and subport level configuration of pipes and
> > > +queues
> > > +  changes will be made to macros, data structures and API functions
> > > +defined
> > > +  in "rte_sched.h". These changes are aligned to improvements
> > > +suggested in the
> > > +  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> 
> >
> > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> Acked-by : Reshma Pattan <reshma.pattan@intel.com>
> 
> There are only 2 acks for this change.
> Any other opinion? yes or no?
> 

Cristian has provided his ack as well,  please see below signed-off line.
Thomas Monjalon May 13, 2019, 2:12 p.m. UTC | #5 
13/05/2019 15:59, Singh, Jasvinder:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 29/04/2019 12:31, Mohammad Abdul Awal:
> > > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > > Add deprecation note for making changes in data structures, APIs and
> > > > macros in order to have more traffic classes, flexible mapping of
> > > > pipe queues to traffic classes, subport level configuration of pipes
> > > > and queues, etc. These changes are aligned to improvements suggested
> > > > in the RFC-
> > > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > > >
> > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > ---
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > > +queues to
> > > > +  traffic classes, and subport level configuration of pipes and
> > > > +queues
> > > > +  changes will be made to macros, data structures and API functions
> > > > +defined
> > > > +  in "rte_sched.h". These changes are aligned to improvements
> > > > +suggested in the
> > > > +  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> > 
> > >
> > > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> > Acked-by : Reshma Pattan <reshma.pattan@intel.com>
> > 
> > There are only 2 acks for this change.
> > Any other opinion? yes or no?
> > 
> 
> Cristian has provided his ack as well,  please see below signed-off line.

You are right.
So we get enough acks from the whole team :)

If nobody is against, I will merge it.
Thomas Monjalon May 13, 2019, 9:31 p.m. UTC | #6 
13/05/2019 16:12, Thomas Monjalon:
> 13/05/2019 15:59, Singh, Jasvinder:
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 29/04/2019 12:31, Mohammad Abdul Awal:
> > > > On 24/04/2019 13:37, Jasvinder Singh wrote:
> > > > > Add deprecation note for making changes in data structures, APIs and
> > > > > macros in order to have more traffic classes, flexible mapping of
> > > > > pipe queues to traffic classes, subport level configuration of pipes
> > > > > and queues, etc. These changes are aligned to improvements suggested
> > > > > in the RFC-
> > > > > https://mails.dpdk.org/archives/dev/2018-November/120035.html
> > > > >
> > > > > Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > > > Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > > ---
> > > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > > +* sched: To allow more traffic classes, flexible mapping of pipe
> > > > > +queues to
> > > > > +  traffic classes, and subport level configuration of pipes and
> > > > > +queues
> > > > > +  changes will be made to macros, data structures and API functions
> > > > > +defined
> > > > > +  in "rte_sched.h". These changes are aligned to improvements
> > > > > +suggested in the
> > > > > +  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
> > > 
> > > >
> > > > Acked-by: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
> > > Acked-by : Reshma Pattan <reshma.pattan@intel.com>
> > > 
> > > There are only 2 acks for this change.
> > > Any other opinion? yes or no?
> > > 
> > 
> > Cristian has provided his ack as well,  please see below signed-off line.
> 
> You are right.
> So we get enough acks from the whole team :)
> 
> If nobody is against, I will merge it.

Applied, thanks
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b47c8c254..051ab5c2a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -79,6 +79,12 @@  Deprecation Notices
 
   The field would be added in v19.08.
 
+* sched: To allow more traffic classes, flexible mapping of pipe queues to
+  traffic classes, and subport level configuration of pipes and queues
+  changes will be made to macros, data structures and API functions defined
+  in "rte_sched.h". These changes are aligned to improvements suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2018-November/120035.html.
+
 * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
   structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
   ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.