[2/3] travis: add a distinguisher to the 'extra' builds

Message ID 20190411195229.7841-3-aconole@redhat.com
State Superseded, archived
Headers show
Series
  • travis: enhancements for build (plus a meson fix)
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Aaron Conole April 11, 2019, 7:52 p.m.
This helps in two ways:
  1. When looking at travis page for dpdk, it's a visual distinction

  2. For ccache support, the build IDs include the 'env', so we get unique
     cache data.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 .travis.yml | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

David Marchand April 12, 2019, 7:46 a.m. | #1
On Thu, Apr 11, 2019 at 9:52 PM Aaron Conole <aconole@redhat.com> wrote:

> This helps in two ways:
>   1. When looking at travis page for dpdk, it's a visual distinction
>
>   2. For ccache support, the build IDs include the 'env', so we get unique
>      cache data.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
>  .travis.yml | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 72f8671b1..7b167fa64 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -45,49 +45,49 @@ matrix:
>        apt:
>          packages:
>            - *aarch64_packages
> -  - env: DEF_LIB="static"
> +  - env: DEF_LIB="static" EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared"
> +  - env: DEF_LIB="shared" EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="static"
> +  - env: DEF_LIB="static" EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared"
> +  - env: DEF_LIB="shared" EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
> --
> 2.19.1
>

Reviewed-by: David Marchand <david.marchand@redhat.com>
Luca Boccassi April 12, 2019, 9:17 a.m. | #2
On Thu, 2019-04-11 at 15:52 -0400, Aaron Conole wrote:
> This helps in two ways:
>   1. When looking at travis page for dpdk, it's a visual distinction
> 
>   2. For ccache support, the build IDs include the 'env', so we get
> unique
>      cache data.
> 
> Signed-off-by: Aaron Conole <
> aconole@redhat.com
> >
> ---
>  .travis.yml | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 72f8671b1..7b167fa64 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -45,49 +45,49 @@ matrix:
>        apt:
>          packages:
>            - *aarch64_packages
> -  - env: DEF_LIB="static"
> +  - env: DEF_LIB="static" EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared"
> +  - env: DEF_LIB="shared" EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
> EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
> EXTRA_PACKAGES=1
>      compiler: gcc
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="static"
> +  - env: DEF_LIB="static" EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared"
> +  - env: DEF_LIB="shared" EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
> EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
>          packages:
>            - *extra_packages
> -  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
> +  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
> EXTRA_PACKAGES=1
>      compiler: clang
>      addons:
>        apt:
> 

Acked-by: Luca Boccassi <bluca@debian.org>

Patch

diff --git a/.travis.yml b/.travis.yml
index 72f8671b1..7b167fa64 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -45,49 +45,49 @@  matrix:
       apt:
         packages:
           - *aarch64_packages
-  - env: DEF_LIB="static"
+  - env: DEF_LIB="static" EXTRA_PACKAGES=1
     compiler: gcc
     addons:
       apt:
         packages:
           - *extra_packages
-  - env: DEF_LIB="shared"
+  - env: DEF_LIB="shared" EXTRA_PACKAGES=1
     compiler: gcc
     addons:
       apt:
         packages:
           - *extra_packages
-  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
+  - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
     compiler: gcc
     addons:
       apt:
         packages:
           - *extra_packages
-  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
+  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
     compiler: gcc
     addons:
       apt:
         packages:
           - *extra_packages
-  - env: DEF_LIB="static"
+  - env: DEF_LIB="static" EXTRA_PACKAGES=1
     compiler: clang
     addons:
       apt:
         packages:
           - *extra_packages
-  - env: DEF_LIB="shared"
+  - env: DEF_LIB="shared" EXTRA_PACKAGES=1
     compiler: clang
     addons:
       apt:
         packages:
           - *extra_packages
-  - env: DEF_LIB="static" OPTS="-Denable_kmods=false"
+  - env: DEF_LIB="static" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
     compiler: clang
     addons:
       apt:
         packages:
           - *extra_packages
-  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false"
+  - env: DEF_LIB="shared" OPTS="-Denable_kmods=false" EXTRA_PACKAGES=1
     compiler: clang
     addons:
       apt: