[RFC,1/5] eal: add accessor functions for lcore_config
Checks
Commit Message
The fields of the internal EAL core configuration are currently
laid bare as part of the API. This is not good practice and limits
fixing issues with layout and sizes.
Make new accessor functions for the fields used by current drivers
and examples. Mark the state and return code functions as experimental
since these values might change in the future and probably shouldn't
have been used by non EAL code anyway.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
doc/guides/rel_notes/release_19_05.rst | 7 +++
lib/librte_eal/common/eal_common_lcore.c | 46 ++++++++++++++++++
lib/librte_eal/common/include/rte_lcore.h | 57 +++++++++++++++++------
3 files changed, 96 insertions(+), 14 deletions(-)
Comments
On Wed, Apr 3, 2019 at 7:16 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:
> diff --git a/lib/librte_eal/common/eal_common_lcore.c
> b/lib/librte_eal/common/eal_common_lcore.c
> index 1cbac42286ba..806204d9f73d 100644
> --- a/lib/librte_eal/common/eal_common_lcore.c
> +++ b/lib/librte_eal/common/eal_common_lcore.c
> @@ -16,6 +16,52 @@
> #include "eal_private.h"
> #include "eal_thread.h"
>
> +int rte_lcore_index(int lcore_id)
> +{
> + if (unlikely(lcore_id >= RTE_MAX_LCORE))
> + return -1;
> +
> + if (lcore_id < 0)
> + lcore_id = (int)rte_lcore_id();
> +
> + return lcore_config[lcore_id].core_index;
> +}
>
+
> +int rte_lcore_to_cpu_id(int lcore_id)
> +{
> + if (unlikely(lcore_id >= RTE_MAX_LCORE))
> + return -1;
> +
> + if (lcore_id < 0)
> + lcore_id = (int)rte_lcore_id();
> +
> + return lcore_config[lcore_id].core_id;
> +}
> +
> +rte_cpuset_t rte_lcore_cpuset(unsigned lcore_id)
>
unsigned int
+{
> + return lcore_config[lcore_id].cpuset;
> +}
>
I am a bit skeptical at what dpaa wants to do with this.
Anyway, it can be used when we want to check the current cpuset.
+
> +unsigned
>
unsigned int
+rte_lcore_to_socket_id(unsigned int lcore_id)
> +{
> + return lcore_config[lcore_id].socket_id;
> +}
> +
> +enum rte_lcore_state_t
> +rte_lcore_state(unsigned lcore_id)
>
unsigned int
+{
> + return lcore_config[lcore_id].state;
> +}
>
This is a duplicate for existing rte_eal_get_lcore_state() in
lib/librte_eal/common/eal_common_launch.c.
So either we keep rte_eal_get_lcore_state() or we replace it with this new
one.
+
> +int
> +rte_lcore_return_code(unsigned lcore_id)
>
unsigned int
+{
> + return lcore_config[lcore_id].ret;
> +}
>
+
> +
>
Double blank line.
static int
> socket_id_cmp(const void *a, const void *b)
> {
>
On Fri, 5 Apr 2019 13:01:10 +0200
David Marchand <david.marchand@redhat.com> wrote:
> On Wed, Apr 3, 2019 at 7:16 PM Stephen Hemminger <stephen@networkplumber.org>
> wrote:
>
> > diff --git a/lib/librte_eal/common/eal_common_lcore.c
> > b/lib/librte_eal/common/eal_common_lcore.c
> > index 1cbac42286ba..806204d9f73d 100644
> > --- a/lib/librte_eal/common/eal_common_lcore.c
> > +++ b/lib/librte_eal/common/eal_common_lcore.c
> > @@ -16,6 +16,52 @@
> > #include "eal_private.h"
> > #include "eal_thread.h"
> >
> > +int rte_lcore_index(int lcore_id)
> > +{
> > + if (unlikely(lcore_id >= RTE_MAX_LCORE))
> > + return -1;
> > +
> > + if (lcore_id < 0)
> > + lcore_id = (int)rte_lcore_id();
> > +
> > + return lcore_config[lcore_id].core_index;
> > +}
> >
> +
> > +int rte_lcore_to_cpu_id(int lcore_id)
> > +{
> > + if (unlikely(lcore_id >= RTE_MAX_LCORE))
> > + return -1;
> > +
> > + if (lcore_id < 0)
> > + lcore_id = (int)rte_lcore_id();
> > +
> > + return lcore_config[lcore_id].core_id;
> > +}
> > +
> > +rte_cpuset_t rte_lcore_cpuset(unsigned lcore_id)
> >
>
> unsigned int
>
> +{
> > + return lcore_config[lcore_id].cpuset;
> > +}
> >
>
> I am a bit skeptical at what dpaa wants to do with this.
> Anyway, it can be used when we want to check the current cpuset.
Since cpuset is defined already, don't want to override it with
unsigned.
> +
> > +unsigned
> >
>
> unsigned int
>
> +rte_lcore_to_socket_id(unsigned int lcore_id)
> > +{
> > + return lcore_config[lcore_id].socket_id;
> > +}
> > +
> > +enum rte_lcore_state_t
> > +rte_lcore_state(unsigned lcore_id)
> >
>
> unsigned int
>
> +{
> > + return lcore_config[lcore_id].state;
> > +}
> >
>
> This is a duplicate for existing rte_eal_get_lcore_state() in
> lib/librte_eal/common/eal_common_launch.c.
> So either we keep rte_eal_get_lcore_state() or we replace it with this new
> one.
Good point.
@@ -188,6 +188,13 @@ ABI Changes
alignment for ``rte_crypto_asym_op`` to restore expected ``rte_crypto_op``
layout and alignment.
+* eal: the lcore config structure ``struct lcore_config`` will be made
+ internal to the EAL in a future release. This will allow the structure to
+ change without impacting API or ABI. All accesses to fields of this
+ structure should be done by the corresponding accessor functions.
+ For example, instead of using ``lcore_config[lcore_id].socket_id``
+ the function ``rte_lcore_socket_id(lcore_id)`` should be used instead.
+
Shared Library Versions
-----------------------
@@ -16,6 +16,52 @@
#include "eal_private.h"
#include "eal_thread.h"
+int rte_lcore_index(int lcore_id)
+{
+ if (unlikely(lcore_id >= RTE_MAX_LCORE))
+ return -1;
+
+ if (lcore_id < 0)
+ lcore_id = (int)rte_lcore_id();
+
+ return lcore_config[lcore_id].core_index;
+}
+
+int rte_lcore_to_cpu_id(int lcore_id)
+{
+ if (unlikely(lcore_id >= RTE_MAX_LCORE))
+ return -1;
+
+ if (lcore_id < 0)
+ lcore_id = (int)rte_lcore_id();
+
+ return lcore_config[lcore_id].core_id;
+}
+
+rte_cpuset_t rte_lcore_cpuset(unsigned lcore_id)
+{
+ return lcore_config[lcore_id].cpuset;
+}
+
+unsigned
+rte_lcore_to_socket_id(unsigned int lcore_id)
+{
+ return lcore_config[lcore_id].socket_id;
+}
+
+enum rte_lcore_state_t
+rte_lcore_state(unsigned lcore_id)
+{
+ return lcore_config[lcore_id].state;
+}
+
+int
+rte_lcore_return_code(unsigned lcore_id)
+{
+ return lcore_config[lcore_id].ret;
+}
+
+
static int
socket_id_cmp(const void *a, const void *b)
{
@@ -121,15 +121,7 @@ rte_lcore_count(void)
* @return
* The relative index, or -1 if not enabled.
*/
-static inline int
-rte_lcore_index(int lcore_id)
-{
- if (lcore_id >= RTE_MAX_LCORE)
- return -1;
- if (lcore_id < 0)
- lcore_id = (int)rte_lcore_id();
- return lcore_config[lcore_id].core_index;
-}
+int rte_lcore_index(int lcore_id);
/**
* Return the ID of the physical socket of the logical core we are
@@ -177,11 +169,37 @@ rte_socket_id_by_idx(unsigned int idx);
* @return
* the ID of lcoreid's physical socket
*/
-static inline unsigned
-rte_lcore_to_socket_id(unsigned lcore_id)
-{
- return lcore_config[lcore_id].socket_id;
-}
+unsigned rte_lcore_to_socket_id(unsigned lcore_id);
+
+/**
+ * Return the id of the lcore on a socket starting from zero.
+ *
+ * @param lcore_id
+ * The targeted lcore, or -1 for the current one.
+ * @return
+ * The relative index, or -1 if not enabled.
+ */
+int rte_lcore_to_cpu_id(int lcore_id);
+
+/**
+ * Return the cpuset for a given lcore.
+ * @param lcore_id
+ * the targeted lcore, which MUST be between 0 and RTE_MAX_LCORE-1.
+ * @return
+ * The cpuset of that lcore
+ */
+rte_cpuset_t rte_lcore_cpuset(unsigned lcore_id);
+
+/**
+ * Get the return code from a lcore thread.
+ * @param lcore_id
+ * the targeted lcore, which MUST be between 0 and RTE_MAX_LCORE-1
+ * and finished
+ * @return
+ * the return code from the lcore thread
+ */
+int __rte_experimental
+rte_lcore_return_code(unsigned lcore_id);
/**
* Test if an lcore is enabled.
@@ -201,6 +219,17 @@ rte_lcore_is_enabled(unsigned lcore_id)
return cfg->lcore_role[lcore_id] == ROLE_RTE;
}
+/**
+ * Get the state of an lcore ID.
+ *
+ * @param lcore_id
+ * the targeted lcore, which MUST be between 0 and RTE_MAX_LCORE-1.
+ * @return
+ * the current state of that lcore
+ */
+enum rte_lcore_state_t __rte_experimental
+rte_lcore_state(unsigned lcore_id);
+
/**
* Get the next enabled lcore ID.
*