[v3] app/test/hash: fix sprintf with snprintf

Message ID 1553596043-21363-1-git-send-email-pallantlax.poornima@intel.com
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [v3] app/test/hash: fix sprintf with snprintf
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing fail Performance Testing issues
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Pallantla Poornima March 26, 2019, 10:27 a.m.
sprintf function is not secure as it doesn't check the length of string.
More secure function snprintf is used.

Fixes: 473d1bebce ("hash: allow to store data in hash table")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
---
v3: Rebased.
v2: Addressed review comment to correct the format specifier of 
hastest_key_lens.
---
 app/test/test_hash_perf.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon April 4, 2019, 11:59 p.m. | #1
26/03/2019 11:27, Pallantla Poornima:
> sprintf function is not secure as it doesn't check the length of string.
> More secure function snprintf is used.
> 
> Fixes: 473d1bebce ("hash: allow to store data in hash table")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>

Applied, thanks

Patch

diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c
index 525211180..5648fce02 100644
--- a/app/test/test_hash_perf.c
+++ b/app/test/test_hash_perf.c
@@ -85,9 +85,11 @@  create_table(unsigned int with_data, unsigned int table_index,
 
 	if (with_data)
 		/* Table will store 8-byte data */
-		sprintf(name, "test_hash%d_data", hashtest_key_lens[table_index]);
+		snprintf(name, sizeof(name), "test_hash%u_data",
+				hashtest_key_lens[table_index]);
 	else
-		sprintf(name, "test_hash%d", hashtest_key_lens[table_index]);
+		snprintf(name, sizeof(name), "test_hash%u",
+				hashtest_key_lens[table_index]);
 
 
 	if (with_locks)