vhost/crypto: fix coverity issues

Message ID 20190325143731.6488-1-roy.fan.zhang@intel.com
State Accepted, archived
Delegated to: Maxime Coquelin
Headers show
Series
  • vhost/crypto: fix coverity issues
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Fan Zhang March 25, 2019, 2:37 p.m.
Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")

Coverity Issue: 277214
Coverity Issue: 277220
Coverity Issue: 277233
Coverity Issue: 277236

Cc: stable@dpdk.org

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 lib/librte_vhost/vhost_crypto.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Maxime Coquelin March 27, 2019, 10:18 a.m. | #1
On 3/25/19 3:37 PM, Fan Zhang wrote:
> Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
> 
> Coverity Issue: 277214
> Coverity Issue: 277220
> Coverity Issue: 277233
> Coverity Issue: 277236
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/vhost_crypto.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index 9b4b850e8..0edf12d52 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -1109,7 +1109,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
>   
>   		if (unlikely(copy_data(digest_addr, vc_req, &digest_desc,
>   				chain->para.hash_result_len,
> -				nb_descs, vq_size)) < 0) {
> +				nb_descs, vq_size) < 0)) {
>   			ret = VIRTIO_CRYPTO_BADMSG;
>   			goto error_exit;
>   		}
> @@ -1627,7 +1627,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
>   			op->sym->m_src->data_off = 0;
>   
>   			if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
> -					op, head, desc_idx)) < 0)
> +					op, head, desc_idx) < 0))
>   				break;
>   		}
>   
> 

Good catch from Coverity!

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
Maxime Coquelin March 27, 2019, 11:14 a.m. | #2
On 3/25/19 3:37 PM, Fan Zhang wrote:
> Fixes: cd1e8f03abf0 ("vhost/crypto: fix packet copy in chaining mode")
> 
> Coverity Issue: 277214
> Coverity Issue: 277220
> Coverity Issue: 277233
> Coverity Issue: 277236
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>   lib/librte_vhost/vhost_crypto.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
Applied to dpdk-next-virtio/master.

Thanks,
Maxime

Patch

diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
index 9b4b850e8..0edf12d52 100644
--- a/lib/librte_vhost/vhost_crypto.c
+++ b/lib/librte_vhost/vhost_crypto.c
@@ -1109,7 +1109,7 @@  prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
 
 		if (unlikely(copy_data(digest_addr, vc_req, &digest_desc,
 				chain->para.hash_result_len,
-				nb_descs, vq_size)) < 0) {
+				nb_descs, vq_size) < 0)) {
 			ret = VIRTIO_CRYPTO_BADMSG;
 			goto error_exit;
 		}
@@ -1627,7 +1627,7 @@  rte_vhost_crypto_fetch_requests(int vid, uint32_t qid,
 			op->sym->m_src->data_off = 0;
 
 			if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,
-					op, head, desc_idx)) < 0)
+					op, head, desc_idx) < 0))
 				break;
 		}