From patchwork Mon Mar 25 08:51:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 51610 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 860F43576; Mon, 25 Mar 2019 09:52:06 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4F8953256; Mon, 25 Mar 2019 09:52:03 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7582481DE9; Mon, 25 Mar 2019 08:52:02 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-204-129.brq.redhat.com [10.40.204.129]) by smtp.corp.redhat.com (Postfix) with ESMTP id 255C11001E74; Mon, 25 Mar 2019 08:51:58 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ramirose@gmail.com, arybchenko@solarflare.com, maxime.coquelin@redhat.com, ferruh.yigit@intel.com, stable@dpdk.org Date: Mon, 25 Mar 2019 09:51:43 +0100 Message-Id: <1553503906-1508-2-git-send-email-david.marchand@redhat.com> In-Reply-To: <1553503906-1508-1-git-send-email-david.marchand@redhat.com> References: <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553503906-1508-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 25 Mar 2019 08:52:02 +0000 (UTC) Subject: [dpdk-dev] [PATCH v5 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: iofwd engine RX-packets: 121811360 TX-packets: 121811392 TX-dropped: 0 RX-bursts : 3806605 [100% of 32 pkts] TX-bursts : 3806606 [100% of 32 pkts] csum engine RX-packets: 5467488 TX-packets: 5467520 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 RX-bursts : 170859 [100% of 32 pkts] TX-bursts : 170860 [100% of 32 pkts] After: iofwd engine RX-packets: 259770560 TX-packets: 259770592 TX-dropped: 0 RX-bursts : 8117830 [100% of 32 pkts] TX-bursts : 8117831 [100% of 32 pkts] csum engine RX-packets: 7834016 TX-packets: 7834048 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 RX-bursts : 244813 [100% of 32 pkts] TX-bursts : 244814 [100% of 32 pkts] Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko --- Changelog since v4: - let the csum stats at the same place than before, updated commitlog Changelog since v2: - Cc'd stable --- app/test-pmd/testpmd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 216be47..7715844 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -1468,6 +1468,8 @@ struct extmem_param { "%-14u Rx- bad outer L4 checksum: %-14u\n", fs->rx_bad_ip_csum, fs->rx_bad_l4_csum, fs->rx_bad_outer_l4_csum); + } else { + printf("\n"); } #ifdef RTE_TEST_PMD_RECORD_BURST_STATS