rte_ring: add newline to error message

Message ID 20190321230341.6576-1-stephen@networkplumber.org
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • rte_ring: add newline to error message
Related show

Checks

Context Check Description
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger March 21, 2019, 11:03 p.m.
Log message should end with newline.

Fixes: 4e32101f9b01 ("ring: support freeing")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_ring/rte_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rami Rosen March 22, 2019, 9:49 a.m. | #1
On Fri, Mar 22, 2019 at 1:04 AM Stephen Hemminger <
stephen@networkplumber.org> wrote:

> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>

Reviewed-by: Rami Rosen <ramirose@gmail.com>
Thomas Monjalon March 27, 2019, 11:21 a.m. | #2
22/03/2019 00:03, Stephen Hemminger:
> Log message should end with newline.
> 
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> -		RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
> +		RTE_LOG(ERR, RING,
> +			"Cannot free ring (not created with rte_ring_create()\n");

While at it, could you fix the parens?
I think it would be better to replace the first paren with a comma.

Patch

diff --git a/lib/librte_ring/rte_ring.c b/lib/librte_ring/rte_ring.c
index d215aceccf46..61534b286b53 100644
--- a/lib/librte_ring/rte_ring.c
+++ b/lib/librte_ring/rte_ring.c
@@ -189,7 +189,8 @@  rte_ring_free(struct rte_ring *r)
 	 * therefore, there is no memzone to free.
 	 */
 	if (r->memzone == NULL) {
-		RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
+		RTE_LOG(ERR, RING,
+			"Cannot free ring (not created with rte_ring_create()\n");
 		return;
 	}