[v2] app/test: fix possible overflow using strlcat

Message ID 1552912596-2776-1-git-send-email-tallurix.chaitanya.babu@intel.com
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series
  • [v2] app/test: fix possible overflow using strlcat
Related show

Checks

Context Check Description
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Chaitanya Babu Talluri March 18, 2019, 12:36 p.m.
strcat does not check the destination length and there might be
chances of string overflow so instead of strcat, strlcat is used.

Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
Cc: stable@dpdk.org

Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
---
v2: Updated title.
---
 app/test/test_cryptodev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Akhil Goyal March 22, 2019, 2:31 p.m. | #1
On 3/18/2019 6:06 PM, Chaitanya Babu Talluri wrote:
> strcat does not check the destination length and there might be
> chances of string overflow so instead of strcat, strlcat is used.
>
> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
> ---
> v2: Updated title.
> ---
>   app/test/test_cryptodev.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Akhil Goyal March 22, 2019, 3:07 p.m. | #2
On 3/22/2019 8:01 PM, Akhil Goyal wrote:
>
> On 3/18/2019 6:06 PM, Chaitanya Babu Talluri wrote:
>> strcat does not check the destination length and there might be
>> chances of string overflow so instead of strcat, strlcat is used.
>>
>> Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
>> ---
>> v2: Updated title.
>> ---
>>    app/test/test_cryptodev.c | 3 ++-
>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto

Thanks.

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 32f1893bc..2ff204137 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -15,6 +15,7 @@ 
 #include <rte_crypto.h>
 #include <rte_cryptodev.h>
 #include <rte_cryptodev_pmd.h>
+#include <rte_string_fns.h>
 
 #ifdef RTE_LIBRTE_PMD_CRYPTO_SCHEDULER
 #include <rte_cryptodev_scheduler.h>
@@ -375,7 +376,7 @@  testsuite_setup(void)
 			snprintf(vdev_args, sizeof(vdev_args),
 					"%s%d", temp_str, i);
 			strcpy(temp_str, vdev_args);
-			strcat(temp_str, ";");
+			strlcat(temp_str, ";", sizeof(temp_str));
 			slave_core_count++;
 			socket_id = lcore_config[i].socket_id;
 		}