app/testpmd: fix stdout flush absence after printing stats

Message ID 1552908947-18120-1-git-send-email-arybchenko@solarflare.com
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • app/testpmd: fix stdout flush absence after printing stats
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Andrew Rybchenko March 18, 2019, 11:35 a.m.
From: Igor Romanov <igor.romanov@oktetlabs.ru>

User can specify stats period(n). The statistics should be available
to user every n second. But the print_stats() function does not
force stdout to be flushed, so for instance, a user reading testpmd's
stdout through pipe will not be able to read it untill the stdout
buffer is filled.

Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
Cc: stable@dpdk.org

Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 app/test-pmd/testpmd.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Iremonger, Bernard March 20, 2019, 1:21 p.m. | #1
Hi Andrew,

> -----Original Message-----
> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
> Sent: Monday, March 18, 2019 11:36 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Igor Romanov <igor.romanov@oktetlabs.ru>;
> stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats
> 
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
> 
> User can specify stats period(n). The statistics should be available to user
> every n second. But the print_stats() function does not force stdout to be
> flushed, so for instance, a user reading testpmd's stdout through pipe will
> not be able to read it untill the stdout buffer is filled.
> 
> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
>  app/test-pmd/testpmd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> d9d0c16d4..216be47f9 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3046,6 +3046,8 @@ print_stats(void)
>  	printf("\nPort statistics
> ====================================");
>  	for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
>  		nic_stats_display(fwd_ports_ids[i]);
> +
> +	fflush(stdout);
>  }
> 
>  static void
> --
> 2.17.1

There is a checkpatch warning on the commit messge.
WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?

Otherwise

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
Ferruh Yigit March 20, 2019, 8:13 p.m. | #2
On 3/20/2019 1:21 PM, Iremonger, Bernard wrote:
> Hi Andrew,
> 
>> -----Original Message-----
>> From: Andrew Rybchenko [mailto:arybchenko@solarflare.com]
>> Sent: Monday, March 18, 2019 11:36 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; Igor Romanov <igor.romanov@oktetlabs.ru>;
>> stable@dpdk.org
>> Subject: [PATCH] app/testpmd: fix stdout flush absence after printing stats
>>
>> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>>
>> User can specify stats period(n). The statistics should be available to user
>> every n second. But the print_stats() function does not force stdout to be
>> flushed, so for instance, a user reading testpmd's stdout through pipe will
>> not be able to read it untill the stdout buffer is filled.
>>
>> Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> There is a checkpatch warning on the commit messge.
> WARNING:TYPO_SPELLING: 'untill' may be misspelled - perhaps 'until'?
> 
> Otherwise
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
> 

Applied to dpdk-next-net/master, thanks.

(warning fixed while merging)

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index d9d0c16d4..216be47f9 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3046,6 +3046,8 @@  print_stats(void)
 	printf("\nPort statistics ====================================");
 	for (i = 0; i < cur_fwd_config.nb_fwd_ports; i++)
 		nic_stats_display(fwd_ports_ids[i]);
+
+	fflush(stdout);
 }
 
 static void