[v2,1/2] bus/fslmc: don't log error for other devices

Message ID 20190312171152.28637-2-stephen@networkplumber.org
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • bus/fslmc: logging fixes
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger March 12, 2019, 5:11 p.m.
When fslmc is built as part of a general distribution, the
bus code will log errors when other devices are present.

This could confuse users it is not an error.

Fixes: 50245be05d1a ("bus/fslmc: support device blacklisting")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/bus/fslmc/fslmc_bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hemant Agrawal March 13, 2019, 1:59 p.m. | #1
Thanks

  Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Ilya Maximets March 14, 2019, 2:52 p.m. | #2
On 12.03.2019 20:11, Stephen Hemminger wrote:
> When fslmc is built as part of a general distribution, the
> bus code will log errors when other devices are present.
> 
> This could confuse users it is not an error.
> 
> Fixes: 50245be05d1a ("bus/fslmc: support device blacklisting")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

These error messages are annoying. Thanks for fixing!

Acked-by: Ilya Maximets <i.maximets@samsung.com>

Patch

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 44c0827ced0b..a2525780cd08 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -249,7 +249,7 @@  rte_fslmc_parse(const char *name, void *addr)
 	    strncmp("dpmcp", t_ptr, 5) &&
 	    strncmp("dpdmai", t_ptr, 6) &&
 	    strncmp("dpdmux", t_ptr, 6)) {
-		DPAA2_BUS_ERR("Unknown or unsupported device");
+		DPAA2_BUS_DEBUG("Unknown or unsupported device (%s)", name);
 		goto err_out;
 	}