From patchwork Tue Mar 12 15:24:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 51123 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51E9E4C9F; Tue, 12 Mar 2019 16:24:55 +0100 (CET) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790045.outbound.protection.outlook.com [40.107.79.45]) by dpdk.org (Postfix) with ESMTP id D3B4211A4; Tue, 12 Mar 2019 16:24:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wABkk6GVQI7y28vBO2rYuZ8oKyYJ+NjFDgT7aPKXxmg=; b=goIRs9M9RovtMdi4AeAeYzuul4FCI3EgsG3t0VxNcPTLOO1t1mBAKQsJj9FKu8+7FDjCQH+U9P6vTpVjFxyYqQ5Q5uV7FdB+vzkA9dhjhc/3ssFvoR+AMb26ycW+4znN7QJObh5IVs/D4HskelAMxTtjbFzC6lJPK12krNx1eLE= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB2747.namprd11.prod.outlook.com (20.176.100.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Tue, 12 Mar 2019 15:24:52 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1686.021; Tue, 12 Mar 2019 15:24:52 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh , "stable@dpdk.org" Thread-Topic: [PATCH v3 01/10] net/atlantic: fix negative error codes Thread-Index: AQHU2Oe85lBIfj0Ha0C7ouJhr7ZIZw== Date: Tue, 12 Mar 2019 15:24:52 +0000 Message-ID: <8b5751022a766644ba6abff9be929ffdd73e01cb.1552402263.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR0901CA0050.eurprd09.prod.outlook.com (2603:10a6:3:45::18) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58ff60de-0e0b-4e93-e672-08d6a6fedf28 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB2747; x-ms-traffictypediagnostic: DM6PR11MB2747: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB2747; 23:DNAu95jE7Zk0mlYdv9PA/QwoILV2mR08+MPgQQj?= =?iso-8859-1?q?1My8X6NmlJ3aGlRI4pLr2Wn5F?= =?iso-8859-1?q?N/K0LMfjXLPTKkzGUE5sFJo4Q8a9BTpoGXd63zSvUhv/7ZZkGvv?= =?iso-8859-1?q?0NynwjynYPY5U2jAHetFEYTZFbMCyyUX91qNBppn76ZXC5XwPWW?= =?iso-8859-1?q?LPXHCwmOXZLP2CAdVX+zeqmvjlvpHtY0IN9wKEmG94sMl7AA/wV?= =?iso-8859-1?q?zSX1QhEHup/jOsbm4HjTCwXQc4BmQU4r7N2rFGZWEMnL1AvpY/p?= =?iso-8859-1?q?1u9leeUZqUZ8p8PuCHkDNjKDVM7FzROMyLYC5iJIQ7Em2yCdTbM?= =?iso-8859-1?q?Afwu+98wNgW3Ydlz+Mysr+OtGvBE3lOb7EaxXatnMp5TWyVd7TG?= =?iso-8859-1?q?R6jU5EHRJSe8msRouEh0ypTR7DfCCeLzv8igxfSvHjvZs5MsI3l?= =?iso-8859-1?q?a3WMUDSI/PuV6QFeaS4P4ww2UG+2y3C/bjOz900E4FUTXAZpPFU?= =?iso-8859-1?q?PFdDzvcLebne8bb+Ncj/YgJsynFxCIGzp0X6p1C1AcRC4Fs9tia?= =?iso-8859-1?q?sWviLCUBoN7z6aS2Mmz8MV/rjvIW8Xqw7hYm3jCHL7rGNlidYs/?= =?iso-8859-1?q?fwVjbzJvrImf8ujCcQyiZcCkZ4AmuJlW3qBsGDf4PeFhEvAl/1g?= =?iso-8859-1?q?OtVyO70CMMhTtHAo66L0ajN3qKzFt9Ae9NfNd5/rbnTrZaZplJb?= =?iso-8859-1?q?DP7lZVtPLTA2sxM/Ipetx/RWKuSUBswIOnINQZ2JuFcDqfAiCQ+?= =?iso-8859-1?q?k5DFpbi/a8IKmsSDnHkSWMgqRAtIwnkdhk9Z51LnlBQP5x0EHcW?= =?iso-8859-1?q?9g1z6O71gVD+qQ8RZf1Y95kDsApN1vzBw8L6DbV5dS35c0Q3kcF?= =?iso-8859-1?q?HdmIDZttkOG82JNX/ArD6Lorx95zcWhJNH+pgUNgog77WE+b6iU?= =?iso-8859-1?q?jgNenVUiCPxFXglH9OnwFqk/shRV7zmxX/qHe+bNpcOjA94E5ho?= =?iso-8859-1?q?diU5j6hNztX1bpPk0XzfBdZTNOvXSLJoS8YLy8/LDlpn46e9YM5?= =?iso-8859-1?q?mucjcK6S0mgCTI01S2u6BAF7PwiagF+d7fhUOxcUtweO/ULhITg?= =?iso-8859-1?q?tkRxuXKoYpUd+WF9WIPFTK3oYh/cW8AZN6O/0bxcmMKP7Fcb4xg?= =?iso-8859-1?q?CBpNTYRVlWUJziFxWRVRGJn+Wwec9E7JtEhADofwtonyQ83oNVC?= =?iso-8859-1?q?hZeR9nIgDNE9XHUOyjqMQha9Ce4S3ETht3MRURk+XVFpIhVQ3xp?= =?iso-8859-1?q?0wasISv/5QbAIkMcstABfGVO7heXC+AxQAErG4u18Qc4rzDPmq6?= =?iso-8859-1?q?qvaefYk3ctj4Radk8UAKUyGmz0A6KGvV9FGXqi/MkmweVjKQ8HJ?= =?iso-8859-1?q?sFBYfh8/qWFw9B5Nap+MSCba+29g8gC5ojibpyc4fc0xrHBwl40?= =?iso-8859-1?q?PgBhJPSosNjhELPbC4m8crv19MjUYB2MRV/fISbHA5HfB8Qg=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09749A275C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39850400004)(136003)(366004)(376002)(199004)(189003)(53936002)(2501003)(106356001)(86362001)(81166006)(5660300002)(99286004)(81156014)(6116002)(44832011)(2351001)(105586002)(4326008)(66066001)(2616005)(71200400001)(4744005)(486006)(72206003)(478600001)(446003)(476003)(186003)(118296001)(14454004)(26005)(54906003)(71190400001)(11346002)(386003)(6506007)(305945005)(102836004)(25786009)(7736002)(50226002)(3846002)(256004)(316002)(36756003)(450100002)(6916009)(6486002)(52116002)(1730700003)(8676002)(76176011)(6512007)(97736004)(8936002)(68736007)(6436002)(2906002)(5640700003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2747; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 7eb6CvQ4pxgJsUcMaAONwtPzOBCvDTR3VSKlh+jWy8TUqZ3478g/EUgwG7b0UWCN7v+7p/KC3p+SlCSE7kGXVimVU+IEu/edYR1DhjfIVlSocdhu5rjVB/DiJFsv9/ZwZT0bFy6cOeZueIpQWKorIB84RNiPzzOp6MPllHRshBRqZb5vXcqW5WTQkDzLfcifFAr/jqWq0mvtYio+wT3e1+erDiCzkqIAB0HervkphKZ7FXOM2P5/N/zAlJAFdGfvxS0zGoJ54mwvfC42HardA8KJPGN9fU2iXZfX6VK6pBhavipNfnXXodrmqlirOgflUyK6sGFVqAKAc7QVE/v6s1+iVD5mC0jNJxm5XXP8B5RkkLUkXKH/aepqjFTl0VbPto16zOuR5qNMte0ywWe/IlB2+zBbFF3MCwJtyaQWwKU= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58ff60de-0e0b-4e93-e672-08d6a6fedf28 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2019 15:24:52.0541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2747 Subject: [dpdk-dev] [PATCH v3 01/10] net/atlantic: fix negative error codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These are just convention breakage on rte_errno, no real harm from that. Cc: stable@dpdk.org Signed-off-by: Igor Russkikh Fixes: 2b1472d7150c ("net/atlantic: implement Tx path") --- drivers/net/atlantic/atl_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c index 40c913795c79..aea58c0d5b83 100644 --- a/drivers/net/atlantic/atl_rxtx.c +++ b/drivers/net/atlantic/atl_rxtx.c @@ -812,12 +812,12 @@ atl_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts, ol_flags = m->ol_flags; if (m->nb_segs > AQ_HW_MAX_SEGS_SIZE) { - rte_errno = -EINVAL; + rte_errno = EINVAL; return i; } if (ol_flags & ATL_TX_OFFLOAD_NOTSUP_MASK) { - rte_errno = -ENOTSUP; + rte_errno = ENOTSUP; return i; }