net/i40e: fix time sync for 25G

Message ID 20190311074220.14588-1-qi.z.zhang@intel.com
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series
  • net/i40e: fix time sync for 25G
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Zhang, Qi Z March 11, 2019, 7:42 a.m.
Time sync increment value is not configured for 25G device.

The patch fix this issue by setting the same value as 40G, this
aligned with kernel driver's behaviour.

Fixes: 75d133dd3296 ("net/i40e: enable 25G device")
Cc: stable@dpdk.org

Reported-by: Michael Luo <michael.luo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Luo, Michael March 12, 2019, 1:21 a.m. | #1
Verified the patch on DPDK 18.11.

Best regards, 
Michael

-----Original Message-----
From: Zhang, Qi Z 
Sent: Monday, March 11, 2019 3:42 PM
To: dev@dpdk.org
Cc: Luo, Michael <michael.luo@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
Subject: [PATCH] net/i40e: fix time sync for 25G

Time sync increment value is not configured for 25G device.

The patch fix this issue by setting the same value as 40G, this aligned with kernel driver's behaviour.

Fixes: 75d133dd3296 ("net/i40e: enable 25G device")
Cc: stable@dpdk.org

Reported-by: Michael Luo <michael.luo@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index dca61f03a..8191a6a73 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10830,6 +10830,7 @@ i40e_start_timecounters(struct rte_eth_dev *dev)
 
 	switch (link.link_speed) {
 	case ETH_SPEED_NUM_40G:
+	case ETH_SPEED_NUM_25G:
 		tsync_inc_l = I40E_PTP_40GB_INCVAL & 0xFFFFFFFF;
 		tsync_inc_h = I40E_PTP_40GB_INCVAL >> 32;
 		break;
--
2.13.6
Zhang, Qi Z March 12, 2019, 3:11 a.m. | #2
> -----Original Message-----
> From: Luo, Michael
> Sent: Tuesday, March 12, 2019 9:21 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/i40e: fix time sync for 25G
> 
> Verified the patch on DPDK 18.11.
> 
> Best regards,
> Michael
> 
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Monday, March 11, 2019 3:42 PM
> To: dev@dpdk.org
> Cc: Luo, Michael <michael.luo@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/i40e: fix time sync for 25G
> 
> Time sync increment value is not configured for 25G device.
> 
> The patch fix this issue by setting the same value as 40G, this aligned with kernel
> driver's behaviour.
> 
> Fixes: 75d133dd3296 ("net/i40e: enable 25G device")
> Cc: stable@dpdk.org
> 
> Reported-by: Michael Luo <michael.luo@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index dca61f03a..8191a6a73 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -10830,6 +10830,7 @@  i40e_start_timecounters(struct rte_eth_dev *dev)
 
 	switch (link.link_speed) {
 	case ETH_SPEED_NUM_40G:
+	case ETH_SPEED_NUM_25G:
 		tsync_inc_l = I40E_PTP_40GB_INCVAL & 0xFFFFFFFF;
 		tsync_inc_h = I40E_PTP_40GB_INCVAL >> 32;
 		break;