[4/4] .gitignore: ignore build directories from test-meson-build

Message ID 20190306170557.65627-4-bruce.richardson@intel.com
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [1/4] .gitignore: add section header comments
Related show

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson March 6, 2019, 5:05 p.m.
test-meson-build.sh generates multiple build directories for various
targets. As these follow a few known patterns of reasonable lengths,
and since they don't need to be tracked in git, we can add them to
the gitignore file.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 .gitignore | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Monjalon March 9, 2019, 12:47 a.m. | #1
06/03/2019 18:05, Bruce Richardson:
> test-meson-build.sh generates multiple build directories for various
> targets. As these follow a few known patterns of reasonable lengths,
> and since they don't need to be tracked in git, we can add them to
> the gitignore file.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> --- a/.gitignore
> +++ b/.gitignore
> +build-arm64-*
> +build-clang-*
> +build-gcc-*
> +build-x86-default

We could even ignore build-* ?
Stephen Hemminger March 9, 2019, 3:03 a.m. | #2
On Sat, 09 Mar 2019 01:47:32 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 06/03/2019 18:05, Bruce Richardson:
> > test-meson-build.sh generates multiple build directories for various
> > targets. As these follow a few known patterns of reasonable lengths,
> > and since they don't need to be tracked in git, we can add them to
> > the gitignore file.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > --- a/.gitignore
> > +++ b/.gitignore
> > +build-arm64-*
> > +build-clang-*
> > +build-gcc-*
> > +build-x86-default  
> 
> We could even ignore build-* ?
> 
> 

Why not?
build*

Since the default build directory in build/
Thomas Monjalon March 9, 2019, 10:40 a.m. | #3
09/03/2019 04:03, Stephen Hemminger:
> On Sat, 09 Mar 2019 01:47:32 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 06/03/2019 18:05, Bruce Richardson:
> > > test-meson-build.sh generates multiple build directories for various
> > > targets. As these follow a few known patterns of reasonable lengths,
> > > and since they don't need to be tracked in git, we can add them to
> > > the gitignore file.
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > +build-arm64-*
> > > +build-clang-*
> > > +build-gcc-*
> > > +build-x86-default  
> > 
> > We could even ignore build-* ?
> 
> Why not?
> build*
> 
> Since the default build directory in build/

Yes, but "git ls build*" is not empty because of buildtools/
Could be "build" and "build-*".
Rami Rosen March 9, 2019, 1:32 p.m. | #4
> Thomas Monjalon <thomas@monjalon.net> wrote:

>Yes, but "git ls build*" is not empty because of buildtools/
>Could be "build" and "build-*".

+1


>
>
>
>
>
Bruce Richardson March 11, 2019, 9:46 a.m. | #5
On Sat, Mar 09, 2019 at 03:32:57PM +0200, Rami Rosen wrote:
>    > Thomas Monjalon <[1]thomas@monjalon.net> wrote:
>    >Yes, but "git ls build*" is not empty because of buildtools/
>    >Could be "build" and "build-*".
>    +1
> 
Ok. I didn't want to be too liberal in my wildcarding hence the set I
provided, but I'll do a V2 with this sorter version, since it makes sense
and is unlikely to cause us issues.

/Bruce

Patch

diff --git a/.gitignore b/.gitignore
index 79509c35d..e10605c4b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -22,3 +22,9 @@  TAGS
 
 # ignore hidden files
 .*
+
+# ignore build directories from test-meson-builds
+build-arm64-*
+build-clang-*
+build-gcc-*
+build-x86-default