app/test: enhance meson test run for FreeBSD and Linux

Message ID 1551863976-14093-1-git-send-email-agalyax.babu.radhakrishnan@intel.com
State Rejected, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • app/test: enhance meson test run for FreeBSD and Linux
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Babu Radhakrishnan, AgalyaX March 6, 2019, 9:19 a.m.
From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>

1)For linux, running all tests on same cores can increase failure rate.
So instead run each test case on separate lcore using -l EAL option.
Lcore for each test case will be selected in the incremental order
of 0,1,2 ... till it reaches the maximum available cores in the
system which can be known from 'nproc' command.
On the other hand, by default meson runs all tests in parallel in
different threads which can be controlled by MESON_TESTTHREAD option.
eg. MESON_TESTTHREAD=4 meson test --suite DPDK:fast-tests

2)FreeBSD dont support file-prefix, so  changes are made to run the
tests without 'file-prefix'option.
eg. meson test --suite DPDK:fast-tests

Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
---
 app/test/meson.build | 28 +++++++++++++++++++++++-----
 1 file changed, 23 insertions(+), 5 deletions(-)

Comments

Pattan, Reshma April 1, 2019, 12:32 p.m. | #1
> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Wednesday, March 6, 2019 9:20 AM
> Subject: [PATCH] app/test: enhance meson test run for FreeBSD and Linux
> 
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> 
FYI, you might need mention about add new changes in doc once the below patch gets applied
http://patches.dpdk.org/patch/50117/ . 

Thanks,
Reshma
Pattan, Reshma April 3, 2019, 12:23 p.m. | #2
> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Wednesday, March 6, 2019 9:20 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Babu Radhakrishnan, AgalyaX
> <agalyax.babu.radhakrishnan@intel.com>
> Subject: [PATCH] app/test: enhance meson test run for FreeBSD and Linux
> 
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> 
> 1)For linux, running all tests on same cores can increase failure rate.
> So instead run each test case on separate lcore using -l EAL option.
> Lcore for each test case will be selected in the incremental order of 0,1,2 ... till it
> reaches the maximum available cores in the system which can be known from
> 'nproc' command.
> On the other hand, by default meson runs all tests in parallel in different threads
> which can be controlled by MESON_TESTTHREAD option.
> eg. MESON_TESTTHREAD=4 meson test --suite DPDK:fast-tests
> 
> 2)FreeBSD dont support file-prefix, so  changes are made to run the tests
> without 'file-prefix'option.

Nit-picks: space after file-prefix

Other than that
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>

Thanks,
Reshma
David Marchand April 3, 2019, 12:39 p.m. | #3
On Wed, Mar 6, 2019 at 10:21 AM Agalya Babu RadhaKrishnan <
agalyax.babu.radhakrishnan@intel.com> wrote:

> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
>
> 1)For linux, running all tests on same cores can increase failure rate.
> So instead run each test case on separate lcore using -l EAL option.
> Lcore for each test case will be selected in the incremental order
> of 0,1,2 ... till it reaches the maximum available cores in the
> system which can be known from 'nproc' command.
> On the other hand, by default meson runs all tests in parallel in
> different threads which can be controlled by MESON_TESTTHREAD option.
> eg. MESON_TESTTHREAD=4 meson test --suite DPDK:fast-tests
>
> 2)FreeBSD dont support file-prefix, so  changes are made to run the
> tests without 'file-prefix'option.
> eg. meson test --suite DPDK:fast-tests
>
> Signed-off-by: Agalya Babu RadhaKrishnan <
> agalyax.babu.radhakrishnan@intel.com>
> ---
>  app/test/meson.build | 28 +++++++++++++++++++++++-----
>  1 file changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 05e5ddeb0..8303aaaa6 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -337,11 +337,29 @@ if get_option('tests')
>         timeout_seconds_fast = 10
>
>         foreach arg : fast_parallel_test_names
> -               test(arg, dpdk_test,
> -                       env : ['DPDK_TEST=' + arg],
> -                       args : ['-c f','-n 4', '--file-prefix=@0@
> '.format(arg)],
> -                       timeout : timeout_seconds_fast,
> -                       suite : 'fast-tests')
> +               if host_machine.system() == 'linux'
> +                       lcore_number = 1
> +                       cores_running = run_command('nproc')
> +                       cores_used = cores_running.stdout().to_int()
> +                       test(arg, dpdk_test,
> +                               env : ['DPDK_TEST=' + arg],
> +                               args : ['-l @0@'.format(lcore_number),
> '-n 4', '--file-prefix=@0@'.format(arg)],
> +                               timeout : timeout_seconds_fast,
> +                               suite : 'fast-tests')
> +                       if (lcore_number < cores_used)
> +                               lcore_number += 1
> +                       else
> +                               lcore_number = 1
> +                       endif
> +               else
> +                       test(arg, dpdk_test,
> +                               env : ['DPDK_TEST=' + arg],
> +                               args : ['-n 4'],
> +                               is_parallel : false,
> +                               timeout : timeout_seconds_fast,
> +                               suite : 'fast-tests')
> +               endif
> +
>         endforeach
>
>         foreach arg : fast_non_parallel_test_names
>

We don't know if the tests really need those 4 cores, can you investigate
this point before touching those parameters ?


I am not sure I get all the subtilities in the meson part, but from what I
understood, for Linux, you look at all the cpus available and set the
corelist but for FreeBSD you rely on the EAL autodetection to catch all
cpus available since you don't give a corelist/mask.
To be consistent I would use the same mechanism for both Linux and FreeBSD,
but I would prefer we are sure on the tests needs for cpu resources.


Thanks.
Pattan, Reshma April 26, 2019, 2:53 p.m. | #4
> -----Original Message-----
> From: Babu Radhakrishnan, AgalyaX
> Sent: Wednesday, March 6, 2019 9:20 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Babu Radhakrishnan, AgalyaX
> <agalyax.babu.radhakrishnan@intel.com>
> Subject: [PATCH] app/test: enhance meson test run for FreeBSD and Linux
> 
> From: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> 
> 1)For linux, running all tests on same cores can increase failure rate.
> So instead run each test case on separate lcore using -l EAL option.
> Lcore for each test case will be selected in the incremental order of 0,1,2 ... till it
> reaches the maximum available cores in the system which can be known from
> 'nproc' command.
> On the other hand, by default meson runs all tests in parallel in different threads
> which can be controlled by MESON_TESTTHREAD option.
> eg. MESON_TESTTHREAD=4 meson test --suite DPDK:fast-tests
> 
> 2)FreeBSD dont support file-prefix, so  changes are made to run the tests
> without 'file-prefix'option.
> eg. meson test --suite DPDK:fast-tests
> 
> Signed-off-by: Agalya Babu RadhaKrishnan
> <agalyax.babu.radhakrishnan@intel.com>

Nacking this patch , as the similar patch http://patches.dpdk.org/patch/52730/ has been accepted.
Nacked-by: Reshma Pattan <reshma.pattan@intel.com>

Patch

diff --git a/app/test/meson.build b/app/test/meson.build
index 05e5ddeb0..8303aaaa6 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -337,11 +337,29 @@  if get_option('tests')
 	timeout_seconds_fast = 10
 
 	foreach arg : fast_parallel_test_names
-		test(arg, dpdk_test,
-			env : ['DPDK_TEST=' + arg],
-			args : ['-c f','-n 4', '--file-prefix=@0@'.format(arg)],
-			timeout : timeout_seconds_fast,
-			suite : 'fast-tests')
+		if host_machine.system() == 'linux'
+			lcore_number = 1
+			cores_running = run_command('nproc')
+			cores_used = cores_running.stdout().to_int()
+			test(arg, dpdk_test,
+				env : ['DPDK_TEST=' + arg],
+				args : ['-l @0@'.format(lcore_number), '-n 4', '--file-prefix=@0@'.format(arg)],
+				timeout : timeout_seconds_fast,
+				suite : 'fast-tests')
+			if (lcore_number < cores_used)
+				lcore_number += 1
+			else
+				lcore_number = 1
+			endif
+		else
+			test(arg, dpdk_test,
+				env : ['DPDK_TEST=' + arg],
+				args : ['-n 4'],
+				is_parallel : false,
+				timeout : timeout_seconds_fast,
+				suite : 'fast-tests')
+		endif
+
 	endforeach
 
 	foreach arg : fast_non_parallel_test_names