From patchwork Sat Mar 2 12:10:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Russkikh X-Patchwork-Id: 50763 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F24644BE; Sat, 2 Mar 2019 13:10:50 +0100 (CET) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690081.outbound.protection.outlook.com [40.107.69.81]) by dpdk.org (Postfix) with ESMTP id DD93E44BE for ; Sat, 2 Mar 2019 13:10:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7KPM4IQ2UuAZe5+7IiT/w275YDyDn+HzWcvY1nxfA20=; b=bBywtNUCvxVzAdefYkGDdLSDSnRwHNfOmMKmkz32CA5Amjgp5jpQZ1WymJPHNCYvrS6ja5T6Iyf0q6EjeIXQq9xmYb7N8JQ7jMHwJ8C0HNA2PiiRi1p/0Sicyy7jb3XTzGKNDI6iBo3w3uL4CXFhNvpnMJbfFkKwSziwj07CFg8= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Sat, 2 Mar 2019 12:10:47 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019; Sat, 2 Mar 2019 12:10:47 +0000 From: Igor Russkikh To: "dev@dpdk.org" CC: Pavel Belous , Igor Russkikh Thread-Topic: [PATCH 03/10] net/atlantic: check for error codes Thread-Index: AQHU0PD4nhZGjUb150eVQOLB8UPEuQ== Date: Sat, 2 Mar 2019 12:10:47 +0000 Message-ID: <7e077beff7792d403135f93a9e68c6308aa7e4a8.1551528549.git.igor.russkikh@aquantia.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1P190CA0057.EURP190.PROD.OUTLOOK.COM (2603:10a6:7:52::46) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28ac51b5-395e-46fe-1d0d-08d69f081a5c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:DM6PR11MB3867; x-ms-traffictypediagnostic: DM6PR11MB3867: x-microsoft-exchange-diagnostics: =?iso-8859-1?Q?1; DM6PR11MB3867; 23:hZwfA3rke2Js0Y9ppGPUm8X2O83Xo6qs8pSobkn?= =?iso-8859-1?q?ko2y7t9yAE5wOZ5Ozv4iX5q29?= =?iso-8859-1?q?jDXDbPaRMK7onYbYzTKLTUL+r0OsOYHnZfW6e/wF+1JRlrl7Tbc?= =?iso-8859-1?q?uihUDQqFbKmByMukatdtXIboQ1ixZoXcZPH+BfMYELttXXYQp+g?= =?iso-8859-1?q?1MncSwUDdgt/hMRz4ziOD8C2p14EI145QVbseTYEjgg0Xqcv1Y/?= =?iso-8859-1?q?pld1ZvfSUdbMef4odnLeTT270tvptZl1auKSF6tIz89Vw9jJDgA?= =?iso-8859-1?q?NQ3ZpSHjcRshaOG5RgX7927U6yikt27bhil8qnQqiUATk+4c19s?= =?iso-8859-1?q?1Rlnb2rPKkp5BZf5QP6lOIUcx2YlO+xxU9FPvt+FOBrSzKGhLfZ?= =?iso-8859-1?q?LhfB/M6qHmIo2m8V1Sp9SP0qyPSDU/j0gO1trG4KQuV1ZygFYAE?= =?iso-8859-1?q?fiwB1pPQcBTE7ts6qCn5wbbrQRCn6vzMTy7+ft3266JIBOfaCLa?= =?iso-8859-1?q?ZJRWMPmh0zK20FhFa7LPiAz7EiOfLLqLi0p1kNaEZwwxvS3wsUg?= =?iso-8859-1?q?019vCtQ5Gj8nxmnYnilHe9iJHJ4Y4S0ak52gH8xc4gvWji4RLo3?= =?iso-8859-1?q?5g6F/CJ6jF2+qd/aD5ciK6mHSyriHCyAG3vaYodUpRSTJGqd5hU?= =?iso-8859-1?q?lGgamBwmax7oxD6vMXCunDNwK1RiBj4ZsDfIe0p1TosjvVLv2Cr?= =?iso-8859-1?q?PVBHKxs4lEDhUaFYjZXwVGne3aQPC5LgNkxvlb8dzVD8+Q1pgLR?= =?iso-8859-1?q?42CivU2Q1pK8tMDsXykPR4AlVNOi1IhqrO4BRukVEm0QUFQOTgV?= =?iso-8859-1?q?+7WAbR7oODqva43WkiXxrqpfCZxxMhNava+cU9Yvo0gL5QwFUhx?= =?iso-8859-1?q?xEgfzDHEgLWhEKrExmAX2wubsDe/E+BPYcP30rILAkf6xkFQ9Ly?= =?iso-8859-1?q?6YkahoM/pYXMgpv+O7ZAzKIYwFrtNdNDde9u8uJkRRU2i0WJAJY?= =?iso-8859-1?q?mj+q8uDzIcvoq10zODaDNoBqFAAEmdzHRRB9oymIYwCQ95sz/i9?= =?iso-8859-1?q?Jsdw5CE5PjH65tOjG8NLhybNT0hYv/c0VoickuBFnfYKvqCOThD?= =?iso-8859-1?q?I8yfVans7qC/8QGChrrWsbZLCicUF2KBivfgjO8GAqfyh0ZO/j8?= =?iso-8859-1?q?M5RB4MNmIuT2JWt9DBAUnejb2MXDpDf8RxSQ3sZLkWz0TTGILT5?= =?iso-8859-1?q?QMPDPlCvWUttwb4hiMqS58lr22TQ/6N4HGUbibviOMFI019Sgzy?= =?iso-8859-1?q?zYzWcWoIL1qjeTwuBHYcLYAg2kinF3W5PgAVh0nlkOs45p9s6Kf?= =?iso-8859-1?q?4rKhG11wMFIbPsrXM8EL9N86pl5x33ieAdyUalKK2aY+X0g8V8Z?= =?iso-8859-1?q?75N9NPkvdST0OKkNm6Y79TU7S/cyGkzv9gyHcV2oaFfasDQOBVE?= =?iso-8859-1?q?kxIQgZ+qSZJ7YqjCBlARi4HBcad3shpuCpbA2vET86ciIOfc=3D?= x-microsoft-antispam-prvs: x-forefront-prvs: 09645BAC66 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(4744005)(118296001)(50226002)(44832011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867; H:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: V7XQpLpHX0or2IXKDo32jO7VZjYVZip4u+XWlsGX1LjKM+DDlYdxEV66Rfsy0sM5WIW4dYmmyV984sMobqHZbKjdqZTr6jYv++HqAK/2BBTYwIv0fUz9BM14Ce5z2Q9tGjyn/5CeQr8qjvqOdiesgvqycMZDboT2ECcGaZD8uJ3T0lRJ4AZjzJWAENxoCfOwaXVsppYK7ZfhW6oAwONBi0Y4EIqM0Dg5/UUqDfiLCiMU4xJEUkPOcpC6eHJRvdHhC4lklCodaxGlwphV/GC4+0R07xE2Tga3YYAmMF6VCSuhP+6gY/fS+0TkeeSXpx6TOuX6qRphywwr8W3jVY1K/JaCtW36sgRyIFz7+kotTN/QdZ6ckXzmtizwCiZUwlQuMatDY3sjn9gvEP+DTsWHpIAa0lHQV+oe+WKbLx+oKcA= MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28ac51b5-395e-46fe-1d0d-08d69f081a5c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2019 12:10:45.8985 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3867 Subject: [dpdk-dev] [PATCH 03/10] net/atlantic: check for error codes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Found by Coverity Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c index f11093a50..13f02b9f9 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c @@ -462,8 +462,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self, goto err_exit; } } while (sw.tid != fw.tid || 0xFFFFU == fw.len); - if (err < 0) - goto err_exit; if (rpc) { if (fw.len) { @@ -875,8 +873,7 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac) } err = hw_atl_utils_fw_rpc_call(self, rpc_size); - if (err < 0) - goto err_exit; + err_exit: return err; }