[1/3] common/cpt: improve structures used in datapath

Message ID 1551465683-26721-1-git-send-email-anoobj@marvell.com
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series
  • [1/3] common/cpt: improve structures used in datapath
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Anoob Joseph March 1, 2019, 6:42 p.m.
Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 drivers/common/cpt/cpt_common.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Anoob Joseph March 19, 2019, 4:36 a.m. | #1
Hi Akhil,

Can you review this series and share your thoughts?

Thanks,
Anoob

> -----Original Message-----
> From: Anoob Joseph
> Sent: Saturday, March 2, 2019 12:12 AM
> To: Akhil Goyal <akhil.goyal@nxp.com>; Pablo de Lara
> <pablo.de.lara.guarch@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Narayana Prasad Raju Athreya
> <pathreya@marvell.com>; Suheil Chandran <schandran@marvell.com>;
> Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
> Subject: [PATCH 1/3] common/cpt: improve structures used in datapath
> 
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
>  drivers/common/cpt/cpt_common.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/common/cpt/cpt_common.h
> b/drivers/common/cpt/cpt_common.h index 8461cd6..8568d5b 100644
> --- a/drivers/common/cpt/cpt_common.h
> +++ b/drivers/common/cpt/cpt_common.h
> @@ -60,14 +60,14 @@ struct rid {
>   *
>   */
>  struct pending_queue {
> +	/** Pending requests count */
> +	uint64_t pending_count;
> +	/** Array of pending requests */
> +	struct rid *rid_queue;
>  	/** Tail of queue to be used for enqueue */
>  	uint16_t enq_tail;
>  	/** Head of queue to be used for dequeue */
>  	uint16_t deq_head;
> -	/** Array of pending requests */
> -	struct rid *rid_queue;
> -	/** Pending requests count */
> -	uint64_t pending_count;
>  };
> 
>  struct cpt_request_info {
> @@ -86,6 +86,6 @@ struct cpt_request_info {
>  	/** Control path fields */
>  	uint64_t time_out;
>  	uint8_t extra_time;
> -};
> +} __rte_cache_aligned;
> 
>  #endif /* _CPT_COMMON_H_ */
> --
> 2.7.4
Akhil Goyal March 22, 2019, 3:03 p.m. | #2
On 3/19/2019 10:06 AM, Anoob Joseph wrote:
> Hi Akhil,
>
> Can you review this series and share your thoughts?
>
> Thanks,
> Anoob
Patchset applied to dpdk-next-crypto

Thanks.

Patch

diff --git a/drivers/common/cpt/cpt_common.h b/drivers/common/cpt/cpt_common.h
index 8461cd6..8568d5b 100644
--- a/drivers/common/cpt/cpt_common.h
+++ b/drivers/common/cpt/cpt_common.h
@@ -60,14 +60,14 @@  struct rid {
  *
  */
 struct pending_queue {
+	/** Pending requests count */
+	uint64_t pending_count;
+	/** Array of pending requests */
+	struct rid *rid_queue;
 	/** Tail of queue to be used for enqueue */
 	uint16_t enq_tail;
 	/** Head of queue to be used for dequeue */
 	uint16_t deq_head;
-	/** Array of pending requests */
-	struct rid *rid_queue;
-	/** Pending requests count */
-	uint64_t pending_count;
 };
 
 struct cpt_request_info {
@@ -86,6 +86,6 @@  struct cpt_request_info {
 	/** Control path fields */
 	uint64_t time_out;
 	uint8_t extra_time;
-};
+} __rte_cache_aligned;
 
 #endif /* _CPT_COMMON_H_ */