[3/3] app/eventdev: follow proper teardown sequence

Message ID 20190301071617.6570-3-pbhagavatula@marvell.com
State Accepted, archived
Delegated to: Jerin Jacob
Headers show
Series
  • [1/3] examples/eventdev_pipeline: configure max events based on dev info
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Pavan Nikhilesh Bhagavatula March 1, 2019, 7:16 a.m.
From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Stop eventdev before closing it.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 app/test-eventdev/test_pipeline_common.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Van Haaren, Harry March 11, 2019, 9:58 a.m. | #1
> -----Original Message-----
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@marvell.com]
> Sent: Friday, March 1, 2019 7:17 AM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper teardown
> sequence
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Stop eventdev before closing it.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Jerin Jacob Kollanukkaran March 11, 2019, 3:12 p.m. | #2
On Mon, 2019-03-11 at 09:58 +0000, Van Haaren, Harry wrote:
> -------------------------------------------------------------------
> ---
> > -----Original Message-----
> > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@marvell.com]
> > Sent: Friday, March 1, 2019 7:17 AM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Van Haaren,
> > Harry
> > <harry.van.haaren@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <
> > pbhagavatula@marvell.com>
> > Subject: [dpdk-dev] [PATCH 3/3] app/eventdev: follow proper
> > teardown
> > sequence
> > 
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > 
> > Stop eventdev before closing it.
> > 
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

Series applied to dpdk-next-eventdev/master. Thanks.

Patch

diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
index 5db3ffde1..1e525643d 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -396,6 +396,7 @@  pipeline_eventdev_destroy(struct evt_test *test, struct evt_options *opt)
 {
 	RTE_SET_USED(test);
 
+	rte_event_dev_stop(opt->dev_id);
 	rte_event_dev_close(opt->dev_id);
 }