From patchwork Sun Feb 24 23:35:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Stojaczyk X-Patchwork-Id: 50481 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 666C62C2F; Mon, 25 Feb 2019 00:36:04 +0100 (CET) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by dpdk.org (Postfix) with ESMTP id E0C272A6A for ; Mon, 25 Feb 2019 00:36:02 +0100 (CET) Received: by mail-lf1-f68.google.com with SMTP id q11so5505818lfd.3 for ; Sun, 24 Feb 2019 15:36:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=AWznuH4k4p8iwyjoaBx6QkMhpTICU6bfZ4HMk32eZfk=; b=l3j2umw56qF7NpFe+arXHHBL2Id+LA02Oxv6dAukN6aRndflsMRct/sX4zlP/y9/11 kIgA7v3Gb4ffL0Z9TX9HzR2YL1ikkkMekiK0fa5vQBVGbliqos3VmjftvWMCNt7IPeHG gyI2YfJt75yup/cLoRiOyjZuunDKtsXcsZVOwZSVCW9rpM9214zUjWsFXjtWvNKXeehm j7y/UmSU5KuevUBirMTCrfhXckrVJEB9mEuVSabpi0lD54qO7uV3j0XiYT2crHz/SOCQ bNZDk+Zv85HkF7Ez8qxIWXsj4Y7YgKhxdXzSmV8Ms7CWgkgsFn6TE717qzfwMU45jpVj JBBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AWznuH4k4p8iwyjoaBx6QkMhpTICU6bfZ4HMk32eZfk=; b=BMpkG5v1hJmTbkBlvDFWR4Hykl2GS15Z++AXgyMF3zlUzUZtVOW1KDpDeAh5ebompH no0e03XIrV5P9OYMOhut59pm3Ni3lfK7ijP9dgYdDS4LZTKzpMacelW9HEVZvxZGmLhF pGjFWEdhC1LedhUQqlJtqNibUVEwRS6DvQ4l3mG4iTgKWHQtywEH7vcIEj0aIRRrh7g/ tZ0EwG2602jUyHPE6J9XOIPTaIrMIw+o1Bwyt5C6UmhOOrOGdQs84JjrgDMVaAuwC4L6 IHztVWSft7JgEXW+gHBX8jQYmzgFyrn34Xx0QPJfH7alG0e+3F2KfdowKp06VTTlUr0D 1O1w== X-Gm-Message-State: AHQUAuaPN9cgpbfG6yaSzNJK7Ce9c4993mnORasuOwVUOB/ozGlOwTXD gPvCqsjbCQh1S41qjZjOXnLpE2VqUxg= X-Google-Smtp-Source: AHgI3IarYZScFfkcY/uGzwt0JJDLauAicuK87K80exBuDFevyTjvpmBxe7DQVf6IjuFkhFdt26pk5Q== X-Received: by 2002:ac2:508e:: with SMTP id f14mr9225840lfm.80.1551051362019; Sun, 24 Feb 2019 15:36:02 -0800 (PST) Received: from localhost.localdomain (89-78-174-111.dynamic.chello.pl. [89.78.174.111]) by smtp.gmail.com with ESMTPSA id t14sm2191186lft.96.2019.02.24.15.36.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Feb 2019 15:36:01 -0800 (PST) From: Dariusz Stojaczyk To: dev@dpdk.org, tiwei.bie@intel.com, maxime.coquelin@redhat.com, zhihong.wang@intel.com Cc: Darek Stojaczyk Date: Mon, 25 Feb 2019 00:35:55 +0100 Message-Id: <20190224233555.31304-1-darek.stojaczyk@gmail.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH] vhost: remove vhost-net requirements from generic vhost APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Darek Stojaczyk The rte_vhost API to put data into virtqueues operates on mbufs and hence it is strictly vhost-net specific. External backends need to implement virtqueue handling from scratch and that's just not possible without APIs to get/set vring base addresses. Those relevant APIs are there, but they have a check that prevents them from working with any non-vhost-net device. This patch removes those checks. rte_vhost_get_log_base() is not necessarily needed for external backends, as other, higher level vhost APIs for live migration are available and could be used instead. We remove the extra check from it anyway for consistency. Signed-off-by: Darek Stojaczyk Reviewed-by: Tiwei Bie --- lib/librte_vhost/vhost.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index 00ec58e01..e480aeac9 100644 --- a/lib/librte_vhost/vhost.c +++ b/lib/librte_vhost/vhost.c @@ -766,13 +766,6 @@ int rte_vhost_get_log_base(int vid, uint64_t *log_base, if (!dev) return -1; - if (unlikely(!(dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET))) { - RTE_LOG(ERR, VHOST_DATA, - "(%d) %s: built-in vhost net backend is disabled.\n", - dev->vid, __func__); - return -1; - } - *log_base = dev->log_base; *log_size = dev->log_size; @@ -787,13 +780,6 @@ int rte_vhost_get_vring_base(int vid, uint16_t queue_id, if (!dev) return -1; - if (unlikely(!(dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET))) { - RTE_LOG(ERR, VHOST_DATA, - "(%d) %s: built-in vhost net backend is disabled.\n", - dev->vid, __func__); - return -1; - } - *last_avail_idx = dev->virtqueue[queue_id]->last_avail_idx; *last_used_idx = dev->virtqueue[queue_id]->last_used_idx; @@ -808,13 +794,6 @@ int rte_vhost_set_vring_base(int vid, uint16_t queue_id, if (!dev) return -1; - if (unlikely(!(dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET))) { - RTE_LOG(ERR, VHOST_DATA, - "(%d) %s: built-in vhost net backend is disabled.\n", - dev->vid, __func__); - return -1; - } - dev->virtqueue[queue_id]->last_avail_idx = last_avail_idx; dev->virtqueue[queue_id]->last_used_idx = last_used_idx;