net/mlx5: call generic strlcpy

Message ID 20190224224240.26361-1-thomas@monjalon.net
State Accepted, archived
Delegated to: Shahaf Shuler
Headers show
Series
  • net/mlx5: call generic strlcpy
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Thomas Monjalon Feb. 24, 2019, 10:42 p.m.
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
No need to call the DPDK flavor explictly.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/mlx5/mlx5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rami Rosen Feb. 25, 2019, 6:26 a.m. | #1
Checked on Fedora 28

Reviewed-by: Rami Rosen <ramirose at gmail.com>


On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net>
wrote:

> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/mlx5/mlx5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index df71707ccb..bda909eaa5 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>         }
>         /* Build device name. */
>         if (!switch_info->representor)
> -               rte_strlcpy(name, dpdk_dev->name, sizeof(name));
> +               strlcpy(name, dpdk_dev->name, sizeof(name));
>         else
>                 snprintf(name, sizeof(name), "%s_representor_%u",
>                          dpdk_dev->name, switch_info->port_name);
> --
> 2.20.1
>
>
Shahaf Shuler March 7, 2019, 8:35 a.m. | #2
Applied to next-net-mlx, thanks.

From: Rami Rosen <ramirose@gmail.com>
Sent: Monday, February 25, 2019 8:26 AM
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh <yskoh@mellanox.com>; dev <dev@dpdk.org>; Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy

Checked on Fedora 28

Reviewed-by: Rami Rosen <ramirose at gmail.com<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgmail.com&data=02%7C01%7Cshahafs%40mellanox.com%7Ca6471d19ffc94a63e8f308d69aea31bf%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636866727983375321&sdata=JE%2BULD6LG98IBEf6D%2F3bW98LivPLm2QD7xlshkdQDdc%3D&reserved=0>>


On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote:
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
No need to call the DPDK flavor explictly.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>>
---
 drivers/net/mlx5/mlx5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index df71707ccb..bda909eaa5 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
        }
        /* Build device name. */
        if (!switch_info->representor)
-               rte_strlcpy(name, dpdk_dev->name, sizeof(name));
+               strlcpy(name, dpdk_dev->name, sizeof(name));
        else
                snprintf(name, sizeof(name), "%s_representor_%u",
                         dpdk_dev->name, switch_info->port_name);
--
2.20.1


--
regards,
Rami Rosen

Patch

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index df71707ccb..bda909eaa5 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -785,7 +785,7 @@  mlx5_dev_spawn(struct rte_device *dpdk_dev,
 	}
 	/* Build device name. */
 	if (!switch_info->representor)
-		rte_strlcpy(name, dpdk_dev->name, sizeof(name));
+		strlcpy(name, dpdk_dev->name, sizeof(name));
 	else
 		snprintf(name, sizeof(name), "%s_representor_%u",
 			 dpdk_dev->name, switch_info->port_name);