From patchwork Wed Feb 20 23:00:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dharmik Thakkar X-Patchwork-Id: 50408 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 429C52BA7; Thu, 21 Feb 2019 00:00:40 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id BE0121F28 for ; Thu, 21 Feb 2019 00:00:35 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2E9171682; Wed, 20 Feb 2019 15:00:35 -0800 (PST) Received: from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com [10.118.12.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E11EC3F719; Wed, 20 Feb 2019 15:00:34 -0800 (PST) From: Dharmik Thakkar To: Byron Marohn , Pablo de Lara Guarch Cc: dev@dpdk.org, Dharmik Thakkar Date: Wed, 20 Feb 2019 17:00:22 -0600 Message-Id: <20190220230023.17029-3-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190220230023.17029-1-dharmik.thakkar@arm.com> References: <20190220224714.16303-1-dharmik.thakkar@arm.com> <20190220230023.17029-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH v3 2/3] test/efd: enable unit test compilation always X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-type=efd,8 Suggested-by: Thomas Monjalon Signed-off-by: Dharmik Thakkar Reviewed-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Phil Yang Reviewed-by: Ferruh Yigit --- v3: * Resolve coding style issues --- v2: * Add Reviewed-by tag --- test/test/test_efd.c | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/test/test/test_efd.c b/test/test/test_efd.c index ced091aab63d..3b6f9db13565 100644 --- a/test/test/test_efd.c +++ b/test/test/test_efd.c @@ -34,28 +34,20 @@ struct flow_key { /* * Print out result of unit test efd operation. */ -#if defined(UNIT_TEST_EFD_VERBOSE) - static void print_key_info(const char *msg, const struct flow_key *key, efd_value_t val) { - const uint8_t *p = (const uint8_t *) key; - unsigned int i; + if (rte_log_get_level(RTE_LOGTYPE_EFD) == RTE_LOG_DEBUG) { + const uint8_t *p = (const uint8_t *) key; + unsigned int i; - printf("%s key:0x", msg); - for (i = 0; i < sizeof(struct flow_key); i++) - printf("%02X", p[i]); - - printf(" @ val %d\n", val); -} -#else + printf("%s key:0x", msg); + for (i = 0; i < sizeof(struct flow_key); i++) + printf("%02X", p[i]); -static void print_key_info(__attribute__((unused)) const char *msg, - __attribute__((unused)) const struct flow_key *key, - __attribute__((unused)) efd_value_t val) -{ + printf(" @ val %d\n", val); + } } -#endif /* Keys used by unit test functions */ static struct flow_key keys[5] = {