[v3] power: fix to remove unused variable

Message ID 1550226524-26278-1-git-send-email-pallantlax.poornima@intel.com
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [v3] power: fix to remove unused variable
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Pallantla Poornima Feb. 15, 2019, 10:28 a.m.
Variable pfi_str is removed since it is unused.

Fixes: 450f0791312c ("power: add traffic pattern aware power control")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
---
v3: Updated fixes line.
v2: Removed unused variable as suggested.
---
 lib/librte_power/rte_power_empty_poll.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

David Hunt Feb. 15, 2019, 11:41 a.m. | #1
On 15/2/2019 10:28 AM, Pallantla Poornima wrote:
> Variable pfi_str is removed since it is unused.
>
> Fixes: 450f0791312c ("power: add traffic pattern aware power control")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
> ---
> v3: Updated fixes line.
> v2: Removed unused variable as suggested.
> ---
>   lib/librte_power/rte_power_empty_poll.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c
> index e6145462f..15d4f0509 100644
> --- a/lib/librte_power/rte_power_empty_poll.c
> +++ b/lib/librte_power/rte_power_empty_poll.c
> @@ -156,11 +156,8 @@ update_training_stats(struct priority_worker *poll_stats,
>   {
>   	RTE_SET_USED(specific_freq);
>   
> -	char pfi_str[32];
>   	uint64_t p0_empty_deq;
>   
> -	sprintf(pfi_str, "%02d", freq);
> -
>   	if (poll_stats->cur_freq == freq &&
>   			poll_stats->thresh[freq].trained == false) {
>   		if (poll_stats->thresh[freq].cur_train_iter == 0) {


Acked-by: David Hunt <david.hunt@intel.com>
Aaron Conole Feb. 15, 2019, 2:14 p.m. | #2
Pallantla Poornima <pallantlax.poornima@intel.com> writes:

> Variable pfi_str is removed since it is unused.
>
> Fixes: 450f0791312c ("power: add traffic pattern aware power control")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
> ---

Whoops, missed the v3

Acked-by: Aaron Conole <aconole@redhat.com>
Thomas Monjalon April 4, 2019, 11:30 p.m. | #3
15/02/2019 12:41, Hunt, David:
> 
> On 15/2/2019 10:28 AM, Pallantla Poornima wrote:
> > Variable pfi_str is removed since it is unused.
> >
> > Fixes: 450f0791312c ("power: add traffic pattern aware power control")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> > Reviewed-by: Rami Rosen <ramirose@gmail.com>
> 
> Acked-by: David Hunt <david.hunt@intel.com>

Applied, thanks

Patch

diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c
index e6145462f..15d4f0509 100644
--- a/lib/librte_power/rte_power_empty_poll.c
+++ b/lib/librte_power/rte_power_empty_poll.c
@@ -156,11 +156,8 @@  update_training_stats(struct priority_worker *poll_stats,
 {
 	RTE_SET_USED(specific_freq);
 
-	char pfi_str[32];
 	uint64_t p0_empty_deq;
 
-	sprintf(pfi_str, "%02d", freq);
-
 	if (poll_stats->cur_freq == freq &&
 			poll_stats->thresh[freq].trained == false) {
 		if (poll_stats->thresh[freq].cur_train_iter == 0) {