ethdev: remove unused variable

Message ID 20190214162921.3735-1-thomas@monjalon.net
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series
  • ethdev: remove unused variable
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Thomas Monjalon Feb. 14, 2019, 4:29 p.m.
When removing the old attach function, the racy variable for getting
the last port id became unused.

Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_ethdev/rte_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Andrew Rybchenko Feb. 14, 2019, 5:34 p.m. | #1
On 2/14/19 7:29 PM, Thomas Monjalon wrote:
> When removing the old attach function, the racy variable for getting
> the last port id became unused.
>
> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Ferruh Yigit Feb. 18, 2019, 5:40 p.m. | #2
On 2/14/2019 5:34 PM, Andrew Rybchenko wrote:
> On 2/14/19 7:29 PM, Thomas Monjalon wrote:
>> When removing the old attach function, the racy variable for getting
>> the last port id became unused.
>>
>> Fixes: c9cce42876f5 ("ethdev: remove deprecated attach/detach functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied to dpdk-next-net/master, thanks.

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 3b1d1a560..a2b63951f 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -48,7 +48,6 @@  int rte_eth_dev_logtype;
 
 static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data";
 struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS];
-static uint16_t eth_dev_last_created_port;
 
 /* spinlock for eth device callbacks */
 static rte_spinlock_t rte_eth_dev_cb_lock = RTE_SPINLOCK_INITIALIZER;
@@ -445,8 +444,6 @@  eth_dev_get(uint16_t port_id)
 
 	eth_dev->data = &rte_eth_dev_shared_data->data[port_id];
 
-	eth_dev_last_created_port = port_id;
-
 	return eth_dev;
 }