net/avf: enable admin queue interrupt

Message ID 1550048053-27288-1-git-send-email-wei.zhao1@intel.com
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series
  • net/avf: enable admin queue interrupt
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Wei Zhao Feb. 13, 2019, 8:54 a.m.
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version
in order to enable admin queue interrupt in avf mode.
If not, avf will not work.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 drivers/net/avf/avf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stillwell Jr, Paul M Feb. 13, 2019, 6:58 p.m. | #1
> There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to enable admin queue interrupt in avf mode.

Minor nit: You misspelled enable above
Zhang, Qi Z Feb. 18, 2019, 12:22 p.m. | #2
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, February 13, 2019 4:54 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/avf: enable admin queue interrupt
> 
Change title to "enable CLEARPBA bit"

> There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to
> enable admin queue interrupt in avf mode.
> If not, avf will not work.

Reword to

Enable CLEARPBA bit is required by ice NIC of A0/A1 version to
enable admin queue interrupt.
Also enable CLEARPBA bit does no impact on AVF behaviour when be
hosted by other devices, so we can make it as default.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

Patch

diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 13eec1b..797f505 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -1159,7 +1159,7 @@  avf_enable_irq0(struct avf_hw *hw)
 	AVF_WRITE_REG(hw, AVFINT_ICR0_ENA1, AVFINT_ICR0_ENA1_ADMINQ_MASK);
 
 	AVF_WRITE_REG(hw, AVFINT_DYN_CTL01, AVFINT_DYN_CTL01_INTENA_MASK |
-					    AVFINT_DYN_CTL01_ITR_INDX_MASK);
+		AVFINT_DYN_CTL01_CLEARPBA_MASK | AVFINT_DYN_CTL01_ITR_INDX_MASK);
 
 	AVF_WRITE_FLUSH(hw);
 }