net/virtio: remove unnecessary forward declaration

Message ID 20190123172948.4016-1-ramirose@gmail.com
State Accepted, archived
Delegated to: Maxime Coquelin
Headers show
Series
  • net/virtio: remove unnecessary forward declaration
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Rami Rosen Jan. 23, 2019, 5:29 p.m.
This minor cleanup patch removes an unecessary forward
declaration of virtio_intr_enable() in net/virtio PMD.

Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 drivers/net/virtio/virtio_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Maxime Coquelin Feb. 8, 2019, 5:34 p.m. | #1
On 1/23/19 6:29 PM, Rami Rosen wrote:
> This minor cleanup patch removes an unecessary forward
s/unecessary/unnecessary/

> declaration of virtio_intr_enable() in net/virtio PMD.
> 
> Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index ee5a98b..d8fd288 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -71,7 +71,6 @@ static int virtio_mac_addr_add(struct rte_eth_dev *dev,
>   static int virtio_mac_addr_set(struct rte_eth_dev *dev,
>   				struct ether_addr *mac_addr);
>   
> -static int virtio_intr_enable(struct rte_eth_dev *dev);
>   static int virtio_intr_disable(struct rte_eth_dev *dev);
>   
>   static int virtio_dev_queue_stats_mapping_set(
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

I'll fix the typo while applying.

Thanks,
Maxime
Maxime Coquelin Feb. 8, 2019, 6:06 p.m. | #2
On 1/23/19 6:29 PM, Rami Rosen wrote:
> This minor cleanup patch removes an unecessary forward
> declaration of virtio_intr_enable() in net/virtio PMD.
> 
> Fixes: fe19d49cb525 ("net/virtio: fix Rx interrupt with VFIO")
> Cc: stable@dpdk.org
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>   drivers/net/virtio/virtio_ethdev.c | 1 -
>   1 file changed, 1 deletion(-)
> 

Applied to dpdk-next-virtio/master.

Thanks,
Maxime

Patch

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index ee5a98b..d8fd288 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -71,7 +71,6 @@  static int virtio_mac_addr_add(struct rte_eth_dev *dev,
 static int virtio_mac_addr_set(struct rte_eth_dev *dev,
 				struct ether_addr *mac_addr);
 
-static int virtio_intr_enable(struct rte_eth_dev *dev);
 static int virtio_intr_disable(struct rte_eth_dev *dev);
 
 static int virtio_dev_queue_stats_mapping_set(