test: fix build when disabling ipsec library

Message ID 1547720122-5835-1-git-send-email-david.marchand@redhat.com
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series
  • test: fix build when disabling ipsec library
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

David Marchand Jan. 17, 2019, 10:15 a.m.
Caught after pulling ipsec then compile in an existing build directory.

Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Did a simple fix, we might want to have something like a _LDLIBS-y
variable but that's just cosmetic.

---
 test/test/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ananyev, Konstantin Jan. 17, 2019, 12:20 p.m. | #1
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Thursday, January 17, 2019 10:15 AM
> To: dev@dpdk.org
> Cc: Awal, Mohammad Abdul <mohammad.abdul.awal@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>; Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Subject: [PATCH] test: fix build when disabling ipsec library
> 
> Caught after pulling ipsec then compile in an existing build directory.
> 
> Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Did a simple fix, we might want to have something like a _LDLIBS-y
> variable but that's just cosmetic.
> 
> ---
>  test/test/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/test/test/Makefile b/test/test/Makefile
> index e7c8108..5641a59 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -208,7 +208,9 @@ SRCS-$(CONFIG_RTE_LIBRTE_KVARGS) += test_kvargs.c
>  SRCS-$(CONFIG_RTE_LIBRTE_BPF) += test_bpf.c
> 
>  SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c
> +ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y)
>  LDLIBS += -lrte_ipsec
> +endif
> 
>  CFLAGS += -DALLOW_EXPERIMENTAL_API
> 
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 1.8.3.1
Thomas Monjalon Jan. 17, 2019, 11:16 p.m. | #2
17/01/2019 13:20, Ananyev, Konstantin:
> From: David Marchand [mailto:david.marchand@redhat.com]
> > 
> > Caught after pulling ipsec then compile in an existing build directory.
> > 
> > Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > Did a simple fix, we might want to have something like a _LDLIBS-y
> > variable but that's just cosmetic.
> > 
> > ---
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks

Patch

diff --git a/test/test/Makefile b/test/test/Makefile
index e7c8108..5641a59 100644
--- a/test/test/Makefile
+++ b/test/test/Makefile
@@ -208,7 +208,9 @@  SRCS-$(CONFIG_RTE_LIBRTE_KVARGS) += test_kvargs.c
 SRCS-$(CONFIG_RTE_LIBRTE_BPF) += test_bpf.c
 
 SRCS-$(CONFIG_RTE_LIBRTE_IPSEC) += test_ipsec.c
+ifeq ($(CONFIG_RTE_LIBRTE_IPSEC),y)
 LDLIBS += -lrte_ipsec
+endif
 
 CFLAGS += -DALLOW_EXPERIMENTAL_API