[DPDK] bus/ifpga: fix a brackets unmatch

Message ID 1547703135-195893-1-git-send-email-andy.pei@intel.com
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [DPDK] bus/ifpga: fix a brackets unmatch
Related show

Checks

Context Check Description
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Andy Pei Jan. 17, 2019, 5:32 a.m.
The code

extern "C" {

miss a related

}

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: rosen.xu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/bus/ifpga/rte_bus_ifpga.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Rosen Xu Jan. 17, 2019, 8:36 a.m. | #1
Hi,

> -----Original Message-----
> From: Pei, Andy
> Sent: Thursday, January 17, 2019 13:32
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>;
> stable@dpdk.org
> Subject: [DPDK] bus/ifpga: fix a brackets unmatch

I think it's v2 patch, so pls identify it.
For the title, I think this one could be better.

C linkage names declaration brackets mismatch

> The code
> 
> extern "C" {
> 
> miss a related
> 
> }
Pls descript it in detail not in demo code.

> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> Cc: rosen.xu@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/bus/ifpga/rte_bus_ifpga.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h
> b/drivers/bus/ifpga/rte_bus_ifpga.h
> index d53c0f4..0bf43ba 100644
> --- a/drivers/bus/ifpga/rte_bus_ifpga.h
> +++ b/drivers/bus/ifpga/rte_bus_ifpga.h
> @@ -13,7 +13,7 @@
> 
>  #ifdef __cplusplus
>  extern "C" {
> -#endif
> +#endif /* __cplusplus */
> 
>  #include <rte_bus.h>
>  #include <rte_pci.h>
> @@ -143,4 +143,8 @@ struct rte_afu_driver {  #define
> RTE_PMD_REGISTER_AFU_ALIAS(nm, alias)\  static const char *afudrvinit_ ##
> nm ## _alias = RTE_STR(alias)
> 
> +#ifdef __cplusplus
> +}
> +#endif /* __cplusplus */
> +
>  #endif /* _RTE_BUS_IFPGA_H_ */
> --
> 1.8.3.1

Patch

diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h b/drivers/bus/ifpga/rte_bus_ifpga.h
index d53c0f4..0bf43ba 100644
--- a/drivers/bus/ifpga/rte_bus_ifpga.h
+++ b/drivers/bus/ifpga/rte_bus_ifpga.h
@@ -13,7 +13,7 @@ 
 
 #ifdef __cplusplus
 extern "C" {
-#endif
+#endif /* __cplusplus */
 
 #include <rte_bus.h>
 #include <rte_pci.h>
@@ -143,4 +143,8 @@  struct rte_afu_driver {
 #define RTE_PMD_REGISTER_AFU_ALIAS(nm, alias)\
 static const char *afudrvinit_ ## nm ## _alias = RTE_STR(alias)
 
+#ifdef __cplusplus
+}
+#endif /* __cplusplus */
+
 #endif /* _RTE_BUS_IFPGA_H_ */