crypto/aesni_mb: fix compile

Message ID 20190116132114.65674-1-roy.fan.zhang@intel.com
State Superseded, archived
Delegated to: akhil goyal
Headers show
Series
  • crypto/aesni_mb: fix compile
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Zhang, Roy Fan Jan. 16, 2019, 1:21 p.m.
This patch fixes the inflexible compile issue AESNI-MB PMD.
Originally the compile of the PMD will fail if IPSec_MB is
not installed in default location.

Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/aesni_mb/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

De Lara Guarch, Pablo Jan. 16, 2019, 4:48 p.m. | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang
> Sent: Wednesday, January 16, 2019 1:21 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com
> Subject: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile
> 
> This patch fixes the inflexible compile issue AESNI-MB PMD.
> Originally the compile of the PMD will fail if IPSec_MB is not installed in
> default location.
> 
> Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent
> macros")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Thomas Monjalon Jan. 17, 2019, 10:26 p.m. | #2
16/01/2019 14:21, Fan Zhang:
> This patch fixes the inflexible compile issue AESNI-MB PMD.
> Originally the compile of the PMD will fail if IPSec_MB is
> not installed in default location.
> 
> Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> -IMB_HDR = /usr/include/intel-ipsec-mb.h
> +IMB_HDR = $(shell echo "\#include <intel-ipsec-mb.h>" | \

What is the backslash? Looks like a typo.

> +	$(CC) -E $(EXTRA_CFLAGS) - | grep 'intel-ipsec-mb.h' | \
> +	head -1 | cut -d'"' -f2)

I think the most standard invocation of head is "head -n1".
You can also use "sed 1q".
Ananyev, Konstantin Jan. 18, 2019, 10:57 a.m. | #3
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, January 17, 2019 10:27 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile
> 
> 16/01/2019 14:21, Fan Zhang:
> > This patch fixes the inflexible compile issue AESNI-MB PMD.
> > Originally the compile of the PMD will fail if IPSec_MB is
> > not installed in default location.
> >
> > Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> > -IMB_HDR = /usr/include/intel-ipsec-mb.h
> > +IMB_HDR = $(shell echo "\#include <intel-ipsec-mb.h>" | \
> 
> What is the backslash? Looks like a typo.

Wouldn't make get confused without it?
Konstantin

> 
> > +	$(CC) -E $(EXTRA_CFLAGS) - | grep 'intel-ipsec-mb.h' | \
> > +	head -1 | cut -d'"' -f2)
> 
> I think the most standard invocation of head is "head -n1".
> You can also use "sed 1q".
>
Thomas Monjalon Jan. 18, 2019, 11:03 a.m. | #4
18/01/2019 11:57, Ananyev, Konstantin:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > 16/01/2019 14:21, Fan Zhang:
> > > This patch fixes the inflexible compile issue AESNI-MB PMD.
> > > Originally the compile of the PMD will fail if IPSec_MB is
> > > not installed in default location.
> > >
> > > Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")
> > >
> > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > ---
> > > -IMB_HDR = /usr/include/intel-ipsec-mb.h
> > > +IMB_HDR = $(shell echo "\#include <intel-ipsec-mb.h>" | \
> > 
> > What is the backslash? Looks like a typo.
> 
> Wouldn't make get confused without it?

Confused about what?
I tested without backslash, it works.
Ananyev, Konstantin Jan. 18, 2019, 11:55 a.m. | #5
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, January 18, 2019 11:03 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org; akhil.goyal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile
> 
> 18/01/2019 11:57, Ananyev, Konstantin:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > > 16/01/2019 14:21, Fan Zhang:
> > > > This patch fixes the inflexible compile issue AESNI-MB PMD.
> > > > Originally the compile of the PMD will fail if IPSec_MB is
> > > > not installed in default location.
> > > >
> > > > Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros")
> > > >
> > > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > ---
> > > > -IMB_HDR = /usr/include/intel-ipsec-mb.h
> > > > +IMB_HDR = $(shell echo "\#include <intel-ipsec-mb.h>" | \
> > >
> > > What is the backslash? Looks like a typo.
> >
> > Wouldn't make get confused without it?
> 
> Confused about what?

My guess was - about '#'.

> I tested without backslash, it works.

Then I was wrong with my guess.
Konstantin
Zhang, Roy Fan Jan. 21, 2019, 10:08 a.m. | #6
Hi, 

Thanks guys. I will send a v2 to remove the backslash.

Regards,
Fan

> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Friday, January 18, 2019 11:56 AM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org;
> akhil.goyal@nxp.com; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Friday, January 18, 2019 11:03 AM
> > To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org;
> > akhil.goyal@nxp.com; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile
> >
> > 18/01/2019 11:57, Ananyev, Konstantin:
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas
> Monjalon
> > > > 16/01/2019 14:21, Fan Zhang:
> > > > > This patch fixes the inflexible compile issue AESNI-MB PMD.
> > > > > Originally the compile of the PMD will fail if IPSec_MB is not
> > > > > installed in default location.
> > > > >
> > > > > Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture
> > > > > independent macros")
> > > > >
> > > > > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > > ---
> > > > > -IMB_HDR = /usr/include/intel-ipsec-mb.h
> > > > > +IMB_HDR = $(shell echo "\#include <intel-ipsec-mb.h>" | \
> > > >
> > > > What is the backslash? Looks like a typo.
> > >
> > > Wouldn't make get confused without it?
> >
> > Confused about what?
> 
> My guess was - about '#'.
> 
> > I tested without backslash, it works.
> 
> Then I was wrong with my guess.
> Konstantin

Patch

diff --git a/drivers/crypto/aesni_mb/Makefile b/drivers/crypto/aesni_mb/Makefile
index 7ef290dc5..1aae64a3c 100644
--- a/drivers/crypto/aesni_mb/Makefile
+++ b/drivers/crypto/aesni_mb/Makefile
@@ -23,7 +23,9 @@  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_cryptodev
 LDLIBS += -lrte_bus_vdev
 
-IMB_HDR = /usr/include/intel-ipsec-mb.h
+IMB_HDR = $(shell echo "\#include <intel-ipsec-mb.h>" | \
+	$(CC) -E $(EXTRA_CFLAGS) - | grep 'intel-ipsec-mb.h' | \
+	head -1 | cut -d'"' -f2)
 
 # Detect library version
 IMB_VERSION = $(shell grep -e "IMB_VERSION_STR" $(IMB_HDR) | cut -d'"' -f2)