From patchwork Wed Jan 16 09:43:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 49876 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C592E1041; Wed, 16 Jan 2019 10:43:33 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id A15FD271; Wed, 16 Jan 2019 10:43:32 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 28127800065; Wed, 16 Jan 2019 09:43:31 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 16 Jan 2019 01:43:28 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Wed, 16 Jan 2019 01:43:27 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x0G9hQ8w002979; Wed, 16 Jan 2019 09:43:26 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id A618B1616EF; Wed, 16 Jan 2019 09:43:26 +0000 (GMT) From: Andrew Rybchenko To: CC: Date: Wed, 16 Jan 2019 09:43:23 +0000 Message-ID: <1547631803-11272-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24366.000 X-TM-AS-Result: No-2.276500-4.000000-10 X-TMASE-MatchedRID: l/UQXx1QIoHORQksOkL7v63GlV8ATaXvXeyujb7aXgRnHS56ALb5lFk/ EVZFlSouZRLO2suozNI486vsentZ7wC85WcPW0yXngIgpj8eDcAZ1CdBJOsoY8RB0bsfrpPInxM yeYT53RlskFF9Kex+TriuMhikFV+McMjD1PFXKW1ujCLZHoJzMc9qaax7vVx4/2Rde47UAYkWrW qNYjJbCsxyuPnHlAu+u210gxVcwBqTdSRXlCnjBIjjlF305EnAWUm8SESyzd+8353hqEyjk8PIN hwTXBeZ X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-2.276500-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24366.000 X-MDID: 1547631811-4f1_E-iaYoev Subject: [dpdk-dev] [PATCH] net/sfc: fix VF error/missed stats mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" VADAPTER_RX_OVERFLOW means Rx statistics overflow, not a missed packet because of overflow. VADAPTER_RX_BAD_PACKETS accumulates a number of error conditions, but mainly impossibility to deliver because of no descriptors available, so it is better to classify it as imissed. Fixes: 1caab2f1e684 ("net/sfc: add basic statistics") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 3886daf7a..9f59c8db9 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -537,8 +537,7 @@ sfc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) mac_stats[EFX_MAC_VADAPTER_TX_UNICAST_BYTES] + mac_stats[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES] + mac_stats[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES]; - stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_OVERFLOW]; - stats->ierrors = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS]; + stats->imissed = mac_stats[EFX_MAC_VADAPTER_RX_BAD_PACKETS]; stats->oerrors = mac_stats[EFX_MAC_VADAPTER_TX_BAD_PACKETS]; } else { stats->ipackets = mac_stats[EFX_MAC_RX_PKTS];