[DPDK,v4] raw/ifpga: fix a typo and delete code of unused function

Message ID 1547530680-423006-1-git-send-email-andy.pei@intel.com
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [DPDK,v4] raw/ifpga: fix a typo and delete code of unused function
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Andy Pei Jan. 15, 2019, 5:38 a.m.
fix a typo and delete code of unused function

Fixes: 88c9eb7cb4b5 (\"fix a typo and delete code of unused function\")
Cc: andy.pei@intel.com
Cc: rosen.xu@intel.com
Cc: tianfei.zhang@intel.com

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/raw/ifpga_rawdev/base/opae_hw_api.c | 24 +-----------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

Comments

Rosen Xu Jan. 16, 2019, 11:26 a.m. | #1
Hi,

Pls don't use fixline if your patch code doesn't merged in community.

> -----Original Message-----
> From: Pei, Andy
> Sent: Tuesday, January 15, 2019 13:38
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Pei, Andy <andy.pei@intel.com>
> Subject: [DPDK] [PATCH v4] raw/ifpga: fix a typo and delete code of unused
> function
> 
> fix a typo and delete code of unused function
> 
> Fixes: 88c9eb7cb4b5 (\"fix a typo and delete code of unused function\")
> Cc: andy.pei@intel.com
> Cc: rosen.xu@intel.com
> Cc: tianfei.zhang@intel.com
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/raw/ifpga_rawdev/base/opae_hw_api.c | 24 +-----------------------
>  1 file changed, 1 insertion(+), 23 deletions(-)
> 
> diff --git a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> index 50f6438..ea42757 100644
> --- a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> +++ b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
> @@ -304,7 +304,7 @@ static struct opae_adapter_ops *match_ops(struct
> opae_adapter *adapter)
> 
>  /**
>   * opae_adapter_init - init opae_adapter data structure
> - * @adpdate: pointer of opae_adater data structure
> + * @adapter: pointer of opae_adater data structure
>   * @name: adapter name.
>   * @data: private data of this adapter.
>   *
> @@ -325,28 +325,6 @@ int opae_adapter_init(struct opae_adapter
> *adapter,  }
> 
>  /**
> - * opae_adapter_alloc - alloc opae_adapter data structure
> - * @name: adapter name.
> - * @data: private data of this adapter.
> - *
> - * Return: opae_adapter on success, otherwise NULL.
> - */
> - /**This function will no longer be called.
> -struct opae_adapter *opae_adapter_alloc(const char *name, void *data) -{
> -	struct opae_adapter *adapter = opae_zmalloc(sizeof(*adapter));
> -
> -	if (!adapter)
> -		return NULL;
> -
> -	if (opae_adapter_init(adapter, name, data))
> -		return NULL;
> -
> -	return adapter;
> -}
> -**/
> -
> -/**
>   * opae_adapter_enumerate - enumerate this adapter
>   * @adapter: adapter to enumerate.
>   *
> --
> 1.8.3.1

Patch

diff --git a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
index 50f6438..ea42757 100644
--- a/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
+++ b/drivers/raw/ifpga_rawdev/base/opae_hw_api.c
@@ -304,7 +304,7 @@  static struct opae_adapter_ops *match_ops(struct opae_adapter *adapter)
 
 /**
  * opae_adapter_init - init opae_adapter data structure
- * @adpdate: pointer of opae_adater data structure
+ * @adapter: pointer of opae_adater data structure
  * @name: adapter name.
  * @data: private data of this adapter.
  *
@@ -325,28 +325,6 @@  int opae_adapter_init(struct opae_adapter *adapter,
 }
 
 /**
- * opae_adapter_alloc - alloc opae_adapter data structure
- * @name: adapter name.
- * @data: private data of this adapter.
- *
- * Return: opae_adapter on success, otherwise NULL.
- */
- /**This function will no longer be called.
-struct opae_adapter *opae_adapter_alloc(const char *name, void *data)
-{
-	struct opae_adapter *adapter = opae_zmalloc(sizeof(*adapter));
-
-	if (!adapter)
-		return NULL;
-
-	if (opae_adapter_init(adapter, name, data))
-		return NULL;
-
-	return adapter;
-}
-**/
-
-/**
  * opae_adapter_enumerate - enumerate this adapter
  * @adapter: adapter to enumerate.
  *