From patchwork Fri Jan 11 11:58:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 49686 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 423CD1BA85; Fri, 11 Jan 2019 12:58:19 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140074.outbound.protection.outlook.com [40.107.14.74]) by dpdk.org (Postfix) with ESMTP id 387881B9F7 for ; Fri, 11 Jan 2019 12:58:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJ7YG24b+2Ze8JACRCDpwNnDrKbqx2gzNABKrH83naM=; b=HgBLExIYImoGjfl3ccjgSVFwVIa1D+PJk6bq6h0fPSFt78LOmTvy30yQeHme//qZ1JyxEZT2nGo/Sqg2K53ruaRwpxan/wjtME8iWio+3cpuW1TSX3dWzIIQFyJ2JK86o+upxYGk14uRTKCo5vO7T++EMzr7B/L7lm7QvRS6OUw= Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by VI1PR04MB2109.eurprd04.prod.outlook.com (10.166.43.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Fri, 11 Jan 2019 11:58:16 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::b1eb:7e7e:7b90:7b4]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::b1eb:7e7e:7b90:7b4%4]) with mapi id 15.20.1516.016; Fri, 11 Jan 2019 11:58:16 +0000 From: Shreyansh Jain To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Akhil Goyal Thread-Topic: [PATCH v2 08/20] net/dpaa2: enable optional timestamp in mbuf Thread-Index: AQHUqaTvwPZPYSBEj0G+c8L5d4/mLA== Date: Fri, 11 Jan 2019 11:58:15 +0000 Message-ID: <20190111115712.6482-9-shreyansh.jain@nxp.com> References: <20181227062233.30781-1-hemant.agrawal@nxp.com> <20190111115712.6482-1-shreyansh.jain@nxp.com> In-Reply-To: <20190111115712.6482-1-shreyansh.jain@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.143.254.130] x-mailer: git-send-email 2.17.1 x-clientproxiedby: TY2PR01CA0030.jpnprd01.prod.outlook.com (2603:1096:404:ce::18) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB2109; 6:PGHGB8UX12Cl6byl/2kHXh9E8dxhbIFMWmd4Nd/7hBIxHmQXrDtqeZSU+30E34bNElKr9cde682cQ/jQgeatIGLGbbm1C4jxQ7lqF3WdzskjpDAFvXrKwvaugbpp3LCu57AbSg73iP5lpkjNqj5kWibpb8KoXZhdUQlWlrnLi/OK9goIb+eUNmt1jvY3mW2cFqzuYkkhWSJSEu3D9i8I1l+2yrkvAgx+8kYfKRMql/9ztwGrTgQru+bJX6pWmTogRD6utapixqkxfEIRqgoC328AwrLj6yxwaoIlzTCOpjEHpSjaj22t+QFEjgspUyV4AHKOiin7O5jyTNXNjLYMu1bj/tR2eSL82G0bK4qy19vbaczgRedhAYBimzzdx3+SexmxdYEGRFSQaEeU5CHqpP+CtMn/GCD3ZVDYLbEtq2kMOTcaupHg2b/COeL7fLWSabtoeSoLPJhn/V2oq+JVJQ==; 5:CNC/OpzJbfQBDMMVa7PvG6Hyo/WfJ+AT6gqXgzFc5p+Gx6X7h1cAOSbcAGqlj0Htn5pdRYtAOpz6rltirF375wNZ3pucrOCLXGF4BKfTNukT1GBkb8BowgGrkrZ6NDz3VQvHgYjWJf+jAQNpG4Jw0o2GJqa2n2f7rsJEZQnCwutCoVVJs1wqMHyfRyLclQXuuC+cOtdXlG0UI1y++b4QGw==; 7:S+4eZ0W5Q2oy/xDvThi9wPiItlDJl8rRmN5mZhWwB6WGVmseKqdyot4Py38GlFwl933yXwHPNNK2uyzwZVfeT8mIssFLGV7NUl3ElAyOcoVtI6Xvjt0Tx77Hj+2KqQwk1YcrOn664MEU6oHBGVl3vw== x-ms-office365-filtering-correlation-id: c17dcf0c-e355-44c0-d579-08d677bc11c7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR04MB2109; x-ms-traffictypediagnostic: VI1PR04MB2109: x-microsoft-antispam-prvs: x-forefront-prvs: 09144DB0F7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(136003)(396003)(376002)(39860400002)(189003)(199004)(99286004)(2501003)(78486014)(6512007)(26005)(316002)(68736007)(186003)(25786009)(36756003)(478600001)(305945005)(14454004)(71200400001)(6916009)(6486002)(71190400001)(2351001)(6436002)(81156014)(81166006)(1730700003)(52116002)(53936002)(76176011)(1076003)(14444005)(256004)(105586002)(8936002)(476003)(54906003)(5640700003)(7736002)(2616005)(106356001)(50226002)(3846002)(6116002)(55236004)(386003)(2906002)(6506007)(5024004)(11346002)(102836004)(86362001)(446003)(486006)(97736004)(44832011)(5660300001)(8676002)(4326008)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB2109; H:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: p3VTpV25yycG9eNZDJAlx7ePlXEKUzYoBcSv3dEjMtLxjFAdwcecTkd43V1UbJd74x6SH6UZZRJUzIl9OLbqBxuhi+74d7O2QJ+z5l1R5Om6Z03MnT4SC368qMw44xCDULsyvTBO/l0IBQpY3Buz7nWt9fBsStyPvcfjEr2G50H8jJ/QxobBRSKHm6aauErx4q4qHOSWYXIJQmLHjLHkEcQuUJV5CX3V8SkXuHhE5Z/777NnpJJPYOKDPFPsJKrlR5oxPNnsvNaPm0NIaFFowTu91E9QtU7OD+uyEVuqAIYjCU8Nt8IdGWqkxU0v+CS6h32w7RWALVGA0gaiyrW2Pq/cschxuBRIIfCOzw5Zxc7U+z5an9op6xxqp94FR7Fyxpj+bVkqp9Bq0KMqj6La4gfOdCNbHTGMH8Jph+UtPOw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c17dcf0c-e355-44c0-d579-08d677bc11c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2019 11:58:13.2343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2109 Subject: [dpdk-dev] [PATCH v2 08/20] net/dpaa2: enable optional timestamp in mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Akhil Goyal This patch enables the population of timestamp field in mbuf on packet receive. It may give performance impact on LX2xxx platforms. So, it has been made optional for Lx2xxx platform. One shall call, rte_dpaa2_enable_ts() to enable it. Nothing is required for LS2 and LS1088 platforms. Signed-off-by: Akhil Goyal --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + drivers/net/dpaa2/Makefile | 2 ++ drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 2 ++ drivers/net/dpaa2/dpaa2_ethdev.c | 9 +++++ drivers/net/dpaa2/dpaa2_ethdev.h | 4 +++ drivers/net/dpaa2/dpaa2_rxtx.c | 18 ++++++++++ drivers/net/dpaa2/meson.build | 2 ++ drivers/net/dpaa2/rte_pmd_dpaa2.h | 39 +++++++++++++++++++++ drivers/net/dpaa2/rte_pmd_dpaa2_version.map | 6 ++++ 10 files changed, 84 insertions(+) create mode 100644 drivers/net/dpaa2/rte_pmd_dpaa2.h diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.md index e27874c5a..d95ad566c 100644 --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md @@ -43,6 +43,7 @@ The public API headers are grouped by topics: [i40e] (@ref rte_pmd_i40e.h), [bnxt] (@ref rte_pmd_bnxt.h), [dpaa] (@ref rte_pmd_dpaa.h), + [dpaa2] (@ref rte_pmd_dpaa2.h), [dpaa2_mempool] (@ref rte_dpaa2_mempool.h), [dpaa2_cmdif] (@ref rte_pmd_dpaa2_cmdif.h), [dpaa2_qdma] (@ref rte_pmd_dpaa2_qdma.h), diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in index 77ba327a8..bef9320c0 100644 --- a/doc/api/doxy-api.conf.in +++ b/doc/api/doxy-api.conf.in @@ -9,6 +9,7 @@ INPUT = @TOPDIR@/doc/api/doxy-api-index.md \ @TOPDIR@/drivers/net/bnxt \ @TOPDIR@/drivers/net/bonding \ @TOPDIR@/drivers/net/dpaa \ + @TOPDIR@/drivers/net/dpaa2 \ @TOPDIR@/drivers/net/i40e \ @TOPDIR@/drivers/net/ixgbe \ @TOPDIR@/drivers/net/softnic \ diff --git a/drivers/net/dpaa2/Makefile b/drivers/net/dpaa2/Makefile index ca5f7a336..2b9c011d6 100644 --- a/drivers/net/dpaa2/Makefile +++ b/drivers/net/dpaa2/Makefile @@ -42,4 +42,6 @@ LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_common_dpaax +# install this header file +SYMLINK-$(CONFIG_RTE_LIBRTE_DPAA2_PMD)-include := rte_pmd_dpaa2.h include $(RTE_SDK)/mk/rte.lib.mk diff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c index 713a41bf3..a6f86df8c 100644 --- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c +++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c @@ -296,8 +296,10 @@ dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv, DPNI_BUF_LAYOUT_OPT_FRAME_STATUS | DPNI_BUF_LAYOUT_OPT_PARSER_RESULT | DPNI_BUF_LAYOUT_OPT_DATA_ALIGN | + DPNI_BUF_LAYOUT_OPT_TIMESTAMP | DPNI_BUF_LAYOUT_OPT_PRIVATE_DATA_SIZE; + layout.pass_timestamp = true; layout.pass_frame_status = 1; layout.private_data_size = DPAA2_FD_PTA_SIZE; layout.pass_parser_result = 1; diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 39f85ae7b..861fbcd90 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -56,6 +56,9 @@ static uint64_t dev_tx_offloads_nodis = DEV_TX_OFFLOAD_MT_LOCKFREE | DEV_TX_OFFLOAD_MBUF_FAST_FREE; +/* enable timestamp in mbuf */ +enum pmd_dpaa2_ts dpaa2_enable_ts; + struct rte_dpaa2_xstats_name_off { char name[RTE_ETH_XSTATS_NAME_SIZE]; uint8_t page_id; /* dpni statistics page id */ @@ -88,6 +91,12 @@ static int dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); int dpaa2_logtype_pmd; +__rte_experimental void +rte_pmd_dpaa2_set_timestamp(enum pmd_dpaa2_ts enable) +{ + dpaa2_enable_ts = enable; +} + static int dpaa2_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) { diff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h index bd69f523d..7cf6e4191 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.h +++ b/drivers/net/dpaa2/dpaa2_ethdev.h @@ -9,6 +9,7 @@ #define _DPAA2_ETHDEV_H #include +#include #include #include @@ -83,6 +84,9 @@ #define DPAA2_PKT_TYPE_VLAN_1 0x0160 #define DPAA2_PKT_TYPE_VLAN_2 0x0260 +/* enable timestamp in mbuf*/ +extern enum pmd_dpaa2_ts dpaa2_enable_ts; + struct dpaa2_dev_priv { void *hw; int32_t hw_id; diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c index eab943dcf..816ea00fd 100644 --- a/drivers/net/dpaa2/dpaa2_rxtx.c +++ b/drivers/net/dpaa2/dpaa2_rxtx.c @@ -42,6 +42,7 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf, static inline void __attribute__((hot)) dpaa2_dev_rx_parse_new(struct rte_mbuf *m, const struct qbman_fd *fd) { + struct dpaa2_annot_hdr *annotation; uint16_t frc = DPAA2_GET_FD_FRC_PARSE_SUM(fd); m->packet_type = RTE_PTYPE_UNKNOWN; @@ -104,6 +105,19 @@ dpaa2_dev_rx_parse_new(struct rte_mbuf *m, const struct qbman_fd *fd) } m->hash.rss = fd->simple.flc_hi; m->ol_flags |= PKT_RX_RSS_HASH; + + if (dpaa2_enable_ts == PMD_DPAA2_ENABLE_TS) { + annotation = (struct dpaa2_annot_hdr *) + ((size_t)DPAA2_IOVA_TO_VADDR( + DPAA2_GET_FD_ADDR(fd)) + DPAA2_FD_PTA_SIZE); + m->timestamp = annotation->word2; + m->ol_flags |= PKT_RX_TIMESTAMP; + DPAA2_PMD_DP_DEBUG("pkt timestamp:0x%" PRIx64 "", m->timestamp); + } + + DPAA2_PMD_DP_DEBUG("HW frc = 0x%x\t packet type =0x%x " + "ol_flags =0x%" PRIx64 "", + frc, m->packet_type, m->ol_flags); } static inline uint32_t __attribute__((hot)) @@ -205,6 +219,10 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr) else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE)) mbuf->ol_flags |= PKT_RX_L4_CKSUM_BAD; + mbuf->ol_flags |= PKT_RX_TIMESTAMP; + mbuf->timestamp = annotation->word2; + DPAA2_PMD_DP_DEBUG("pkt timestamp: 0x%" PRIx64 "", mbuf->timestamp); + /* Check detailed parsing requirement */ if (annotation->word3 & 0x7FFFFC3FFFF) return dpaa2_dev_rx_parse_slow(mbuf, annotation); diff --git a/drivers/net/dpaa2/meson.build b/drivers/net/dpaa2/meson.build index b34595258..07aada87c 100644 --- a/drivers/net/dpaa2/meson.build +++ b/drivers/net/dpaa2/meson.build @@ -18,3 +18,5 @@ includes += include_directories('base', 'mc') # depends on fslmc bus which uses experimental API allow_experimental_apis = true + +install_headers('rte_pmd_dpaa2.h') diff --git a/drivers/net/dpaa2/rte_pmd_dpaa2.h b/drivers/net/dpaa2/rte_pmd_dpaa2.h new file mode 100644 index 000000000..f9303acad --- /dev/null +++ b/drivers/net/dpaa2/rte_pmd_dpaa2.h @@ -0,0 +1,39 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright 2018 NXP + */ + +#ifndef _RTE_PMD_DPAA2_H +#define _RTE_PMD_DPAA2_H + +/** + * @file rte_pmd_dpaa2.h + * + * NXP dpaa2 PMD specific functions. + * + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * + */ + +#include + +enum pmd_dpaa2_ts { + PMD_DPAA2_DISABLE_TS, + PMD_DPAA2_ENABLE_TS +}; + +/** + * @warning + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice + * + * Enable/Disable timestamping update in mbuf for LX2160 kind of devices. + * For LS2088/LS1088 devices, timestamping will be updated in mbuf without + * calling this API. + * + * @param pmd_dpaa2_ts + * Enum to enable/disable timestamp update in mbuf for LX2160 devices. + */ +__rte_experimental +void rte_pmd_dpaa2_set_timestamp(enum pmd_dpaa2_ts); + +#endif /* _RTE_PMD_DPAA2_H */ diff --git a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map index 09f4364bc..de95a03cd 100644 --- a/drivers/net/dpaa2/rte_pmd_dpaa2_version.map +++ b/drivers/net/dpaa2/rte_pmd_dpaa2_version.map @@ -10,3 +10,9 @@ DPDK_17.11 { dpaa2_eth_eventq_detach; } DPDK_17.05; + +EXPERIMENTAL { + global: + + rte_pmd_dpaa2_set_timestamp; +} DPDK_17.11;