vhost_user: remove statement for non-existed function

Message ID 20190111080541.96774-1-xiaolong.ye@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Maxime Coquelin
Headers
Series vhost_user: remove statement for non-existed function |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Xiaolong Ye Jan. 11, 2019, 8:05 a.m. UTC
  vhost_user_host_notifier_ctrl is not existed anymore, its statement in
header file should be removed accordingly.

Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
Cc: xiao.w.wang@intel.com
Cc: stable@dpdk.org

Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
---
 lib/librte_vhost/vhost_user.h | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Tiwei Bie Jan. 11, 2019, 1:31 p.m. UTC | #1
> vhost_user: remove statement for non-existed function

s/vhost_user/vhost/

On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote:
> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
> header file should be removed accordingly.
> 
> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
> Cc: xiao.w.wang@intel.com
> Cc: stable@dpdk.org

There is no need to cc stable, because above commit is part
of 19.02 which hasn't been released yet.

For the rest,
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

> 
> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
> ---
>  lib/librte_vhost/vhost_user.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
> index dc97be843..2a650fe4b 100644
> --- a/lib/librte_vhost/vhost_user.h
> +++ b/lib/librte_vhost/vhost_user.h
> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
>  /* vhost_user.c */
>  int vhost_user_msg_handler(int vid, int fd);
>  int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
> -int vhost_user_host_notifier_ctrl(int vid, bool enable);
>  
>  /* socket.c */
>  int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
> -- 
> 2.17.1
>
  
Xiaolong Ye Jan. 12, 2019, 1:01 a.m. UTC | #2
On 01/11, Tiwei Bie wrote:
>> vhost_user: remove statement for non-existed function
>
>s/vhost_user/vhost/
>
>On Fri, Jan 11, 2019 at 04:05:41PM +0800, Xiaolong Ye wrote:
>> vhost_user_host_notifier_ctrl is not existed anymore, its statement in
>> header file should be removed accordingly.
>> 
>> Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl")
>> Cc: xiao.w.wang@intel.com
>> Cc: stable@dpdk.org
>
>There is no need to cc stable, because above commit is part
>of 19.02 which hasn't been released yet.
>
>For the rest,
>Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks for the review.
In this kind of case, I suppose there is no need to reroll the patch, right?

Thanks,
Xiaolong

>
>> 
>> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> ---
>>  lib/librte_vhost/vhost_user.h | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
>> index dc97be843..2a650fe4b 100644
>> --- a/lib/librte_vhost/vhost_user.h
>> +++ b/lib/librte_vhost/vhost_user.h
>> @@ -148,7 +148,6 @@ typedef struct VhostUserMsg {
>>  /* vhost_user.c */
>>  int vhost_user_msg_handler(int vid, int fd);
>>  int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
>> -int vhost_user_host_notifier_ctrl(int vid, bool enable);
>>  
>>  /* socket.c */
>>  int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,
>> -- 
>> 2.17.1
>>
  

Patch

diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h
index dc97be843..2a650fe4b 100644
--- a/lib/librte_vhost/vhost_user.h
+++ b/lib/librte_vhost/vhost_user.h
@@ -148,7 +148,6 @@  typedef struct VhostUserMsg {
 /* vhost_user.c */
 int vhost_user_msg_handler(int vid, int fd);
 int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm);
-int vhost_user_host_notifier_ctrl(int vid, bool enable);
 
 /* socket.c */
 int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds,