From patchwork Wed Jan 9 14:50:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 49546 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BEA761B53E; Wed, 9 Jan 2019 15:50:36 +0100 (CET) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 1F4871B4A6 for ; Wed, 9 Jan 2019 15:50:36 +0100 (CET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190109145035euoutp024594be5f43ada3854a6a00fe182037cc~4NaCf7jgX1813018130euoutp02i for ; Wed, 9 Jan 2019 14:50:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190109145035euoutp024594be5f43ada3854a6a00fe182037cc~4NaCf7jgX1813018130euoutp02i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1547045436; bh=O8HAL1CjeaeTqFl4UcftYR9Ke98ArQ0qrAfISJLVLwY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rjOJsVOlfOB1J3DfZ7rMEdhkV26OmrMhzt8ccwNRDdgD0DfK5WeCMMektGA+7Qcia dbo+spnMjaIG/tHF7/NiSDgysmMsSg6Ptg38YHb4+oziVnQQA9uGbuexRvnM5zBRTI 6QVJQ5jdhOWXSaLesmJQ2RS3Knl4NAlNZxLHXRDA= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190109145035eucas1p1c6fb89dbd5c02e31d933c78e705c69d7~4NaCIpoCb2852328523eucas1p1I; Wed, 9 Jan 2019 14:50:35 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id B8.40.04806.B3A063C5; Wed, 9 Jan 2019 14:50:35 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190109145034eucas1p2183e275e316b87917b96fa184fc7d7cb~4NaBc_xUD1577015770eucas1p2q; Wed, 9 Jan 2019 14:50:34 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190109145034eusmtrp107344abdf3f4ce3451a4b533bc1ec677~4NaBNtCED0367503675eusmtrp1C; Wed, 9 Jan 2019 14:50:34 +0000 (GMT) X-AuditID: cbfec7f5-34dff700000012c6-da-5c360a3b8dd9 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 13.80.04284.A3A063C5; Wed, 9 Jan 2019 14:50:34 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190109145033eusmtip2247ae9e9f359908279fcc5e7423b553d~4NaAP9u1z2020620206eusmtip24; Wed, 9 Jan 2019 14:50:33 +0000 (GMT) From: Ilya Maximets To: dev@dpdk.org, Maxime Coquelin , "Michael S . Tsirkin" , Xiao Wang Cc: Tiwei Bie , Zhihong Wang , jfreimann@redhat.com, Jason Wang , xiaolong.ye@intel.com, alejandro.lucero@netronome.com, Ilya Maximets Date: Wed, 9 Jan 2019 17:50:14 +0300 Message-Id: <20190109145015.3010-3-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190109145015.3010-1-i.maximets@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42LZduzneV1rLrMYgwmNohbnPi1jsnj3aTuT xZX2n+wWyy59ZrI4t2Ypi8Wxzj0sFv9/vWK12Nrwn8li//PD7BZ/3phabL44icmB2+PXgqWs Hov3vGTymN79kNnj/b6rbB59W1YxBrBGcdmkpOZklqUW6dslcGWs2/WJqWAdR8XNXbeZGhg/ sHUxcnJICJhILLjygaWLkYtDSGAFo8Snr38ZIZwvjBJ9J3axglQJCXxmlNj7MhOm48erHVAd yxkljr56zgxR9INR4vKhVBCbTUBH4tTqI2CTRAS6GSVePf3MBuIwCzxnlHjx5R47SJWwQJDE +qmrwLpZBFQl7r/dCHYUr4CVxMKjExkh1slLrN5wAKyGU8BaYtmrGWCDJAT62SWuT13EAlHk IvFx+XsoW1ji1fEt7BC2jMTpyT1Q8XqJ+y0vGSGaOxglph/6xwSRsJfY8vocUAMH0HmaEut3 6UOEHSXuPD3JBhKWEOCTuPFWECTMDGRO2jadGSLMK9HRJgRRrSLx++ByZghbSuLmu8/sECUe EmsP8ULC5wCjxL537hMY5WchrFrAyLiKUTy1tDg3PbXYOC+1XK84Mbe4NC9dLzk/dxMjMJWc /nf86w7GfX+SDjEKcDAq8fAm/DONEWJNLCuuzD3EKMHBrCTCq37HJEaINyWxsiq1KD++qDQn tfgQozQHi5I4bzXDg2ghgfTEktTs1NSC1CKYLBMHp1QDo/bJUMufHBOSn31Xft1q/F39lqBd 6N3Pz2Jnvr2zx9L3yOaWyVcZ/kw+q5imcOuiu7GR9Xbxe6euB/ZJPvESfzBlt1y/27bDb+b/ tT9psOXTl2X8U3IL5jcI3k/mW88bxvxF3oKl+bNl4q+dEcq3/aqLN4SZ9y5bKa2092xjQHTb oRLjqJCLd5RYijMSDbWYi4oTAeKoWQIhAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xe7pWXGYxBjNmKlic+7SMyeLdp+1M Flfaf7JbLLv0mcni3JqlLBbHOvewWPz/9YrVYmvDfyaL/c8Ps1v8eWNqsfniJCYHbo9fC5ay eize85LJY3r3Q2aP9/uusnn0bVnFGMAapWdTlF9akqqQkV9cYqsUbWhhpGdoaaFnZGKpZ2hs HmtlZKqkb2eTkpqTWZZapG+XoJexbtcnpoJ1HBU3d91mamD8wNbFyMkhIWAi8ePVDpYuRi4O IYGljBJfLu9nhEhISfz4dYEVwhaW+HOtiw2i6BujxN8bvWAJNgEdiVOrjzCCJEQE+hkldl+/ yQziMAu8ZZTom3SDHaRKWCBAYvKrfcwgNouAqsT9txvBdvMKWEksPDoRap28xOoNB8BqOAWs JZa9mgFWIySQI3Hoy1b2CYx8CxgZVjGKpJYW56bnFhvqFSfmFpfmpesl5+duYgQG+LZjPzfv YLy0MfgQowAHoxIPb8I/0xgh1sSy4srcQ4wSHMxKIrzqd0xihHhTEiurUovy44tKc1KLDzGa Ah01kVlKNDkfGH15JfGGpobmFpaG5sbmxmYWSuK85w0qo4QE0hNLUrNTUwtSi2D6mDg4pRoY JZeWnr37/4nfJu1vx5O92LsvVxcLfXpaVqmR+kpk/kLjsouKrwLflaT480fZzV6VJ254JEze 6u96De/PJz7KGVfOE7GS/LFs5TXBtw+XJ5f0ztxWOe8Jh/fGf/abbhe3zF58zH+72USZdx6d 8zZfV16+Ld5E6YrTFS6n9xoXuTX64+9PkZm6QImlOCPRUIu5qDgRAIfL78CGAgAA X-CMS-MailID: 20190109145034eucas1p2183e275e316b87917b96fa184fc7d7cb X-Msg-Generator: CA X-RootMTR: 20190109145034eucas1p2183e275e316b87917b96fa184fc7d7cb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190109145034eucas1p2183e275e316b87917b96fa184fc7d7cb References: <20181226163712.31596-1-i.maximets@samsung.com> <20190109145015.3010-1-i.maximets@samsung.com> Subject: [dpdk-dev] [PATCH v3 2/3] net/virtio: update memory ordering comment for vq notify X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" We're not using io ports in case of modern device even on IA. Also, this comment useless for other architectures. Signed-off-by: Ilya Maximets Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtqueue.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index dffa03669..53aeac238 100644 --- a/drivers/net/virtio/virtqueue.h +++ b/drivers/net/virtio/virtqueue.h @@ -437,14 +437,13 @@ virtqueue_kick_prepare_packed(struct virtqueue *vq) return flags != RING_EVENT_FLAGS_DISABLE; } +/* + * virtqueue_kick_prepare*() or the virtio_wmb() should be called + * before this function to be sure that all the data is visible to vhost. + */ static inline void virtqueue_notify(struct virtqueue *vq) { - /* - * Ensure updated avail->idx is visible to host. - * For virtio on IA, the notificaiton is through io port operation - * which is a serialization instruction itself. - */ VTPCI_OPS(vq->hw)->notify_queue(vq->hw, vq); }