[v4,07/10] net/ifc: add devarg for LM mode
Checks
Commit Message
This patch series enables a new method for live migration, i.e. software
assisted live migration. This patch provides a device argument for user
to choose the methold.
When "swlm=1", driver/device will do live migration with a relay thread
dealing with dirty page logging. Without this parameter, device will do
dirty page logging and there's no relay thread consuming CPU resource.
Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
---
drivers/net/ifc/ifcvf_vdpa.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
Comments
On 12/14/18 10:16 PM, Xiao Wang wrote:
> This patch series enables a new method for live migration, i.e. software
> assisted live migration. This patch provides a device argument for user
> to choose the methold.
>
> When "swlm=1", driver/device will do live migration with a relay thread
> dealing with dirty page logging. Without this parameter, device will do
> dirty page logging and there's no relay thread consuming CPU resource.
>
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
> drivers/net/ifc/ifcvf_vdpa.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
> index c0e50354a..395c5112f 100644
> --- a/drivers/net/ifc/ifcvf_vdpa.c
> +++ b/drivers/net/ifc/ifcvf_vdpa.c
> @@ -8,6 +8,7 @@
> #include <sys/ioctl.h>
> #include <sys/epoll.h>
> #include <linux/virtio_net.h>
> +#include <stdbool.h>
>
> #include <rte_malloc.h>
> #include <rte_memory.h>
> @@ -31,9 +32,11 @@
> #endif
>
> #define IFCVF_VDPA_MODE "vdpa"
> +#define IFCVF_SW_FALLBACK_LM "swlm"
The patch looks good, except that I don't like the "swlm" name.
Maybe we could have something less obscure, even if a little bt longer?
What about "sw-live-migration"?
Hi Maxime,
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Sunday, December 16, 2018 1:21 AM
> To: Wang, Xiao W <xiao.w.wang@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>
> Cc: alejandro.lucero@netronome.com; dev@dpdk.org; Wang, Zhihong
> <zhihong.wang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Subject: Re: [PATCH v4 07/10] net/ifc: add devarg for LM mode
>
>
>
> On 12/14/18 10:16 PM, Xiao Wang wrote:
> > This patch series enables a new method for live migration, i.e. software
> > assisted live migration. This patch provides a device argument for user
> > to choose the methold.
> >
> > When "swlm=1", driver/device will do live migration with a relay thread
> > dealing with dirty page logging. Without this parameter, device will do
> > dirty page logging and there's no relay thread consuming CPU resource.
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> > ---
> > drivers/net/ifc/ifcvf_vdpa.c | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
> > index c0e50354a..395c5112f 100644
> > --- a/drivers/net/ifc/ifcvf_vdpa.c
> > +++ b/drivers/net/ifc/ifcvf_vdpa.c
> > @@ -8,6 +8,7 @@
> > #include <sys/ioctl.h>
> > #include <sys/epoll.h>
> > #include <linux/virtio_net.h>
> > +#include <stdbool.h>
> >
> > #include <rte_malloc.h>
> > #include <rte_memory.h>
> > @@ -31,9 +32,11 @@
> > #endif
> >
> > #define IFCVF_VDPA_MODE "vdpa"
> > +#define IFCVF_SW_FALLBACK_LM "swlm"
>
>
> The patch looks good, except that I don't like the "swlm" name.
> Maybe we could have something less obscure, even if a little bt longer?
>
> What about "sw-live-migration"?
Agree with you, making it clear is more reader-friendly than a short name.
Thanks,
Xiao
@@ -8,6 +8,7 @@
#include <sys/ioctl.h>
#include <sys/epoll.h>
#include <linux/virtio_net.h>
+#include <stdbool.h>
#include <rte_malloc.h>
#include <rte_memory.h>
@@ -31,9 +32,11 @@
#endif
#define IFCVF_VDPA_MODE "vdpa"
+#define IFCVF_SW_FALLBACK_LM "swlm"
static const char * const ifcvf_valid_arguments[] = {
IFCVF_VDPA_MODE,
+ IFCVF_SW_FALLBACK_LM,
NULL
};
@@ -56,6 +59,7 @@ struct ifcvf_internal {
rte_atomic32_t dev_attached;
rte_atomic32_t running;
rte_spinlock_t lock;
+ bool sw_lm;
};
struct internal_list {
@@ -767,6 +771,7 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
struct ifcvf_internal *internal = NULL;
struct internal_list *list = NULL;
int vdpa_mode = 0;
+ int sw_fallback_lm = 0;
struct rte_kvargs *kvlist = NULL;
int ret = 0;
@@ -826,6 +831,14 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
internal->dev_addr.type = PCI_ADDR;
list->internal = internal;
+ if (rte_kvargs_count(kvlist, IFCVF_SW_FALLBACK_LM)) {
+ ret = rte_kvargs_process(kvlist, IFCVF_SW_FALLBACK_LM,
+ &open_int, &sw_fallback_lm);
+ if (ret < 0)
+ goto error;
+ }
+ internal->sw_lm = sw_fallback_lm;
+
internal->did = rte_vdpa_register_device(&internal->dev_addr,
&ifcvf_ops);
if (internal->did < 0) {