From patchwork Fri Dec 14 13:18:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 48863 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C6D71BB71; Fri, 14 Dec 2018 14:19:07 +0100 (CET) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 5DEC81BB43 for ; Fri, 14 Dec 2018 14:19:03 +0100 (CET) Received: by mail-lj1-f194.google.com with SMTP id s5-v6so4846080ljd.12 for ; Fri, 14 Dec 2018 05:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EuyI/XdksgNbjTKERvJ3HMF0JYYHdZo/dr8/e87qIJE=; b=pWqjUWvDwb5yzVHftfijsdMcN9GTMvFbKV4hT96+esYChZ1H6B27Pb6Ay0uuMjV4Rw oFSvkWgiS0BxLXMs6HkhNNCwgO81F17hjqE8xXSzMVFwVfHy/r0ljqEqH3EkP0JzY7Lo mJ5Q/pVl1w71iSPGM0hQysPWW2zLRTq1ohgJb/Qg3sjtlHgWrC5vlpfeZiil2YZg5kc+ D4CFdP3nRpYOoyJN7McXjG7nND8PLZCaMYKEtEPLN6ysz9h2KYkWshjqxECLFZ7QljY2 nS7JcGGbM4tI/SufpIpErVswvi0OkIW9JPGgG2McbypvtVUVB9zXLBiAp6J99p75oWFi lJmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EuyI/XdksgNbjTKERvJ3HMF0JYYHdZo/dr8/e87qIJE=; b=b/N6GpzYS9HzL5tMzo7L+aiRZe7+zVlUK3ECakRBKSZSKqZGsMHOaAh43V5ePqggLb kN/aZcVv9MQ/RVHWu1VwZm6D1pPVlRmzH6uPCFGWRWh+KAQUcxbJoJ+/jgrG+70OGd8w wP47wQ8L6A7uVD0Fv1hJvgpWtQkeRTDZpRnRvdByhURw0Mm4GWZLoBuKpqgB5JcH3QEr IC24q+LSPZ9pBEWWHOtMDmUO0JxJgSrDxHfccJ6it6C7A98OSoW9TOawHULWODZGgOQm yKEMfqeetvL7T8aJdwAwO8UyFylAP/EglpWj6sEtCTLuqv82cZ5VFbKVaIhxt4TD+raO fE1g== X-Gm-Message-State: AA+aEWZy7xw+AlpTmLY5aNHSAjejFqCjdA/f6QbQwwM6JV7gLZYQe12T ixGP3gqW+we35o/KnzMfd1D1gfzaDec= X-Google-Smtp-Source: AFSGD/XM7AvtxjjHnVIhitbQ3qUIj0jshxwlQYEdQ+07nwbmIJoAPspyHMEKCjIZuRn3xWCiVQetnA== X-Received: by 2002:a2e:c41:: with SMTP id o1-v6mr1871151ljd.152.1544793542606; Fri, 14 Dec 2018 05:19:02 -0800 (PST) Received: from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id o25sm873884lfd.29.2018.12.14.05.19.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Dec 2018 05:19:01 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@dpdk.org, mw@dpdk.org, matua@amazon.com, rk@semihalf.com, stable@dpdk.org Date: Fri, 14 Dec 2018 14:18:31 +0100 Message-Id: <20181214131846.22439-6-mk@semihalf.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20181214131846.22439-1-mk@semihalf.com> References: <20181214131846.22439-1-mk@semihalf.com> Subject: [dpdk-dev] [PATCH 05/20] net/ena: skip packet with wrong req_id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rafal Kozik When invalid req_id is received, the reset should be handled by the application, as it is indicating invalid rings state, so further Rx is not making any sense. Fixes: c2034976673d ("net/ena: add Rx out of order completion") Cc: stable@dpdk.org Signed-off-by: Rafal Kozik Acked-by: Michal Krawczyk --- drivers/net/ena/ena_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 617f85f02..505d9bf30 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1988,6 +1988,8 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, segments++; next_to_clean++; } + if (unlikely(rc)) + break; /* fill mbuf attributes if any */ ena_rx_mbuf_prepare(mbuf_head, &ena_rx_ctx);