common/qat: revert fix for invalid response from firmware
Checks
Commit Message
This reverts commit d09973f6c4df ("common/qat: fix for invalid
response from firmware") due to incorrectly reporting failures
on some older firmware versions.
Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
drivers/common/qat/qat_qp.c | 8 --------
1 file changed, 8 deletions(-)
Comments
> -----Original Message-----
> From: Jozwiak, TomaszX
> Sent: Friday, December 14, 2018 4:20 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
> Subject: [PATCH] common/qat: revert fix for invalid response from firmware
>
> This reverts commit d09973f6c4df ("common/qat: fix for invalid
> response from firmware") due to incorrectly reporting failures
> on some older firmware versions.
>
> Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
On 12/15/2018 12:17 AM, Trahe, Fiona wrote:
>> -----Original Message-----
>> From: Jozwiak, TomaszX
>> Sent: Friday, December 14, 2018 4:20 AM
>> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Jozwiak, TomaszX
>> <tomaszx.jozwiak@intel.com>; akhil.goyal@nxp.com; stable@dpdk.org
>> Subject: [PATCH] common/qat: revert fix for invalid response from firmware
>>
>> This reverts commit d09973f6c4df ("common/qat: fix for invalid
>> response from firmware") due to incorrectly reporting failures
>> on some older firmware versions.
>>
>> Fixes: d09973f6c4df ("common/qat: fix for invalid response from firmware")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
>
Applied to dpdk-next-crypto
Thanks
@@ -634,23 +634,15 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
uint32_t head;
uint32_t resp_counter = 0;
uint8_t *resp_msg;
- uint8_t hdr_flags;
rx_queue = &(tmp_qp->rx_q);
tx_queue = &(tmp_qp->tx_q);
head = rx_queue->head;
resp_msg = (uint8_t *)rx_queue->base_addr + rx_queue->head;
- hdr_flags = ((struct icp_qat_fw_comn_resp_hdr *)resp_msg)->hdr_flags;
while (*(uint32_t *)resp_msg != ADF_RING_EMPTY_SIG &&
resp_counter != nb_ops) {
- if (unlikely(!ICP_QAT_FW_COMN_VALID_FLAG_GET(hdr_flags))) {
- /* Fatal firmware error */
- QAT_LOG(ERR, "QAT Firmware returned invalid response");
- return 0;
- }
-
if (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC)
qat_sym_process_response(ops, resp_msg);
else if (tmp_qp->service_type == QAT_SERVICE_COMPRESSION)