[v2] eal: fix duplicate function declaration
Checks
Commit Message
The rte_eal_get_runtime_dir() function is currently being declared in two
header files.
This API was made public in commit 6911c9fd8fbe ("eal: export function to
get runtime directory"), adding it to rte_eal.h. To make it public, the
'rte' prefix was added to the function so it needed to be modified in the
original location of the declaration, eal_filesystem.h. By only modifying,
and not removing the decalration, it is now a duplicate.
This patch removes the declaration from eal_filesystem.h.
Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")
Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
v2:
- Fix commit message (checkpatch warning)
---
lib/librte_eal/common/eal_filesystem.h | 4 ----
1 file changed, 4 deletions(-)
Comments
On 14-Nov-18 11:20 AM, Kevin Laatz wrote:
> The rte_eal_get_runtime_dir() function is currently being declared in two
> header files.
>
> This API was made public in commit 6911c9fd8fbe ("eal: export function to
> get runtime directory"), adding it to rte_eal.h. To make it public, the
> 'rte' prefix was added to the function so it needed to be modified in the
> original location of the declaration, eal_filesystem.h. By only modifying,
> and not removing the decalration, it is now a duplicate.
>
> This patch removes the declaration from eal_filesystem.h.
>
> Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")
>
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
>
> ---
> v2:
> - Fix commit message (checkpatch warning)
> ---
I was too late to ack the first one...
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
14/11/2018 12:24, Burakov, Anatoly:
> On 14-Nov-18 11:20 AM, Kevin Laatz wrote:
> > The rte_eal_get_runtime_dir() function is currently being declared in two
> > header files.
> >
> > This API was made public in commit 6911c9fd8fbe ("eal: export function to
> > get runtime directory"), adding it to rte_eal.h. To make it public, the
> > 'rte' prefix was added to the function so it needed to be modified in the
> > original location of the declaration, eal_filesystem.h. By only modifying,
> > and not removing the decalration, it is now a duplicate.
> >
> > This patch removes the declaration from eal_filesystem.h.
> >
> > Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory")
> >
> > Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> >
> > ---
> > v2:
> > - Fix commit message (checkpatch warning)
> > ---
>
> I was too late to ack the first one...
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
@@ -25,10 +25,6 @@
int
eal_create_runtime_dir(void);
-/* returns runtime dir */
-const char *
-rte_eal_get_runtime_dir(void);
-
#define RUNTIME_CONFIG_FNAME "config"
static inline const char *
eal_runtime_config_path(void)