diff mbox series

test: fix to skip kni autotest

Message ID 1542117615-30834-1-git-send-email-pallantlax.poornima@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series test: fix to skip kni autotest |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS

Commit Message

Poornima, PallantlaX Nov. 13, 2018, 2 p.m. UTC 
  Kni_autotest should be skipped if rte_kni.ko module is not loaded.
Hence changed return as TEST_SKIPPED.

Fixes: ee1caebc4d ("test/kni: check module dependency")
Cc: stable@dpdk.org

Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
---
 test/test/test_kni.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pattan, Reshma Nov. 13, 2018, 4:08 p.m. UTC | #1 
> -----Original Message-----
> From: Poornima, PallantlaX
> Sent: Tuesday, November 13, 2018 2:00 PM
> To: dev@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; Poornima, PallantlaX
> <pallantlax.poornima@intel.com>; stable@dpdk.org
> Subject: [PATCH] test: fix to skip kni autotest
> 
> Kni_autotest should be skipped if rte_kni.ko module is not loaded.
> Hence changed return as TEST_SKIPPED.
> 
> Fixes: ee1caebc4d ("test/kni: check module dependency")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>

Acked-by: Reshma Pattan <reshma.pattan@intel.cm>
Thomas Monjalon Nov. 14, 2018, 3:52 a.m. UTC | #2 
13/11/2018 17:08, Pattan, Reshma:
> From: Poornima, PallantlaX
> > 
> > Kni_autotest should be skipped if rte_kni.ko module is not loaded.
> > Hence changed return as TEST_SKIPPED.
> > 
> > Fixes: ee1caebc4d ("test/kni: check module dependency")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>
> 
> Acked-by: Reshma Pattan <reshma.pattan@intel.cm>

Applied, thanks
diff mbox series

Patch

diff --git a/test/test/test_kni.c b/test/test/test_kni.c
index f3c19b5a0..c92c09054 100644
--- a/test/test/test_kni.c
+++ b/test/test/test_kni.c
@@ -549,7 +549,7 @@  test_kni(void)
 	if (!dir) {
 		if (errno == ENOENT) {
 			printf("Cannot run UT due to missing rte_kni module\n");
-			return -1;
+			return TEST_SKIPPED;
 		}
 		printf("opendir: %s", strerror(errno));
 		return -1;